* [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
@ 2020-07-09 8:18 Xu Yilun
2020-07-09 9:10 ` Wu, Hao
0 siblings, 1 reply; 10+ messages in thread
From: Xu Yilun @ 2020-07-09 8:18 UTC (permalink / raw)
To: mdf, linux-fpga, linux-kernel
Cc: trix, lgoncalv, Xu Yilun, Wu Hao, Matthew Gerlach, Russ Weight
Add PCIe Device ID for Intel FPGA PAC N3000.
Signed-off-by: Wu Hao <hao.wu@intel.com>
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
---
drivers/fpga/dfl-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
index 73b5153..824aecf 100644
--- a/drivers/fpga/dfl-pci.c
+++ b/drivers/fpga/dfl-pci.c
@@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
#define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
#define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
#define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
+#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
/* VF Device */
#define PCIE_DEVICE_ID_VF_INT_5_X 0xBCBF
#define PCIE_DEVICE_ID_VF_INT_6_X 0xBCC1
@@ -76,6 +77,7 @@ static struct pci_device_id cci_pcie_id_tbl[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_INT_6_X),},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_DSC_1_X),},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_DSC_1_X),},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_PAC_N3000),},
{0,}
};
MODULE_DEVICE_TABLE(pci, cci_pcie_id_tbl);
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-09 8:18 [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 Xu Yilun
@ 2020-07-09 9:10 ` Wu, Hao
2020-07-09 9:35 ` Xu Yilun
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hao @ 2020-07-09 9:10 UTC (permalink / raw)
To: Xu, Yilun, mdf, linux-fpga, linux-kernel
Cc: trix, lgoncalv, Matthew Gerlach, Weight, Russell H
> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
>
> Add PCIe Device ID for Intel FPGA PAC N3000.
>
> Signed-off-by: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> ---
> drivers/fpga/dfl-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> index 73b5153..824aecf 100644
> --- a/drivers/fpga/dfl-pci.c
> +++ b/drivers/fpga/dfl-pci.c
> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
> #define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
> #define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
Should we drop _PF_ here? and also do you want _INTEL_ here?
Thanks
Hao
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-09 9:10 ` Wu, Hao
@ 2020-07-09 9:35 ` Xu Yilun
2020-07-09 10:14 ` Wu, Hao
0 siblings, 1 reply; 10+ messages in thread
From: Xu Yilun @ 2020-07-09 9:35 UTC (permalink / raw)
To: Wu, Hao
Cc: mdf, linux-fpga, linux-kernel, trix, lgoncalv, Matthew Gerlach,
Weight, Russell H
On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> >
> > Add PCIe Device ID for Intel FPGA PAC N3000.
> >
> > Signed-off-by: Wu Hao <hao.wu@intel.com>
> > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > ---
> > drivers/fpga/dfl-pci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > index 73b5153..824aecf 100644
> > --- a/drivers/fpga/dfl-pci.c
> > +++ b/drivers/fpga/dfl-pci.c
> > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> > #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > +#define PCIE_DEVICE_ID_PF_PAC_N30000x0B30
>
> Should we drop _PF_ here? and also do you want _INTEL_ here?
I think we could keep _PF_, also there is no need to support VF of pac
n3000 in product now, but it does exist (ID: 0x0b31).
And add _INTEL_ is good to me.
Then how about this one:
#define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
>
> Thanks
> Hao
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-09 9:35 ` Xu Yilun
@ 2020-07-09 10:14 ` Wu, Hao
2020-07-09 13:00 ` Tom Rix
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hao @ 2020-07-09 10:14 UTC (permalink / raw)
To: Xu, Yilun
Cc: mdf, linux-fpga, linux-kernel, trix, lgoncalv, Matthew Gerlach,
Weight, Russell H
> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > > Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > >
> > > Add PCIe Device ID for Intel FPGA PAC N3000.
> > >
> > > Signed-off-by: Wu Hao <hao.wu@intel.com>
> > > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > > ---
> > > drivers/fpga/dfl-pci.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > index 73b5153..824aecf 100644
> > > --- a/drivers/fpga/dfl-pci.c
> > > +++ b/drivers/fpga/dfl-pci.c
> > > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> > > #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > > #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > > #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > > +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> >
> > Should we drop _PF_ here? and also do you want _INTEL_ here?
>
> I think we could keep _PF_, also there is no need to support VF of pac
> n3000 in product now, but it does exist (ID: 0x0b31).
>
> And add _INTEL_ is good to me.
>
> Then how about this one:
> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
I am just considering the alignment with ids defined in include/linux/pci_ids.h
So drop _PF_ before _INTEL_ would be better? : )
Thanks
Hao
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-09 10:14 ` Wu, Hao
@ 2020-07-09 13:00 ` Tom Rix
2020-07-10 5:24 ` Xu Yilun
0 siblings, 1 reply; 10+ messages in thread
From: Tom Rix @ 2020-07-09 13:00 UTC (permalink / raw)
To: Wu, Hao, Xu, Yilun
Cc: mdf, linux-fpga, linux-kernel, lgoncalv, Matthew Gerlach, Weight,
Russell H
On 7/9/20 3:14 AM, Wu, Hao wrote:
>> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
>>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
>>>>
>>>> Add PCIe Device ID for Intel FPGA PAC N3000.
>>>>
>>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
>>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
>>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
>>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
>>>> ---
>>>> drivers/fpga/dfl-pci.c | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
>>>> index 73b5153..824aecf 100644
>>>> --- a/drivers/fpga/dfl-pci.c
>>>> +++ b/drivers/fpga/dfl-pci.c
>>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
>>>> #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
>>>> #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
>>>> #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
>>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
>>> Should we drop _PF_ here? and also do you want _INTEL_ here?
>> I think we could keep _PF_, also there is no need to support VF of pac
>> n3000 in product now, but it does exist (ID: 0x0b31).
I was wondering about the vf id, thanks!
>>
>> And add _INTEL_ is good to me.
>>
>> Then how about this one:
>> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
> I am just considering the alignment with ids defined in include/linux/pci_ids.h
> So drop _PF_ before _INTEL_ would be better? : )
To be consistent, all the id's are intel and all could drop pf.
Tom
>
> Thanks
> Hao
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-09 13:00 ` Tom Rix
@ 2020-07-10 5:24 ` Xu Yilun
2020-07-10 6:14 ` Wu, Hao
0 siblings, 1 reply; 10+ messages in thread
From: Xu Yilun @ 2020-07-10 5:24 UTC (permalink / raw)
To: Tom Rix
Cc: Wu, Hao, mdf, linux-fpga, linux-kernel, lgoncalv,
Matthew Gerlach, Weight, Russell H
On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote:
>
> On 7/9/20 3:14 AM, Wu, Hao wrote:
> >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> >>>>
> >>>> Add PCIe Device ID for Intel FPGA PAC N3000.
> >>>>
> >>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> >>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> >>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> >>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> >>>> ---
> >>>> drivers/fpga/dfl-pci.c | 2 ++
> >>>> 1 file changed, 2 insertions(+)
> >>>>
> >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> >>>> index 73b5153..824aecf 100644
> >>>> --- a/drivers/fpga/dfl-pci.c
> >>>> +++ b/drivers/fpga/dfl-pci.c
> >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> >>>> #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> >>>> #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> >>>> #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> >>> Should we drop _PF_ here? and also do you want _INTEL_ here?
> >> I think we could keep _PF_, also there is no need to support VF of pac
> >> n3000 in product now, but it does exist (ID: 0x0b31).
>
> I was wondering about the vf id, thanks!
>
> >>
> >> And add _INTEL_ is good to me.
> >>
> >> Then how about this one:
> >> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
> > I am just considering the alignment with ids defined in include/linux/pci_ids.h
> > So drop _PF_ before _INTEL_ would be better? : )
>
> To be consistent, all the id's are intel and all could drop pf.
That's good to me after checking the pci_ids.h. So we have:
#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
>
> Tom
>
> >
> > Thanks
> > Hao
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-10 5:24 ` Xu Yilun
@ 2020-07-10 6:14 ` Wu, Hao
2020-07-10 15:46 ` Moritz Fischer
0 siblings, 1 reply; 10+ messages in thread
From: Wu, Hao @ 2020-07-10 6:14 UTC (permalink / raw)
To: Xu, Yilun, Tom Rix
Cc: mdf, linux-fpga, linux-kernel, lgoncalv, Matthew Gerlach, Weight,
Russell H
> On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote:
> >
> > On 7/9/20 3:14 AM, Wu, Hao wrote:
> > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > >>>>
> > >>>> Add PCIe Device ID for Intel FPGA PAC N3000.
> > >>>>
> > >>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> > >>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > >>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > >>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > >>>> ---
> > >>>> drivers/fpga/dfl-pci.c | 2 ++
> > >>>> 1 file changed, 2 insertions(+)
> > >>>>
> > >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > >>>> index 73b5153..824aecf 100644
> > >>>> --- a/drivers/fpga/dfl-pci.c
> > >>>> +++ b/drivers/fpga/dfl-pci.c
> > >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev
> *pcidev)
> > >>>> #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > >>>> #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > >>>> #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> > >>> Should we drop _PF_ here? and also do you want _INTEL_ here?
> > >> I think we could keep _PF_, also there is no need to support VF of pac
> > >> n3000 in product now, but it does exist (ID: 0x0b31).
> >
> > I was wondering about the vf id, thanks!
> >
> > >>
> > >> And add _INTEL_ is good to me.
> > >>
> > >> Then how about this one:
> > >> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
> > > I am just considering the alignment with ids defined in
> include/linux/pci_ids.h
> > > So drop _PF_ before _INTEL_ would be better? : )
> >
> > To be consistent, all the id's are intel and all could drop pf.
>
> That's good to me after checking the pci_ids.h. So we have:
>
> #define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
Sounds good to me.
Hao
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-10 6:14 ` Wu, Hao
@ 2020-07-10 15:46 ` Moritz Fischer
0 siblings, 0 replies; 10+ messages in thread
From: Moritz Fischer @ 2020-07-10 15:46 UTC (permalink / raw)
To: Wu, Hao
Cc: Xu, Yilun, Tom Rix, mdf, linux-fpga, linux-kernel, lgoncalv,
Matthew Gerlach, Weight, Russell H
On Fri, Jul 10, 2020 at 06:14:19AM +0000, Wu, Hao wrote:
> > On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote:
> > >
> > > On 7/9/20 3:14 AM, Wu, Hao wrote:
> > > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > > >>>>
> > > >>>> Add PCIe Device ID for Intel FPGA PAC N3000.
> > > >>>>
> > > >>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> > > >>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > >>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > >>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > > >>>> ---
> > > >>>> drivers/fpga/dfl-pci.c | 2 ++
> > > >>>> 1 file changed, 2 insertions(+)
> > > >>>>
> > > >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > >>>> index 73b5153..824aecf 100644
> > > >>>> --- a/drivers/fpga/dfl-pci.c
> > > >>>> +++ b/drivers/fpga/dfl-pci.c
> > > >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev
> > *pcidev)
> > > >>>> #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > > >>>> #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > > >>>> #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > > >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> > > >>> Should we drop _PF_ here? and also do you want _INTEL_ here?
> > > >> I think we could keep _PF_, also there is no need to support VF of pac
> > > >> n3000 in product now, but it does exist (ID: 0x0b31).
> > >
> > > I was wondering about the vf id, thanks!
> > >
> > > >>
> > > >> And add _INTEL_ is good to me.
> > > >>
> > > >> Then how about this one:
> > > >> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
> > > > I am just considering the alignment with ids defined in
> > include/linux/pci_ids.h
> > > > So drop _PF_ before _INTEL_ would be better? : )
> > >
> > > To be consistent, all the id's are intel and all could drop pf.
> >
> > That's good to me after checking the pci_ids.h. So we have:
> >
> > #define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
>
> Sounds good to me.
>
> Hao
Heads up I was gonna send out the PR early next week. I can fix this up
myself if you want if you want or you can resend it?
Thanks,
Moritz
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
@ 2020-07-10 15:46 ` Moritz Fischer
0 siblings, 0 replies; 10+ messages in thread
From: Moritz Fischer @ 2020-07-10 15:46 UTC (permalink / raw)
To: Wu, Hao
Cc: Xu, Yilun, Tom Rix, mdf, linux-fpga, linux-kernel, lgoncalv,
Matthew Gerlach, Weight, Russell H
On Fri, Jul 10, 2020 at 06:14:19AM +0000, Wu, Hao wrote:
> > On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote:
> > >
> > > On 7/9/20 3:14 AM, Wu, Hao wrote:
> > > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > > >>>>
> > > >>>> Add PCIe Device ID for Intel FPGA PAC N3000.
> > > >>>>
> > > >>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> > > >>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > >>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > >>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > > >>>> ---
> > > >>>> drivers/fpga/dfl-pci.c | 2 ++
> > > >>>> 1 file changed, 2 insertions(+)
> > > >>>>
> > > >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > >>>> index 73b5153..824aecf 100644
> > > >>>> --- a/drivers/fpga/dfl-pci.c
> > > >>>> +++ b/drivers/fpga/dfl-pci.c
> > > >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev
> > *pcidev)
> > > >>>> #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > > >>>> #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > > >>>> #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > > >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> > > >>> Should we drop _PF_ here? and also do you want _INTEL_ here?
> > > >> I think we could keep _PF_, also there is no need to support VF of pac
> > > >> n3000 in product now, but it does exist (ID: 0x0b31).
> > >
> > > I was wondering about the vf id, thanks!
> > >
> > > >>
> > > >> And add _INTEL_ is good to me.
> > > >>
> > > >> Then how about this one:
> > > >> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
> > > > I am just considering the alignment with ids defined in
> > include/linux/pci_ids.h
> > > > So drop _PF_ before _INTEL_ would be better? : )
> > >
> > > To be consistent, all the id's are intel and all could drop pf.
> >
> > That's good to me after checking the pci_ids.h. So we have:
> >
> > #define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
>
> Sounds good to me.
>
> Hao
Heads up I was gonna send out the PR early next week. I can fix this up
myself if you want if you want or you can resend it?
Thanks,
Moritz
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-10 15:46 ` Moritz Fischer
(?)
@ 2020-07-13 1:52 ` Xu Yilun
-1 siblings, 0 replies; 10+ messages in thread
From: Xu Yilun @ 2020-07-13 1:52 UTC (permalink / raw)
To: Moritz Fischer
Cc: Wu, Hao, Tom Rix, linux-fpga, linux-kernel, lgoncalv,
Matthew Gerlach, Weight, Russell H, yilun.xu
On Fri, Jul 10, 2020 at 08:46:16AM -0700, Moritz Fischer wrote:
> On Fri, Jul 10, 2020 at 06:14:19AM +0000, Wu, Hao wrote:
> > > On Thu, Jul 09, 2020 at 06:00:40AM -0700, Tom Rix wrote:
> > > >
> > > > On 7/9/20 3:14 AM, Wu, Hao wrote:
> > > > >> On Thu, Jul 09, 2020 at 05:10:49PM +0800, Wu, Hao wrote:
> > > > >>>> Subject: [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
> > > > >>>>
> > > > >>>> Add PCIe Device ID for Intel FPGA PAC N3000.
> > > > >>>>
> > > > >>>> Signed-off-by: Wu Hao <hao.wu@intel.com>
> > > > >>>> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > > >>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> > > > >>>> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > > > >>>> ---
> > > > >>>> drivers/fpga/dfl-pci.c | 2 ++
> > > > >>>> 1 file changed, 2 insertions(+)
> > > > >>>>
> > > > >>>> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> > > > >>>> index 73b5153..824aecf 100644
> > > > >>>> --- a/drivers/fpga/dfl-pci.c
> > > > >>>> +++ b/drivers/fpga/dfl-pci.c
> > > > >>>> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev
> > > *pcidev)
> > > > >>>> #define PCIE_DEVICE_ID_PF_INT_5_X0xBCBD
> > > > >>>> #define PCIE_DEVICE_ID_PF_INT_6_X0xBCC0
> > > > >>>> #define PCIE_DEVICE_ID_PF_DSC_1_X0x09C4
> > > > >>>> +#define PCIE_DEVICE_ID_PF_PAC_N3000 0x0B30
> > > > >>> Should we drop _PF_ here? and also do you want _INTEL_ here?
> > > > >> I think we could keep _PF_, also there is no need to support VF of pac
> > > > >> n3000 in product now, but it does exist (ID: 0x0b31).
> > > >
> > > > I was wondering about the vf id, thanks!
> > > >
> > > > >>
> > > > >> And add _INTEL_ is good to me.
> > > > >>
> > > > >> Then how about this one:
> > > > >> #define PCIE_DEVICE_ID_PF_INTEL_PAC_N3000 0x0B30
> > > > > I am just considering the alignment with ids defined in
> > > include/linux/pci_ids.h
> > > > > So drop _PF_ before _INTEL_ would be better? : )
> > > >
> > > > To be consistent, all the id's are intel and all could drop pf.
> > >
> > > That's good to me after checking the pci_ids.h. So we have:
> > >
> > > #define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
> >
> > Sounds good to me.
> >
> > Hao
>
> Heads up I was gonna send out the PR early next week. I can fix this up
> myself if you want if you want or you can resend it?
I sent the v2 patch for this. Please help check it.
Thanks,
Yilun
>
> Thanks,
> Moritz
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-07-13 1:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09 8:18 [PATCH] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 Xu Yilun
2020-07-09 9:10 ` Wu, Hao
2020-07-09 9:35 ` Xu Yilun
2020-07-09 10:14 ` Wu, Hao
2020-07-09 13:00 ` Tom Rix
2020-07-10 5:24 ` Xu Yilun
2020-07-10 6:14 ` Wu, Hao
2020-07-10 15:46 ` Moritz Fischer
2020-07-10 15:46 ` Moritz Fischer
2020-07-13 1:52 ` Xu Yilun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.