All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Tim C" <tim.c.chen@intel.com>
To: Roman Gushchin <roman.gushchin@linux.dev>,
	"Sun, Jiebin" <jiebin.sun@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
	"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
	"mhocko@kernel.org" <mhocko@kernel.org>,
	"shakeelb@google.com" <shakeelb@google.com>,
	"songmuchun@bytedance.com" <songmuchun@bytedance.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"Huang, Ying" <ying.huang@intel.com>,
	"amadeuszx.slawinski@linux.intel.com" 
	<amadeuszx.slawinski@linux.intel.com>,
	"Li, Tianyou" <tianyou.li@intel.com>,
	"Guo, Wangyang" <wangyang.guo@intel.com>
Subject: RE: [PATCH] mm: Remove the redundant updating of stats_flush_threshold
Date: Fri, 22 Jul 2022 17:57:56 +0000	[thread overview]
Message-ID: <DM6PR11MB410736BFD198D38BBCE9E064DC909@DM6PR11MB4107.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YtrY5V+dZl4+Gtz4@castle>

>
>On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote:
>> From: jiebin sun <jiebin.sun@intel.com>
>>
>> Remove the redundant updating of stats_flush_threshold. If the global
>> var stats_flush_threshold has exceeded the trigger value for
>> __mem_cgroup_flush_stats, further increment is unnecessary.
>>
>> Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads).
>>
>> Score gain: 1.95x
>> Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%)
>>
>> CPU: ICX 8380 x 2 sockets
>> Core number: 40 x 2 physical cores
>> Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads)
>>
>> Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
>
>Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
>
>Good optimization, thanks!

Looks good. Nice performance improvement.

Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Chen, Tim C" <tim.c.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Roman Gushchin
	<roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
	"Sun,
	Jiebin" <jiebin.sun-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
	<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org"
	<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	"mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org"
	<shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	"songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org"
	<songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	"akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	"Huang,
	Ying" <ying.huang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"amadeuszx.slawinski-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<amadeuszx.slawinski-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"Li,
	Tianyou" <tianyou.li-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	"Guo,
	Wangyang" <wangyang.guo-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: RE: [PATCH] mm: Remove the redundant updating of stats_flush_threshold
Date: Fri, 22 Jul 2022 17:57:56 +0000	[thread overview]
Message-ID: <DM6PR11MB410736BFD198D38BBCE9E064DC909@DM6PR11MB4107.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YtrY5V+dZl4+Gtz4@castle>

>
>On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote:
>> From: jiebin sun <jiebin.sun-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> Remove the redundant updating of stats_flush_threshold. If the global
>> var stats_flush_threshold has exceeded the trigger value for
>> __mem_cgroup_flush_stats, further increment is unnecessary.
>>
>> Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads).
>>
>> Score gain: 1.95x
>> Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%)
>>
>> CPU: ICX 8380 x 2 sockets
>> Core number: 40 x 2 physical cores
>> Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads)
>>
>> Signed-off-by: Jiebin Sun <jiebin.sun-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
>Reviewed-by: Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>
>
>Good optimization, thanks!

Looks good. Nice performance improvement.

Reviewed-by: Tim Chen <tim.c.chen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

  reply	other threads:[~2022-07-22 17:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22 16:49 [PATCH] mm: Remove the redundant updating of stats_flush_threshold Jiebin Sun
2022-07-22 16:49 ` Jiebin Sun
2022-07-22 16:22 ` Shakeel Butt
2022-07-22 17:05 ` Roman Gushchin
2022-07-22 17:05   ` Roman Gushchin
2022-07-22 17:57   ` Chen, Tim C [this message]
2022-07-22 17:57     ` Chen, Tim C
2022-07-23 13:43 ` Muchun Song
2022-07-23 13:43   ` Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB410736BFD198D38BBCE9E064DC909@DM6PR11MB4107.namprd11.prod.outlook.com \
    --to=tim.c.chen@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=jiebin.sun@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeelb@google.com \
    --cc=songmuchun@bytedance.com \
    --cc=tianyou.li@intel.com \
    --cc=wangyang.guo@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.