* [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next
@ 2020-07-30 14:25 Matt Coffin
2020-07-31 1:20 ` Quan, Evan
0 siblings, 1 reply; 4+ messages in thread
From: Matt Coffin @ 2020-07-30 14:25 UTC (permalink / raw)
To: Quan, Evan, amd-gfx; +Cc: Alex Deucher
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hey Evan,
I've been having an issue with uploading `pp_table`s on recent
`amd-staging-drm-next` kernels. I bisected the issue, and it came back
to a commit of yours - ec8ee23f610578c71885a36ddfcf58d35cccab67.
I didn't have your gitlab handle to CC you on the issue, so I thought
I'd at least alert you to it.
Here's a link to the issue on GitLab:
https://gitlab.freedesktop.org/drm/amd/-/issues/1243
I'd appreciate any help or insight you could offer here as I work on a
fix.
First bad commit header:
commit ec8ee23f610578c71885a36ddfcf58d35cccab67 (refs/bisect/bad)
Author: Evan Quan <evan.quan@amd.com>
Date: Wed Jun 10 16:52:32 2020 +0800
drm/amd/powerplay: update Navi10 default dpm table setup
Cache all clocks levels for every dpm table. They are needed
by other APIs.
Change-Id: I8114cf31e6ec8c9af4578d51749eb213befdcc71
Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Thanks everyone, and cheers,
Matt Coffin
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwz6NkrTNYgbdBT2N4mzKau7FyAcFAl8i2FAACgkQ4mzKau7F
yAfhzQ//a4EgvriD6AdSFUgYmmdMnf1iN+cIDj8JnTuoOgRs+hV2ObIywyE4HZCC
yd1+GdY8/P1VerdC6d5wpTozUBWQGvCnJRnF2kJ7ZKyjsITtpOh6qUWTPbKi7GrU
qz9DD+BIMIcRW/qp+sqVBE0z6vEJSbEkoCF4njV/Qzy178XFNnt0rrScGTsIa+yj
gvUw51m3T9qzMl9pglpUxZv9k3jQfirMZYDv2O2Ds7CIptPGeHDiCW7aNRAPYrmF
UYnt7a2W6fhOrG7x2In8sMECsE/uNa8GMqxAXenRPDok093owHs9zg5lVLbHvvA8
z3iB11n8VT6TknW6YpCm5uE3Lynq1acAIoVO/8m7z56SAIco+xxTkOKt5SWxZGvS
wQN9teaMXYSzHR/d/RTSZXjxBcOYgokIJrcb1hmJd5zw/gvZeeMfhCpyAbnhbOpR
wC6wbic39xNza9sIZrg5NCSx6UcBpfwjKygN7HSutua1nZi9WbvviY6LL69JYhmK
Jyg8RgjgiUPrLomtZx60vLi54dAupyDqJZv2FRHMQTxC+7HagHcDItK8a1KIoNIW
wsvUbonsyyMMxvrTbMPcrTm+yRkFmaP+1fnpgjL1WCHgd4imcl68sV22D64OCT/4
YzfWzhN+dIIUnfy0eWiiLMlOsEWGBN+YPVdLxodK0okjDcQJQTA=
=CzXz
-----END PGP SIGNATURE-----
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next
2020-07-30 14:25 [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next Matt Coffin
@ 2020-07-31 1:20 ` Quan, Evan
2020-08-03 4:50 ` Quan, Evan
0 siblings, 1 reply; 4+ messages in thread
From: Quan, Evan @ 2020-07-31 1:20 UTC (permalink / raw)
To: Matt Coffin, amd-gfx; +Cc: Alex Deucher
[AMD Official Use Only - Internal Distribution Only]
Thanks for reporting this. I will check it.
BR
Evan
-----Original Message-----
From: Matt Coffin <mcoffin13@gmail.com>
Sent: Thursday, July 30, 2020 10:25 PM
To: Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexdeucher@gmail.com>
Subject: [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hey Evan,
I've been having an issue with uploading `pp_table`s on recent `amd-staging-drm-next` kernels. I bisected the issue, and it came back to a commit of yours - ec8ee23f610578c71885a36ddfcf58d35cccab67.
I didn't have your gitlab handle to CC you on the issue, so I thought I'd at least alert you to it.
Here's a link to the issue on GitLab:
https://gitlab.freedesktop.org/drm/amd/-/issues/1243
I'd appreciate any help or insight you could offer here as I work on a fix.
First bad commit header:
commit ec8ee23f610578c71885a36ddfcf58d35cccab67 (refs/bisect/bad)
Author: Evan Quan <evan.quan@amd.com>
Date: Wed Jun 10 16:52:32 2020 +0800
drm/amd/powerplay: update Navi10 default dpm table setup
Cache all clocks levels for every dpm table. They are needed
by other APIs.
Change-Id: I8114cf31e6ec8c9af4578d51749eb213befdcc71
Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Thanks everyone, and cheers,
Matt Coffin
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwz6NkrTNYgbdBT2N4mzKau7FyAcFAl8i2FAACgkQ4mzKau7F
yAfhzQ//a4EgvriD6AdSFUgYmmdMnf1iN+cIDj8JnTuoOgRs+hV2ObIywyE4HZCC
yd1+GdY8/P1VerdC6d5wpTozUBWQGvCnJRnF2kJ7ZKyjsITtpOh6qUWTPbKi7GrU
qz9DD+BIMIcRW/qp+sqVBE0z6vEJSbEkoCF4njV/Qzy178XFNnt0rrScGTsIa+yj
gvUw51m3T9qzMl9pglpUxZv9k3jQfirMZYDv2O2Ds7CIptPGeHDiCW7aNRAPYrmF
UYnt7a2W6fhOrG7x2In8sMECsE/uNa8GMqxAXenRPDok093owHs9zg5lVLbHvvA8
z3iB11n8VT6TknW6YpCm5uE3Lynq1acAIoVO/8m7z56SAIco+xxTkOKt5SWxZGvS
wQN9teaMXYSzHR/d/RTSZXjxBcOYgokIJrcb1hmJd5zw/gvZeeMfhCpyAbnhbOpR
wC6wbic39xNza9sIZrg5NCSx6UcBpfwjKygN7HSutua1nZi9WbvviY6LL69JYhmK
Jyg8RgjgiUPrLomtZx60vLi54dAupyDqJZv2FRHMQTxC+7HagHcDItK8a1KIoNIW
wsvUbonsyyMMxvrTbMPcrTm+yRkFmaP+1fnpgjL1WCHgd4imcl68sV22D64OCT/4
YzfWzhN+dIIUnfy0eWiiLMlOsEWGBN+YPVdLxodK0okjDcQJQTA=
=CzXz
-----END PGP SIGNATURE-----
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next
2020-07-31 1:20 ` Quan, Evan
@ 2020-08-03 4:50 ` Quan, Evan
2020-08-03 16:37 ` Matt Coffin
0 siblings, 1 reply; 4+ messages in thread
From: Quan, Evan @ 2020-08-03 4:50 UTC (permalink / raw)
To: Matt Coffin, amd-gfx; +Cc: Alex Deucher
[AMD Official Use Only - Internal Distribution Only]
Hi Matt,
I just sent out two patches to fix the issue reported here. It worked on my local env.
Please confirm on your platform.
https://lists.freedesktop.org/archives/amd-gfx/2020-August/052245.html
https://lists.freedesktop.org/archives/amd-gfx/2020-August/052246.html
BR,
Evan
-----Original Message-----
From: Quan, Evan
Sent: Friday, July 31, 2020 9:20 AM
To: Matt Coffin <mcoffin13@gmail.com>; amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexdeucher@gmail.com>
Subject: RE: [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next
Thanks for reporting this. I will check it.
BR
Evan
-----Original Message-----
From: Matt Coffin <mcoffin13@gmail.com>
Sent: Thursday, July 30, 2020 10:25 PM
To: Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexdeucher@gmail.com>
Subject: [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hey Evan,
I've been having an issue with uploading `pp_table`s on recent `amd-staging-drm-next` kernels. I bisected the issue, and it came back to a commit of yours - ec8ee23f610578c71885a36ddfcf58d35cccab67.
I didn't have your gitlab handle to CC you on the issue, so I thought I'd at least alert you to it.
Here's a link to the issue on GitLab:
https://gitlab.freedesktop.org/drm/amd/-/issues/1243
I'd appreciate any help or insight you could offer here as I work on a fix.
First bad commit header:
commit ec8ee23f610578c71885a36ddfcf58d35cccab67 (refs/bisect/bad)
Author: Evan Quan <evan.quan@amd.com>
Date: Wed Jun 10 16:52:32 2020 +0800
drm/amd/powerplay: update Navi10 default dpm table setup
Cache all clocks levels for every dpm table. They are needed
by other APIs.
Change-Id: I8114cf31e6ec8c9af4578d51749eb213befdcc71
Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Thanks everyone, and cheers,
Matt Coffin
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwz6NkrTNYgbdBT2N4mzKau7FyAcFAl8i2FAACgkQ4mzKau7F
yAfhzQ//a4EgvriD6AdSFUgYmmdMnf1iN+cIDj8JnTuoOgRs+hV2ObIywyE4HZCC
yd1+GdY8/P1VerdC6d5wpTozUBWQGvCnJRnF2kJ7ZKyjsITtpOh6qUWTPbKi7GrU
qz9DD+BIMIcRW/qp+sqVBE0z6vEJSbEkoCF4njV/Qzy178XFNnt0rrScGTsIa+yj
gvUw51m3T9qzMl9pglpUxZv9k3jQfirMZYDv2O2Ds7CIptPGeHDiCW7aNRAPYrmF
UYnt7a2W6fhOrG7x2In8sMECsE/uNa8GMqxAXenRPDok093owHs9zg5lVLbHvvA8
z3iB11n8VT6TknW6YpCm5uE3Lynq1acAIoVO/8m7z56SAIco+xxTkOKt5SWxZGvS
wQN9teaMXYSzHR/d/RTSZXjxBcOYgokIJrcb1hmJd5zw/gvZeeMfhCpyAbnhbOpR
wC6wbic39xNza9sIZrg5NCSx6UcBpfwjKygN7HSutua1nZi9WbvviY6LL69JYhmK
Jyg8RgjgiUPrLomtZx60vLi54dAupyDqJZv2FRHMQTxC+7HagHcDItK8a1KIoNIW
wsvUbonsyyMMxvrTbMPcrTm+yRkFmaP+1fnpgjL1WCHgd4imcl68sV22D64OCT/4
YzfWzhN+dIIUnfy0eWiiLMlOsEWGBN+YPVdLxodK0okjDcQJQTA=
=CzXz
-----END PGP SIGNATURE-----
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next
2020-08-03 4:50 ` Quan, Evan
@ 2020-08-03 16:37 ` Matt Coffin
0 siblings, 0 replies; 4+ messages in thread
From: Matt Coffin @ 2020-08-03 16:37 UTC (permalink / raw)
To: Quan, Evan, amd-gfx; +Cc: Alex Deucher
[-- Attachment #1.1.1: Type: text/plain, Size: 2560 bytes --]
Hi Evan,
Thanks for the work. It would have taken me probably forever to find that.
I replied to your series with a Tested-by, and I tested locally. With
edad8312cbbf9a33c86873fc4093664f150dd5c1 reverted to fix the sysfs
interfaces, and your series, I once again have a 100% working OD system!
Thanks for the snappy work,
Matt
On 8/2/20 10:50 PM, Quan, Evan wrote:
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Matt,
>
> I just sent out two patches to fix the issue reported here. It worked
on my local env.
> Please confirm on your platform.
> https://lists.freedesktop.org/archives/amd-gfx/2020-August/052245.html
> https://lists.freedesktop.org/archives/amd-gfx/2020-August/052246.html
>
> BR,
> Evan
> -----Original Message-----
> From: Quan, Evan
> Sent: Friday, July 31, 2020 9:20 AM
> To: Matt Coffin <mcoffin13@gmail.com>; amd-gfx@lists.freedesktop.org
> Cc: Alex Deucher <alexdeucher@gmail.com>
> Subject: RE: [Bug][Regression][Bisected] pp_table writes began to fail
for Navi10 on amd-staging-drm-next
>
> Thanks for reporting this. I will check it.
>
> BR
> Evan
> -----Original Message-----
> From: Matt Coffin <mcoffin13@gmail.com>
> Sent: Thursday, July 30, 2020 10:25 PM
> To: Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Alex Deucher <alexdeucher@gmail.com>
> Subject: [Bug][Regression][Bisected] pp_table writes began to fail for
Navi10 on amd-staging-drm-next
>
> Hey Evan,
>
> I've been having an issue with uploading `pp_table`s on recent `amd-staging-drm-next` kernels. I bisected the issue, and it came back to a commit of yours - ec8ee23f610578c71885a36ddfcf58d35cccab67.
>
> I didn't have your gitlab handle to CC you on the issue, so I thought I'd at least alert you to it.
>
> Here's a link to the issue on GitLab:
> https://gitlab.freedesktop.org/drm/amd/-/issues/1243
>
> I'd appreciate any help or insight you could offer here as I work on a fix.
>
> First bad commit header:
>
> commit ec8ee23f610578c71885a36ddfcf58d35cccab67 (refs/bisect/bad)
> Author: Evan Quan <evan.quan@amd.com>
> Date: Wed Jun 10 16:52:32 2020 +0800
>
> drm/amd/powerplay: update Navi10 default dpm table setup
>
> Cache all clocks levels for every dpm table. They are needed
> by other APIs.
>
> Change-Id: I8114cf31e6ec8c9af4578d51749eb213befdcc71
> Signed-off-by: Evan Quan <evan.quan@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> Thanks everyone, and cheers,
> Matt Coffin
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-03 16:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 14:25 [Bug][Regression][Bisected] pp_table writes began to fail for Navi10 on amd-staging-drm-next Matt Coffin
2020-07-31 1:20 ` Quan, Evan
2020-08-03 4:50 ` Quan, Evan
2020-08-03 16:37 ` Matt Coffin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.