* Re: [PATCH] drm/amd/pm: remove some useless code for vangogh
2021-02-01 8:45 [PATCH] drm/amd/pm: remove some useless code for vangogh Xiaojian Du
@ 2021-02-01 8:50 ` Wang, Kevin(Yang)
2021-02-01 9:03 ` Huang Rui
2021-02-01 9:10 ` Quan, Evan
2 siblings, 0 replies; 4+ messages in thread
From: Wang, Kevin(Yang) @ 2021-02-01 8:50 UTC (permalink / raw)
To: Du, Xiaojian, amd-gfx; +Cc: Huang, Ray, Quan, Evan
[-- Attachment #1.1: Type: text/plain, Size: 1533 bytes --]
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Kevin Wang <kevin1.wang@amd.com>
Notes:
we'd better to avoid adding ASIC type check in common file...
Best Regards,
Kevin
________________________________
From: Du, Xiaojian <Xiaojian.Du@amd.com>
Sent: Monday, February 1, 2021 4:45 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Huang, Ray <Ray.Huang@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: [PATCH] drm/amd/pm: remove some useless code for vangogh
This patch is to remove some useless code for vangogh.
In the earlier code, vangogh can't finish all the sequence of
smu late init. But now vangogh has one stable work state,so
remove the useless code.
Signed-off-by: Xiaojian Du <Xiaojian.Du@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index f958b02f9317..30e2a0ac3279 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -612,9 +612,6 @@ static int smu_late_init(void *handle)
return ret;
}
- if (adev->asic_type == CHIP_VANGOGH)
- return 0;
-
ret = smu_set_default_od_settings(smu);
if (ret) {
dev_err(adev->dev, "Failed to setup default OD settings!\n");
--
2.17.1
[-- Attachment #1.2: Type: text/html, Size: 3709 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd/pm: remove some useless code for vangogh
2021-02-01 8:45 [PATCH] drm/amd/pm: remove some useless code for vangogh Xiaojian Du
2021-02-01 8:50 ` Wang, Kevin(Yang)
@ 2021-02-01 9:03 ` Huang Rui
2021-02-01 9:10 ` Quan, Evan
2 siblings, 0 replies; 4+ messages in thread
From: Huang Rui @ 2021-02-01 9:03 UTC (permalink / raw)
To: Du, Xiaojian; +Cc: Wang, Kevin(Yang), Quan, Evan, amd-gfx
On Mon, Feb 01, 2021 at 04:45:58PM +0800, Du, Xiaojian wrote:
> This patch is to remove some useless code for vangogh.
> In the earlier code, vangogh can't finish all the sequence of
> smu late init. But now vangogh has one stable work state,so
> remove the useless code.
>
> Signed-off-by: Xiaojian Du <Xiaojian.Du@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> index f958b02f9317..30e2a0ac3279 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
> @@ -612,9 +612,6 @@ static int smu_late_init(void *handle)
> return ret;
> }
>
> - if (adev->asic_type == CHIP_VANGOGH)
> - return 0;
> -
> ret = smu_set_default_od_settings(smu);
> if (ret) {
> dev_err(adev->dev, "Failed to setup default OD settings!\n");
> --
> 2.17.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] drm/amd/pm: remove some useless code for vangogh
2021-02-01 8:45 [PATCH] drm/amd/pm: remove some useless code for vangogh Xiaojian Du
2021-02-01 8:50 ` Wang, Kevin(Yang)
2021-02-01 9:03 ` Huang Rui
@ 2021-02-01 9:10 ` Quan, Evan
2 siblings, 0 replies; 4+ messages in thread
From: Quan, Evan @ 2021-02-01 9:10 UTC (permalink / raw)
To: Du, Xiaojian, amd-gfx; +Cc: Huang, Ray, Wang, Kevin(Yang)
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Evan Quan <evan.quan@amd.com>
-----Original Message-----
From: Du, Xiaojian <Xiaojian.Du@amd.com>
Sent: Monday, February 1, 2021 4:46 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray <Ray.Huang@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>
Subject: [PATCH] drm/amd/pm: remove some useless code for vangogh
This patch is to remove some useless code for vangogh.
In the earlier code, vangogh can't finish all the sequence of
smu late init. But now vangogh has one stable work state,so
remove the useless code.
Signed-off-by: Xiaojian Du <Xiaojian.Du@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index f958b02f9317..30e2a0ac3279 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -612,9 +612,6 @@ static int smu_late_init(void *handle)
return ret;
}
-if (adev->asic_type == CHIP_VANGOGH)
-return 0;
-
ret = smu_set_default_od_settings(smu);
if (ret) {
dev_err(adev->dev, "Failed to setup default OD settings!\n");
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread