Re: enable dispatch/draw tests for renoir

* Re: enable dispatch/draw tests for renoir
@ 2019-11-04 20:47         ` Olsak, Marek
  0 siblings, 0 replies; 2+ messages in thread
From: Olsak, Marek @ 2019-11-04 20:47 UTC (permalink / raw)
  To: Zhu, Changfeng, Cui, Flora, brahma_sw_dev,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
  Cc: Deucher, Alexander, Huang, Shimmer, Huang, Ray, Liu, Aaron,
	Zhang, Hawking


[-- Attachment #1.1: Type: text/plain, Size: 5320 bytes --]

Reviewed-by: Marek Olšák <marek.olsak-5C7GfCeVMHo@public.gmane.org>

Marek
________________________________
From: Zhu, Changfeng <Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org>
Sent: November 4, 2019 02:07
To: Cui, Flora <Flora.Cui-5C7GfCeVMHo@public.gmane.org>; brahma_sw_dev <brahma_sw_dev-5C7GfCeVMHo@public.gmane.org>; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>; Liu, Aaron <Aaron.Liu@amd.com>; Zhang, Hawking <Hawking.Zhang-5C7GfCeVMHo@public.gmane.org>; Huang, Ray <Ray.Huang@amd.com>; Huang, Shimmer <Xinmei.Huang-5C7GfCeVMHo@public.gmane.org>; Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>; Olsak, Marek <Marek.Olsak-5C7GfCeVMHo@public.gmane.org>
Subject: RE: enable dispatch/draw tests for renoir


Thanks for review, Flora.



Hi Alex & Marek,



Here is a libdrm patch for Renoir dispatch/draw tests.



Could you please help review it? It needs to be upstream.



BR,

Changfeng.



From: Cui, Flora <Flora.Cui-5C7GfCeVMHo@public.gmane.org>
Sent: Monday, November 4, 2019 1:21 PM
To: Zhu, Changfeng <Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org>; brahma_sw_dev <brahma_sw_dev@amd.com>
Cc: Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>; Liu, Aaron <Aaron.Liu@amd.com>; Zhang, Hawking <Hawking.Zhang-5C7GfCeVMHo@public.gmane.org>; Huang, Ray <Ray.Huang@amd.com>; Huang, Shimmer <Xinmei.Huang-5C7GfCeVMHo@public.gmane.org>
Subject: RE: enable dispatch/draw tests for renoir



Good catch. rb



From: Zhu, Changfeng <Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org<mailto:Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org>>
Sent: Monday, November 4, 2019 11:59 AM
To: brahma_sw_dev <brahma_sw_dev-5C7GfCeVMHo@public.gmane.org<mailto:brahma_sw_dev-5C7GfCeVMHo@public.gmane.org>>
Cc: Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org<mailto:Alexander.Deucher@amd.com>>; Liu, Aaron <Aaron.Liu-5C7GfCeVMHo@public.gmane.org<mailto:Aaron.Liu-5C7GfCeVMHo@public.gmane.org>>; Cui, Flora <Flora.Cui-5C7GfCeVMHo@public.gmane.org<mailto:Flora.Cui-5C7GfCeVMHo@public.gmane.org>>; Zhang, Hawking <Hawking.Zhang-5C7GfCeVMHo@public.gmane.org<mailto:Hawking.Zhang-5C7GfCeVMHo@public.gmane.org>>; Huang, Ray <Ray.Huang-urvtwAKJhsc@public.gmane.orgm<mailto:Ray.Huang-5C7GfCeVMHo@public.gmane.org>>; Huang, Shimmer <Xinmei.Huang-5C7GfCeVMHo@public.gmane.org<mailto:Xinmei.Huang-5C7GfCeVMHo@public.gmane.org>>
Subject: enable dispatch/draw tests for renoir



Hi Ray & Flora,



It can run dispatch/draw tests on new Renoir chips. So we can take back dispatch/draw tests for Renoir.



Could you please help review this patch?



>From 793b7fd4dd1580f29e27bd2a90da787535abee14 Mon Sep 17 00:00:00 2001

From: changzhu <Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org<mailto:Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org>>

Date: Mon, 4 Nov 2019 11:48:19 +0800

Subject: [PATCH libdrm] tests/amdgpu: enable dispatch/draw tests for Renoir



It can run dispatch/draw tests on new renoir chips. So it needs to

enable dispatch/draw tests for Renoir again.



Change-Id: I3a72a4bbfe0fc663ee0e3e58d8e9c304f513e568

Signed-off-by: changzhu <Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org<mailto:Changfeng.Zhu-5C7GfCeVMHo@public.gmane.org>>

---

tests/amdgpu/basic_tests.c | 16 +---------------

1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/tests/amdgpu/basic_tests.c b/tests/amdgpu/basic_tests.c

index e75b9d0d..a57dcbb4 100644

--- a/tests/amdgpu/basic_tests.c

+++ b/tests/amdgpu/basic_tests.c

@@ -592,20 +592,6 @@ int suite_basic_tests_init(void)



              family_id = gpu_info.family_id;



-             if (gpu_info.asic_id == 0x1636) {

-                           if (amdgpu_set_test_active("Basic Tests",

-                                                                          "Dispatch Test",

-                                                                          CU_FALSE))

-                                          fprintf(stderr, "test deactivation failed - %s\n",

-                                                        CU_get_error_msg());

-

-                           if (amdgpu_set_test_active("Basic Tests",

-                                                                          "Draw Test",

-                                                                          CU_FALSE))

-                                          fprintf(stderr, "test deactivation failed - %s\n",

-                                                        CU_get_error_msg());

-             }

-

             return CUE_SUCCESS;

}



@@ -2992,7 +2978,7 @@ void amdgpu_memset_draw(amdgpu_device_handle device_handle,

             resources[1] = bo_shader_ps;

             resources[2] = bo_shader_vs;

             resources[3] = bo_cmd;

-             r = amdgpu_bo_list_create(device_handle, 3, resources, NULL, &bo_list);

+            r = amdgpu_bo_list_create(device_handle, 4, resources, NULL, &bo_list);

             CU_ASSERT_EQUAL(r, 0);



              ib_info.ib_mc_address = mc_address_cmd;

--

2.17.1





BR,

Changfeng.

[-- Attachment #1.2: Type: text/html, Size: 13643 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread