* [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
@ 2020-06-05 13:04 Likun Gao
2020-06-05 14:04 ` Zhang, Hawking
0 siblings, 1 reply; 5+ messages in thread
From: Likun Gao @ 2020-06-05 13:04 UTC (permalink / raw)
To: amd-gfx; +Cc: Feifei Xu, Likun Gao, Hawking Zhang
From: Likun Gao <Likun.Gao@amd.com>
Skip for reserved fb size query for the ASIC older than navi10, as those
asic do not need for TMR region reserve and may get an invalid value.
Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Change-Id: Idbc57805b8070f27ba6c3cf22f1892d6dab92f06
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index a9adccfda4c0..e2a64ae7bcaf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -603,6 +603,9 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev)
u8 frev, crev;
int fw_reserved_fb_size;
+ if (adev->asic_type < CHIP_NAVI10)
+ return 0;
+
index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
firmwareinfo);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
2020-06-05 13:04 [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic Likun Gao
@ 2020-06-05 14:04 ` Zhang, Hawking
2020-06-05 14:10 ` Zhang, Hawking
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Hawking @ 2020-06-05 14:04 UTC (permalink / raw)
To: Gao, Likun, amd-gfx; +Cc: Xu, Feifei
[AMD Public Use]
Does it mean there is legacy VBIOS that even doesn't have firmwareinfo table and introduce crash?
I think we expect the atomfirmware interface return 0 for ASICs prior to Sienna Cichlid
Regards,
Hawking
-----Original Message-----
From: Gao, Likun <Likun.Gao@amd.com>
Sent: Friday, June 5, 2020 21:04
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Gao, Likun <Likun.Gao@amd.com>
Subject: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
From: Likun Gao <Likun.Gao@amd.com>
Skip for reserved fb size query for the ASIC older than navi10, as those asic do not need for TMR region reserve and may get an invalid value.
Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Change-Id: Idbc57805b8070f27ba6c3cf22f1892d6dab92f06
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index a9adccfda4c0..e2a64ae7bcaf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -603,6 +603,9 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev)
u8 frev, crev;
int fw_reserved_fb_size;
+ if (adev->asic_type < CHIP_NAVI10)
+ return 0;
+
index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
firmwareinfo);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
2020-06-05 14:04 ` Zhang, Hawking
@ 2020-06-05 14:10 ` Zhang, Hawking
2020-06-05 14:13 ` Zhang, Hawking
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Hawking @ 2020-06-05 14:10 UTC (permalink / raw)
To: Zhang, Hawking, Gao, Likun, amd-gfx; +Cc: Xu, Feifei
[AMD Public Use]
Wait, I see the risk. the amdgpu_ttm_init is general one even the prior Vega10 ASIC will invoke it, and they don't have atomfirmware support.
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Hawking
Sent: Friday, June 5, 2020 22:05
To: Gao, Likun <Likun.Gao@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Xu, Feifei <Feifei.Xu@amd.com>
Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
[AMD Public Use]
Does it mean there is legacy VBIOS that even doesn't have firmwareinfo table and introduce crash?
I think we expect the atomfirmware interface return 0 for ASICs prior to Sienna Cichlid
Regards,
Hawking
-----Original Message-----
From: Gao, Likun <Likun.Gao@amd.com>
Sent: Friday, June 5, 2020 21:04
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Gao, Likun <Likun.Gao@amd.com>
Subject: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
From: Likun Gao <Likun.Gao@amd.com>
Skip for reserved fb size query for the ASIC older than navi10, as those asic do not need for TMR region reserve and may get an invalid value.
Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Change-Id: Idbc57805b8070f27ba6c3cf22f1892d6dab92f06
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index a9adccfda4c0..e2a64ae7bcaf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -603,6 +603,9 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev)
u8 frev, crev;
int fw_reserved_fb_size;
+ if (adev->asic_type < CHIP_NAVI10)
+ return 0;
+
index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
firmwareinfo);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Chawking.zhang%40amd.com%7C3e694422d2454046603e08d809596b07%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637269626942920124&sdata=n7NDuLsmSx66FSf8OXd4rpq%2FLXNmTEAo%2BiWAuqSRbC0%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
2020-06-05 14:10 ` Zhang, Hawking
@ 2020-06-05 14:13 ` Zhang, Hawking
2020-06-05 14:38 ` Gao, Likun
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Hawking @ 2020-06-05 14:13 UTC (permalink / raw)
To: Gao, Likun, amd-gfx; +Cc: Xu, Feifei
[AMD Public Use]
It looks more reasonable to me to move the AISC type check to the following. We usually don't add any ASIC type check in atomfirmware interfaces.
adev->discovery_tmr_size =
amdgpu_atomfirmware_get_fw_reserved_fb_size(adev);
Regards,
Hawking
-----Original Message-----
From: Zhang, Hawking <Hawking.Zhang@amd.com>
Sent: Friday, June 5, 2020 22:10
To: Zhang, Hawking <Hawking.Zhang@amd.com>; Gao, Likun <Likun.Gao@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Xu, Feifei <Feifei.Xu@amd.com>
Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
[AMD Public Use]
Wait, I see the risk. the amdgpu_ttm_init is general one even the prior Vega10 ASIC will invoke it, and they don't have atomfirmware support.
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Hawking
Sent: Friday, June 5, 2020 22:05
To: Gao, Likun <Likun.Gao@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Xu, Feifei <Feifei.Xu@amd.com>
Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
[AMD Public Use]
Does it mean there is legacy VBIOS that even doesn't have firmwareinfo table and introduce crash?
I think we expect the atomfirmware interface return 0 for ASICs prior to Sienna Cichlid
Regards,
Hawking
-----Original Message-----
From: Gao, Likun <Likun.Gao@amd.com>
Sent: Friday, June 5, 2020 21:04
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Gao, Likun <Likun.Gao@amd.com>
Subject: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
From: Likun Gao <Likun.Gao@amd.com>
Skip for reserved fb size query for the ASIC older than navi10, as those asic do not need for TMR region reserve and may get an invalid value.
Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Change-Id: Idbc57805b8070f27ba6c3cf22f1892d6dab92f06
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index a9adccfda4c0..e2a64ae7bcaf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -603,6 +603,9 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev)
u8 frev, crev;
int fw_reserved_fb_size;
+ if (adev->asic_type < CHIP_NAVI10)
+ return 0;
+
index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
firmwareinfo);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Chawking.zhang%40amd.com%7C3e694422d2454046603e08d809596b07%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637269626942920124&sdata=n7NDuLsmSx66FSf8OXd4rpq%2FLXNmTEAo%2BiWAuqSRbC0%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
2020-06-05 14:13 ` Zhang, Hawking
@ 2020-06-05 14:38 ` Gao, Likun
0 siblings, 0 replies; 5+ messages in thread
From: Gao, Likun @ 2020-06-05 14:38 UTC (permalink / raw)
To: Zhang, Hawking, amd-gfx; +Cc: Xu, Feifei
[AMD Public Use]
Sorry, please skip for that fix, on the newest code, system will check whether ASIC is newer that navi10 first and only if it was newer than navi10, it will reserve memory for TMR.
So, the issue will not appear on the newest code struct.
Regards,
Likun
-----Original Message-----
From: Zhang, Hawking <Hawking.Zhang@amd.com>
Sent: Friday, June 5, 2020 10:14 PM
To: Gao, Likun <Likun.Gao@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Xu, Feifei <Feifei.Xu@amd.com>
Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
[AMD Public Use]
It looks more reasonable to me to move the AISC type check to the following. We usually don't add any ASIC type check in atomfirmware interfaces.
adev->discovery_tmr_size =
amdgpu_atomfirmware_get_fw_reserved_fb_size(adev);
Regards,
Hawking
-----Original Message-----
From: Zhang, Hawking <Hawking.Zhang@amd.com>
Sent: Friday, June 5, 2020 22:10
To: Zhang, Hawking <Hawking.Zhang@amd.com>; Gao, Likun <Likun.Gao@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Xu, Feifei <Feifei.Xu@amd.com>
Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
[AMD Public Use]
Wait, I see the risk. the amdgpu_ttm_init is general one even the prior Vega10 ASIC will invoke it, and they don't have atomfirmware support.
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Zhang, Hawking
Sent: Friday, June 5, 2020 22:05
To: Gao, Likun <Likun.Gao@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Xu, Feifei <Feifei.Xu@amd.com>
Subject: RE: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
[AMD Public Use]
Does it mean there is legacy VBIOS that even doesn't have firmwareinfo table and introduce crash?
I think we expect the atomfirmware interface return 0 for ASICs prior to Sienna Cichlid
Regards,
Hawking
-----Original Message-----
From: Gao, Likun <Likun.Gao@amd.com>
Sent: Friday, June 5, 2020 21:04
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Xu, Feifei <Feifei.Xu@amd.com>; Gao, Likun <Likun.Gao@amd.com>
Subject: [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic
From: Likun Gao <Likun.Gao@amd.com>
Skip for reserved fb size query for the ASIC older than navi10, as those asic do not need for TMR region reserve and may get an invalid value.
Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Change-Id: Idbc57805b8070f27ba6c3cf22f1892d6dab92f06
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index a9adccfda4c0..e2a64ae7bcaf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -603,6 +603,9 @@ int amdgpu_atomfirmware_get_fw_reserved_fb_size(struct amdgpu_device *adev)
u8 frev, crev;
int fw_reserved_fb_size;
+ if (adev->asic_type < CHIP_NAVI10)
+ return 0;
+
index = get_index_into_master_table(atom_master_list_of_data_tables_v2_1,
firmwareinfo);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Chawking.zhang%40amd.com%7C3e694422d2454046603e08d809596b07%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637269626942920124&sdata=n7NDuLsmSx66FSf8OXd4rpq%2FLXNmTEAo%2BiWAuqSRbC0%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-05 14:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-05 13:04 [PATCH] drm/amdgpu: skip fb size query for navi10 previous asic Likun Gao
2020-06-05 14:04 ` Zhang, Hawking
2020-06-05 14:10 ` Zhang, Hawking
2020-06-05 14:13 ` Zhang, Hawking
2020-06-05 14:38 ` Gao, Likun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.