* [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf
@ 2020-11-23 16:40 shaoyunl
2020-11-23 17:06 ` Zhang, Hawking
2020-11-23 17:12 ` Michel Dänzer
0 siblings, 2 replies; 5+ messages in thread
From: shaoyunl @ 2020-11-23 16:40 UTC (permalink / raw)
To: amd-gfx; +Cc: shaoyunl
This function actually control the vblank on/off. It shouldn't be bypassed for VF. Otherwise all the vblank based feature on VF will not work.
Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
Change-Id: I77c6f57bb0af390b61f0049c12bf425b10d70d91
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index b4d4b76538d2..ffcc64ec6473 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -139,9 +139,6 @@ static void dce_virtual_crtc_dpms(struct drm_crtc *crtc, int mode)
struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
unsigned type;
- if (amdgpu_sriov_vf(adev))
- return;
-
switch (mode) {
case DRM_MODE_DPMS_ON:
amdgpu_crtc->enabled = true;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf
2020-11-23 16:40 [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf shaoyunl
@ 2020-11-23 17:06 ` Zhang, Hawking
2020-11-23 17:12 ` Michel Dänzer
1 sibling, 0 replies; 5+ messages in thread
From: Zhang, Hawking @ 2020-11-23 17:06 UTC (permalink / raw)
To: Liu, Shaoyun, amd-gfx; +Cc: Liu, Shaoyun
[AMD Public Use]
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of shaoyunl
Sent: Tuesday, November 24, 2020 00:41
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun <Shaoyun.Liu@amd.com>
Subject: [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf
This function actually control the vblank on/off. It shouldn't be bypassed for VF. Otherwise all the vblank based feature on VF will not work.
Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
Change-Id: I77c6f57bb0af390b61f0049c12bf425b10d70d91
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index b4d4b76538d2..ffcc64ec6473 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -139,9 +139,6 @@ static void dce_virtual_crtc_dpms(struct drm_crtc *crtc, int mode)
struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
unsigned type;
- if (amdgpu_sriov_vf(adev))
- return;
-
switch (mode) {
case DRM_MODE_DPMS_ON:
amdgpu_crtc->enabled = true;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Chawking.zhang%40amd.com%7Cc1c948ca8d4b478f3c5f08d88fceab9b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637417465126174440%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VlFBXGWwjYN49ufyahlQrS%2Fnm%2FFojwp%2Fp7S8DRpB2kk%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf
2020-11-23 16:40 [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf shaoyunl
2020-11-23 17:06 ` Zhang, Hawking
@ 2020-11-23 17:12 ` Michel Dänzer
1 sibling, 0 replies; 5+ messages in thread
From: Michel Dänzer @ 2020-11-23 17:12 UTC (permalink / raw)
To: shaoyunl; +Cc: amd-gfx
On 2020-11-23 5:40 p.m., shaoyunl wrote:
> This function actually control the vblank on/off. It shouldn't be bypassed for VF. Otherwise all the vblank based feature on VF will not work.
>
> Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
> Change-Id: I77c6f57bb0af390b61f0049c12bf425b10d70d91
> ---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> index b4d4b76538d2..ffcc64ec6473 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> @@ -139,9 +139,6 @@ static void dce_virtual_crtc_dpms(struct drm_crtc *crtc, int mode)
> struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
> unsigned type;
>
> - if (amdgpu_sriov_vf(adev))
> - return;
> -
> switch (mode) {
> case DRM_MODE_DPMS_ON:
> amdgpu_crtc->enabled = true;
>
Subject says DPM, but looks like this is about DPMS?
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf
@ 2020-11-23 17:24 shaoyunl
2020-11-23 17:26 ` Liu, Shaoyun
0 siblings, 1 reply; 5+ messages in thread
From: shaoyunl @ 2020-11-23 17:24 UTC (permalink / raw)
To: amd-gfx; +Cc: shaoyunl
This function actually control the vblank on/off. It shouldn't be bypassed for VF. Otherwise all the vblank based feature on VF will not work.
Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
Change-Id: I77c6f57bb0af390b61f0049c12bf425b10d70d91
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index b4d4b76538d2..ffcc64ec6473 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -139,9 +139,6 @@ static void dce_virtual_crtc_dpms(struct drm_crtc *crtc, int mode)
struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
unsigned type;
- if (amdgpu_sriov_vf(adev))
- return;
-
switch (mode) {
case DRM_MODE_DPMS_ON:
amdgpu_crtc->enabled = true;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf
2020-11-23 17:24 shaoyunl
@ 2020-11-23 17:26 ` Liu, Shaoyun
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Shaoyun @ 2020-11-23 17:26 UTC (permalink / raw)
To: amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Sorry , please ignore this one , I change the subject as suggested and resent the patch
Shaoyun.liu
-----Original Message-----
From: Liu, Shaoyun <Shaoyun.Liu@amd.com>
Sent: Monday, November 23, 2020 12:24 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Shaoyun <Shaoyun.Liu@amd.com>
Subject: [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf
This function actually control the vblank on/off. It shouldn't be bypassed for VF. Otherwise all the vblank based feature on VF will not work.
Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
Change-Id: I77c6f57bb0af390b61f0049c12bf425b10d70d91
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index b4d4b76538d2..ffcc64ec6473 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -139,9 +139,6 @@ static void dce_virtual_crtc_dpms(struct drm_crtc *crtc, int mode)
struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
unsigned type;
- if (amdgpu_sriov_vf(adev))
- return;
-
switch (mode) {
case DRM_MODE_DPMS_ON:
amdgpu_crtc->enabled = true;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-23 17:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 16:40 [PATCH] drm/amdgpu/dce_virtual: Enable DPM for vf shaoyunl
2020-11-23 17:06 ` Zhang, Hawking
2020-11-23 17:12 ` Michel Dänzer
2020-11-23 17:24 shaoyunl
2020-11-23 17:26 ` Liu, Shaoyun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.