All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation
@ 2021-05-31 11:30 ` Lang Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Lang Yu @ 2021-05-31 11:30 UTC (permalink / raw)
  To: amd-gfx, dri-devel
  Cc: Marek Olsak, Christian Koenig, Huang Rui, Alex Deucher, Lang Yu,
	Thomas Hellströ

If a BO's backing store is temporary GTT memory, we should
move it in BO validation.

v2: move the check outside of for loop

Signed-off-by: Lang Yu <Lang.Yu@amd.com>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index c32a37d0a460..1802fc77cfcb 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -938,6 +938,9 @@ static bool ttm_bo_places_compat(const struct ttm_place *places,
 {
 	unsigned i;
 
+	if (mem->placement & TTM_PL_FLAG_TEMPORARY)
+		return false;
+
 	for (i = 0; i < num_placement; i++) {
 		const struct ttm_place *heap = &places[i];
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation
@ 2021-05-31 11:30 ` Lang Yu
  0 siblings, 0 replies; 6+ messages in thread
From: Lang Yu @ 2021-05-31 11:30 UTC (permalink / raw)
  To: amd-gfx, dri-devel
  Cc: Marek Olsak, Christian Koenig, Huang Rui, Alex Deucher, Lang Yu,
	Thomas Hellströ

If a BO's backing store is temporary GTT memory, we should
move it in BO validation.

v2: move the check outside of for loop

Signed-off-by: Lang Yu <Lang.Yu@amd.com>
---
 drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index c32a37d0a460..1802fc77cfcb 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -938,6 +938,9 @@ static bool ttm_bo_places_compat(const struct ttm_place *places,
 {
 	unsigned i;
 
+	if (mem->placement & TTM_PL_FLAG_TEMPORARY)
+		return false;
+
 	for (i = 0; i < num_placement; i++) {
 		const struct ttm_place *heap = &places[i];
 
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation
  2021-05-31 11:30 ` Lang Yu
@ 2021-05-31 11:54   ` Christian König
  -1 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2021-05-31 11:54 UTC (permalink / raw)
  To: Lang Yu, amd-gfx, dri-devel
  Cc: Alex Deucher, Thomas Hellströ, Huang Rui, Marek Olsak

Am 31.05.21 um 13:30 schrieb Lang Yu:
> If a BO's backing store is temporary GTT memory, we should
> move it in BO validation.
>
> v2: move the check outside of for loop
>
> Signed-off-by: Lang Yu <Lang.Yu@amd.com>

In general those patches now have my rb, but let me add some more 
documentation to them to better explain why we do this.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index c32a37d0a460..1802fc77cfcb 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -938,6 +938,9 @@ static bool ttm_bo_places_compat(const struct ttm_place *places,
>   {
>   	unsigned i;
>   
> +	if (mem->placement & TTM_PL_FLAG_TEMPORARY)
> +		return false;
> +
>   	for (i = 0; i < num_placement; i++) {
>   		const struct ttm_place *heap = &places[i];
>   


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation
@ 2021-05-31 11:54   ` Christian König
  0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2021-05-31 11:54 UTC (permalink / raw)
  To: Lang Yu, amd-gfx, dri-devel
  Cc: Alex Deucher, Thomas Hellströ, Huang Rui, Marek Olsak

Am 31.05.21 um 13:30 schrieb Lang Yu:
> If a BO's backing store is temporary GTT memory, we should
> move it in BO validation.
>
> v2: move the check outside of for loop
>
> Signed-off-by: Lang Yu <Lang.Yu@amd.com>

In general those patches now have my rb, but let me add some more 
documentation to them to better explain why we do this.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index c32a37d0a460..1802fc77cfcb 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -938,6 +938,9 @@ static bool ttm_bo_places_compat(const struct ttm_place *places,
>   {
>   	unsigned i;
>   
> +	if (mem->placement & TTM_PL_FLAG_TEMPORARY)
> +		return false;
> +
>   	for (i = 0; i < num_placement; i++) {
>   		const struct ttm_place *heap = &places[i];
>   

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation
  2021-05-31 11:54   ` Christian König
@ 2021-05-31 13:08     ` Yu, Lang
  -1 siblings, 0 replies; 6+ messages in thread
From: Yu, Lang @ 2021-05-31 13:08 UTC (permalink / raw)
  To: Koenig, Christian, amd-gfx, dri-devel
  Cc: Deucher, Alexander, Thomas Hellströ, Huang, Ray, Olsak, Marek

[AMD Official Use Only]



>-----Original Message-----
>From: Koenig, Christian <Christian.Koenig@amd.com>
>Sent: Monday, May 31, 2021 7:55 PM
>To: Yu, Lang <Lang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-
>devel@lists.freedesktop.org
>Cc: Thomas Hellströ <thomas_os@shipmail.org>; Olsak, Marek
><Marek.Olsak@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Deucher,
>Alexander <Alexander.Deucher@amd.com>
>Subject: Re: [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO
>validation
>
>Am 31.05.21 um 13:30 schrieb Lang Yu:
>> If a BO's backing store is temporary GTT memory, we should move it in
>> BO validation.
>>
>> v2: move the check outside of for loop
>>
>> Signed-off-by: Lang Yu <Lang.Yu@amd.com>
>
>In general those patches now have my rb, but let me add some more
>documentation to them to better explain why we do this.
>
[Yu, Lang] 
Thanks for your review and advice. Happy to see that!

Regards,
Lang

>Thanks,
>Christian.
>
>> ---
>>   drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
>> b/drivers/gpu/drm/ttm/ttm_bo.c index c32a37d0a460..1802fc77cfcb 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>> @@ -938,6 +938,9 @@ static bool ttm_bo_places_compat(const struct
>ttm_place *places,
>>   {
>>   	unsigned i;
>>
>> +	if (mem->placement & TTM_PL_FLAG_TEMPORARY)
>> +		return false;
>> +
>>   	for (i = 0; i < num_placement; i++) {
>>   		const struct ttm_place *heap = &places[i];
>>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation
@ 2021-05-31 13:08     ` Yu, Lang
  0 siblings, 0 replies; 6+ messages in thread
From: Yu, Lang @ 2021-05-31 13:08 UTC (permalink / raw)
  To: Koenig, Christian, amd-gfx, dri-devel
  Cc: Deucher, Alexander, Thomas Hellströ, Huang, Ray, Olsak, Marek

[AMD Official Use Only]



>-----Original Message-----
>From: Koenig, Christian <Christian.Koenig@amd.com>
>Sent: Monday, May 31, 2021 7:55 PM
>To: Yu, Lang <Lang.Yu@amd.com>; amd-gfx@lists.freedesktop.org; dri-
>devel@lists.freedesktop.org
>Cc: Thomas Hellströ <thomas_os@shipmail.org>; Olsak, Marek
><Marek.Olsak@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Deucher,
>Alexander <Alexander.Deucher@amd.com>
>Subject: Re: [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO
>validation
>
>Am 31.05.21 um 13:30 schrieb Lang Yu:
>> If a BO's backing store is temporary GTT memory, we should move it in
>> BO validation.
>>
>> v2: move the check outside of for loop
>>
>> Signed-off-by: Lang Yu <Lang.Yu@amd.com>
>
>In general those patches now have my rb, but let me add some more
>documentation to them to better explain why we do this.
>
[Yu, Lang] 
Thanks for your review and advice. Happy to see that!

Regards,
Lang

>Thanks,
>Christian.
>
>> ---
>>   drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c
>> b/drivers/gpu/drm/ttm/ttm_bo.c index c32a37d0a460..1802fc77cfcb 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>> @@ -938,6 +938,9 @@ static bool ttm_bo_places_compat(const struct
>ttm_place *places,
>>   {
>>   	unsigned i;
>>
>> +	if (mem->placement & TTM_PL_FLAG_TEMPORARY)
>> +		return false;
>> +
>>   	for (i = 0; i < num_placement; i++) {
>>   		const struct ttm_place *heap = &places[i];
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-31 13:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 11:30 [PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation Lang Yu
2021-05-31 11:30 ` Lang Yu
2021-05-31 11:54 ` Christian König
2021-05-31 11:54   ` Christian König
2021-05-31 13:08   ` Yu, Lang
2021-05-31 13:08     ` Yu, Lang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.