All of lore.kernel.org
 help / color / mirror / Atom feed
* FW: [meta-networking][master][zeus][PATCH] mosquitto.init
@ 2020-02-10 18:06 Mike Krupicka
  2020-02-10 19:32 ` Khem Raj
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Krupicka @ 2020-02-10 18:06 UTC (permalink / raw)
  To: openembedded-devel

Reposting to tag master branch

Config file specification is missing in start) case. It is present already in restart) case.

Mike
---
.../recipes-connectivity/mosquitto/files/mosquitto.init         | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init b/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init
index 6a0c12760..9d5963c41 100644
--- a/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init
+++ b/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init
@@ -38,7 +38,7 @@ export PATH="${PATH:+$PATH:}@SBINDIR@:@BASE_SBINDIR@"
case "$1" in
     start)
         echo "Starting Mosquitto message broker" "mosquitto"
-        if start-stop-daemon --start --quiet --oknodo --background  --make-pidfile --pidfile ${PIDFILE} --exec ${DAEMON} ; then
+        if start-stop-daemon --start --quiet --oknodo --background --make-pidfile --pidfile ${PIDFILE} --exec ${DAEMON} -- -c @SYSCONFDIR@/mosquitto/mosquitto.conf ; then
             exit 0
         else
             exit 1
--
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: FW: [meta-networking][master][zeus][PATCH] mosquitto.init
  2020-02-10 18:06 FW: [meta-networking][master][zeus][PATCH] mosquitto.init Mike Krupicka
@ 2020-02-10 19:32 ` Khem Raj
  0 siblings, 0 replies; 2+ messages in thread
From: Khem Raj @ 2020-02-10 19:32 UTC (permalink / raw)
  To: Mike Krupicka; +Cc: openembedded-devel

On Mon, Feb 10, 2020 at 10:06 AM Mike Krupicka
<Mike.Krupicka@panduit.com> wrote:
>
> Reposting to tag master branch
>
> Config file specification is missing in start) case. It is present already in restart) case.
>
> Mike

Perhaps the commit message could be improved a nit. I have already
tweaked it locally
but for future reference its good to make it like described here
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

> ---
> .../recipes-connectivity/mosquitto/files/mosquitto.init         | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init b/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init
> index 6a0c12760..9d5963c41 100644
> --- a/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init
> +++ b/meta-networking/recipes-connectivity/mosquitto/files/mosquitto.init
> @@ -38,7 +38,7 @@ export PATH="${PATH:+$PATH:}@SBINDIR@:@BASE_SBINDIR@"
> case "$1" in
>      start)
>          echo "Starting Mosquitto message broker" "mosquitto"
> -        if start-stop-daemon --start --quiet --oknodo --background  --make-pidfile --pidfile ${PIDFILE} --exec ${DAEMON} ; then
> +        if start-stop-daemon --start --quiet --oknodo --background --make-pidfile --pidfile ${PIDFILE} --exec ${DAEMON} -- -c @SYSCONFDIR@/mosquitto/mosquitto.conf ; then
>              exit 0
>          else
>              exit 1
> --
> 2.17.1
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-02-10 19:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 18:06 FW: [meta-networking][master][zeus][PATCH] mosquitto.init Mike Krupicka
2020-02-10 19:32 ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.