* [PATCH] scsi: qla2xxx: fix some memory corruption
@ 2021-01-25 8:44 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2021-01-25 8:44 UTC (permalink / raw)
To: Nilesh Javali
Cc: GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Himanshu Madhani, Saurav Kashyap, linux-scsi,
linux-kernel, kernel-janitors
This was supposed to be "data" instead of "&data". The current code
will corrupt the stack.
Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host, target stats and initiator port")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index e45da05383cd..bee8cf9f8123 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -2667,7 +2667,7 @@ qla2x00_get_tgt_stats(struct bsg_job *bsg_job)
bsg_reply->reply_payload_rcv_len =
sg_copy_from_buffer(bsg_job->reply_payload.sg_list,
- bsg_job->reply_payload.sg_cnt, &data,
+ bsg_job->reply_payload.sg_cnt, data,
sizeof(struct ql_vnd_tgt_stats_resp));
bsg_reply->result = DID_OK;
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] scsi: qla2xxx: fix some memory corruption
@ 2021-01-25 8:44 ` Dan Carpenter
0 siblings, 0 replies; 7+ messages in thread
From: Dan Carpenter @ 2021-01-25 8:44 UTC (permalink / raw)
To: Nilesh Javali
Cc: GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Himanshu Madhani, Saurav Kashyap, linux-scsi,
linux-kernel, kernel-janitors
This was supposed to be "data" instead of "&data". The current code
will corrupt the stack.
Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host, target stats and initiator port")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index e45da05383cd..bee8cf9f8123 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -2667,7 +2667,7 @@ qla2x00_get_tgt_stats(struct bsg_job *bsg_job)
bsg_reply->reply_payload_rcv_len sg_copy_from_buffer(bsg_job->reply_payload.sg_list,
- bsg_job->reply_payload.sg_cnt, &data,
+ bsg_job->reply_payload.sg_cnt, data,
sizeof(struct ql_vnd_tgt_stats_resp));
bsg_reply->result = DID_OK;
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption
2021-01-25 8:44 ` Dan Carpenter
(?)
@ 2021-01-25 9:52 ` Saurav Kashyap
-1 siblings, 0 replies; 7+ messages in thread
From: Saurav Kashyap @ 2021-01-25 9:52 UTC (permalink / raw)
To: Dan Carpenter, Nilesh Javali
Cc: GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Himanshu Madhani, linux-scsi, linux-kernel,
kernel-janitors
Hi Dan,
Thanks for a patch.
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, January 25, 2021 2:14 PM
> To: Nilesh Javali <njavali@marvell.com>
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; James E.J. Bottomley <jejb@linux.ibm.com>;
> Martin K. Petersen <martin.petersen@oracle.com>; Himanshu Madhani
> <himanshu.madhani@oracle.com>; Saurav Kashyap
> <skashyap@marvell.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [EXT] [PATCH] scsi: qla2xxx: fix some memory corruption
>
> External Email
>
> ----------------------------------------------------------------------
> This was supposed to be "data" instead of "&data". The current code
> will corrupt the stack.
>
> Fixes: dbf1f53cfd23 ("scsi: qla2xxx: Implementation to get and manage host,
> target stats and initiator port")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index e45da05383cd..bee8cf9f8123 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -2667,7 +2667,7 @@ qla2x00_get_tgt_stats(struct bsg_job *bsg_job)
>
> bsg_reply->reply_payload_rcv_len =
> sg_copy_from_buffer(bsg_job-
> >reply_payload.sg_list,
> - bsg_job->reply_payload.sg_cnt,
> &data,
> + bsg_job->reply_payload.sg_cnt,
> data,
> sizeof(struct
> ql_vnd_tgt_stats_resp));
>
> bsg_reply->result = DID_OK;
> --
Acked-by: Saurav Kashyap <skashyap@marvell.com>
> 2.29.2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: qla2xxx: fix some memory corruption
2021-01-25 8:44 ` Dan Carpenter
@ 2021-01-27 3:06 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-27 3:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Himanshu Madhani, Saurav Kashyap, linux-scsi,
linux-kernel, kernel-janitors
Dan,
> This was supposed to be "data" instead of "&data". The current code
> will corrupt the stack.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: qla2xxx: fix some memory corruption
@ 2021-01-27 3:06 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-27 3:06 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, Himanshu Madhani, Saurav Kashyap, linux-scsi,
linux-kernel, kernel-janitors
Dan,
> This was supposed to be "data" instead of "&data". The current code
> will corrupt the stack.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: qla2xxx: fix some memory corruption
2021-01-25 8:44 ` Dan Carpenter
@ 2021-01-29 19:01 ` Martin K. Petersen
-1 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-29 19:01 UTC (permalink / raw)
To: Nilesh Javali, Dan Carpenter
Cc: Martin K . Petersen, linux-kernel, linux-scsi, kernel-janitors,
Himanshu Madhani, Saurav Kashyap, GR-QLogic-Storage-Upstream,
James E.J. Bottomley
On Mon, 25 Jan 2021 11:44:02 +0300, Dan Carpenter wrote:
> This was supposed to be "data" instead of "&data". The current code
> will corrupt the stack.
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qla2xxx: fix some memory corruption
https://git.kernel.org/mkp/scsi/c/bc2b4e680231
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] scsi: qla2xxx: fix some memory corruption
@ 2021-01-29 19:01 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2021-01-29 19:01 UTC (permalink / raw)
To: Nilesh Javali, Dan Carpenter
Cc: Martin K . Petersen, linux-kernel, linux-scsi, kernel-janitors,
Himanshu Madhani, Saurav Kashyap, GR-QLogic-Storage-Upstream,
James E.J. Bottomley
On Mon, 25 Jan 2021 11:44:02 +0300, Dan Carpenter wrote:
> This was supposed to be "data" instead of "&data". The current code
> will corrupt the stack.
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qla2xxx: fix some memory corruption
https://git.kernel.org/mkp/scsi/c/bc2b4e680231
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-01-29 19:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 8:44 [PATCH] scsi: qla2xxx: fix some memory corruption Dan Carpenter
2021-01-25 8:44 ` Dan Carpenter
2021-01-25 9:52 ` [EXT] " Saurav Kashyap
2021-01-27 3:06 ` Martin K. Petersen
2021-01-27 3:06 ` Martin K. Petersen
2021-01-29 19:01 ` Martin K. Petersen
2021-01-29 19:01 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.