RE: [PATCH v8 4/9] Bluetooth: btitnel: Add a callback function to retireve data path

From: "K, Kiran" <kiran.k@intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	"Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
	"Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>
Subject: RE: [PATCH v8 4/9] Bluetooth: btitnel: Add a callback function to retireve data path
Date: Tue, 8 Jun 2021 11:56:16 +0000	[thread overview]
Message-ID: <DM8PR11MB5573A02D73AE258B6EE306B8F5379@DM8PR11MB5573.namprd11.prod.outlook.com> (raw)
In-Reply-To: <F2618817-65E3-40E2-AB94-CFB7BE11A9FB@holtmann.org>

Hi Marcel,

> > This callback gets called when audio module queries codecs suppoted on
> > SCO socket. For Intel controllers, data_path is always 1
> >
> > drivers/bluetooth/btintel.c      | 8 ++++++++
> > drivers/bluetooth/btintel.h      | 6 ++++++
> > drivers/bluetooth/btusb.c        | 1 +
> > include/net/bluetooth/hci_core.h | 1 +
> > 4 files changed, 16 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index e3ad19244054..8407e9736c62 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -1300,6 +1300,14 @@ int btintel_read_offload_usecases(struct
> > hci_dev *hdev) } EXPORT_SYMBOL_GPL(btintel_read_offload_usecases);
> >
> > +int btintel_get_data_path_id(struct hci_dev *hdev) {
> > +	if (!test_bit(HCI_QUIRK_HFP_OFFLOAD_CODECS_SUPPORTED,
> &hdev->quirks))
> > +		return -EOPNOTSUPP;
> > +	return 1;
> > +}
> > +EXPORT_SYMBOL_GPL(btintel_get_data_path_id);
> > +
> 
> actually lets not do it this way. Only set the get_data_path_id callback if
> offloading is supported and with that we don’t actually need to quirk either.
> If it is set, we know that we can offload.
> 

Ack.

Thanks,
Kiran