[PATCH] arm: socfpga: vining: Unmount UBIFS and detach UBI in ubi_load script

[PATCH] arm: socfpga: vining: Unmount UBIFS and detach UBI in ubi_load script

[Marek Vasut]

Clean up in ubiload script. Unmount UBIFS from which kernel image was
loaded and detach UBI on which the UBIFS is located, otherwise message
similar to the following is printed just before booting kernel:

Removing MTD device #7 (rootfs) with use count 1
Error when deleting partition "rootfs" (-16)

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Siew Chin Lim <elly.siew.chin.lim@intel.com>
Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Cc: Tien Fong Chee <tien.fong.chee@intel.com>
---
 include/configs/socfpga_vining_fpga.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/configs/socfpga_vining_fpga.h b/include/configs/socfpga_vining_fpga.h
index d9d0a4af5ac..5c0ed07c427 100644
--- a/include/configs/socfpga_vining_fpga.h
+++ b/include/configs/socfpga_vining_fpga.h
@@ -118,7 +118,8 @@
 	"addargs=run addcons addmtd addmisc\0"				\
 	"ubiload="							\
 		"ubi part ${ubimtd} ; ubifsmount ${ubipart} ; "		\
-		"ubifsload ${kernel_addr_r} /boot/${bootfile}\0"	\
+		"ubifsload ${kernel_addr_r} /boot/${bootfile} ; "	\
+		"ubifsumount ; ubi detach\0"				\
 	"netload="							\
 		"tftp ${kernel_addr_r} ${hostname}/${bootfile}\0"	\
 	"miscargs=nohlt panic=1\0"					\
-- 
2.34.1

RE: [PATCH] arm: socfpga: vining: Unmount UBIFS and detach UBI in ubi_load script

[Chee, Tien Fong]

Hi,

> -----Original Message-----
> From: Marek Vasut <marex@denx.de>
> Sent: Tuesday, 21 December, 2021 5:58 AM
> To: u-boot@lists.denx.de
> Cc: trini@konsulko.com; Vasut, Marek <marex@denx.de>; Lim, Elly Siew Chin
> <elly.siew.chin.lim@intel.com>; Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com>; Chee, Tien Fong
> <tien.fong.chee@intel.com>
> Subject: [PATCH] arm: socfpga: vining: Unmount UBIFS and detach UBI in
> ubi_load script
> 
> Clean up in ubiload script. Unmount UBIFS from which kernel image was loaded
> and detach UBI on which the UBIFS is located, otherwise message similar to the
> following is printed just before booting kernel:
> 
> Removing MTD device #7 (rootfs) with use count 1 Error when deleting partition
> "rootfs" (-16)
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Siew Chin Lim <elly.siew.chin.lim@intel.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Tien Fong Chee <tien.fong.chee@intel.com>
> ---
>  include/configs/socfpga_vining_fpga.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/socfpga_vining_fpga.h
> b/include/configs/socfpga_vining_fpga.h
> index d9d0a4af5ac..5c0ed07c427 100644
> --- a/include/configs/socfpga_vining_fpga.h
> +++ b/include/configs/socfpga_vining_fpga.h
> @@ -118,7 +118,8 @@
>  	"addargs=run addcons addmtd addmisc\0"
> 	\
>  	"ubiload="							\
>  		"ubi part ${ubimtd} ; ubifsmount ${ubipart} ; "		\
> -		"ubifsload ${kernel_addr_r} /boot/${bootfile}\0"	\
> +		"ubifsload ${kernel_addr_r} /boot/${bootfile} ; "	\
> +		"ubifsumount ; ubi detach\0"				\
>  	"netload="							\
>  		"tftp ${kernel_addr_r} ${hostname}/${bootfile}\0"	\
>  	"miscargs=nohlt panic=1\0"					\
> --
> 2.34.1

Reviewed-by: Tien Fong Chee  <tien.fong.chee@intel.com>

Regards
Tien Fong