[PATCH] drivers: cache: ncore: Disable snoop filter

[PATCH] drivers: cache: ncore: Disable snoop filter

[dinesh.maniyam]

From: Dinesh Maniyam <dinesh.maniyam@intel.com>

There is hardware bug in NCORE CCU IP and it is causing an issue in the
coherent directory tracking of outstanding cache lines.
The workaround is disabling snoop filter.

Signed-off-by: Dinesh Maniyam <dinesh.maniyam@intel.com>
---
 drivers/cache/cache-ncore.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/cache/cache-ncore.c b/drivers/cache/cache-ncore.c
index 3beff780de..117d2b91ab 100644
--- a/drivers/cache/cache-ncore.c
+++ b/drivers/cache/cache-ncore.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Copyright (C) 2019 Intel Corporation <www.intel.com>
+ * Copyright (C) 2019-2022 Intel Corporation <www.intel.com>
  *
  */
 #include <dm.h>
@@ -81,8 +81,8 @@ static void ncore_ccu_init_dirs(void __iomem *base)
 				hang();
 			}
 
-			/* Enable snoop filter, a bit per snoop filter */
-			setbits_le32((ulong)CCU_DIR_REG_ADDR(base, DIRUSFER, i),
+			/* Disable snoop filter, a bit per snoop filter */
+			clrbits_le32((ulong)CCU_DIR_REG_ADDR(base, DIRUSFER, i),
 				     BIT(f));
 		}
 	}
-- 
2.25.1

RE: [PATCH] drivers: cache: ncore: Disable snoop filter

[Chee, Tien Fong]

> -----Original Message-----
> From: Maniyam, Dinesh <dinesh.maniyam@intel.com>
> Sent: Wednesday, 1 June, 2022 3:57 PM
> To: u-boot@lists.denx.de
> Cc: Vasut, Marek <marex@denx.de>; Simon Goldschmidt
> <simon.k.r.goldschmidt@gmail.com>; Chee, Tien Fong
> <tien.fong.chee@intel.com>; Hea, Kok Kiang <kok.kiang.hea@intel.com>;
> Gan, Yau Wai <yau.wai.gan@intel.com>; Kho, Sin Hui
> <sin.hui.kho@intel.com>; Lokanathan, Raaj <raaj.lokanathan@intel.com>;
> Maniyam, Dinesh <dinesh.maniyam@intel.com>
> Subject: [PATCH] drivers: cache: ncore: Disable snoop filter
> 
> From: Dinesh Maniyam <dinesh.maniyam@intel.com>
> 
> There is hardware bug in NCORE CCU IP and it is causing an issue in the
> coherent directory tracking of outstanding cache lines.
> The workaround is disabling snoop filter.
> 
> Signed-off-by: Dinesh Maniyam <dinesh.maniyam@intel.com>
> ---
>  drivers/cache/cache-ncore.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cache/cache-ncore.c b/drivers/cache/cache-ncore.c index
> 3beff780de..117d2b91ab 100644
> --- a/drivers/cache/cache-ncore.c
> +++ b/drivers/cache/cache-ncore.c
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Copyright (C) 2019 Intel Corporation <www.intel.com>
> + * Copyright (C) 2019-2022 Intel Corporation <www.intel.com>
>   *
>   */
>  #include <dm.h>
> @@ -81,8 +81,8 @@ static void ncore_ccu_init_dirs(void __iomem *base)
>  				hang();
>  			}
> 
> -			/* Enable snoop filter, a bit per snoop filter */
> -			setbits_le32((ulong)CCU_DIR_REG_ADDR(base,
> DIRUSFER, i),
> +			/* Disable snoop filter, a bit per snoop filter */
> +			clrbits_le32((ulong)CCU_DIR_REG_ADDR(base,
> DIRUSFER, i),
>  				     BIT(f));
>  		}
>  	}
> --
> 2.25.1

Reviewed-by: Tien Fong Chee <tien.fong.chee@intel.com>

Regards
Tien Fong