All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Fix regression in test_plane_position_with_output
@ 2021-09-16 14:23 Vidya Srinivas
  2021-09-16 18:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 16+ messages in thread
From: Vidya Srinivas @ 2021-09-16 14:23 UTC (permalink / raw)
  To: igt-dev; +Cc: Bhanuprakash.Modem, markyacoub, Vidya Srinivas

Starting commit 4d4a76729b328b65122 "Start continuous CRC capture after commit"
few variants of Intel TGL devices are failing upon CRC mismatch.
Patch switches to older way of obtaining CRC and includes checking of
i915 as patch causing regression is a fix for AMD devices.

Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_plane_multiple.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index 45cabb500774..e6e035dca59b 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -331,18 +331,23 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		 igt_output_name(output), kmstest_pipe_name(pipe), c,
 		 info, opt.seed);
 
+	if (is_i915_device(data->drm_fd))
+		igt_pipe_crc_start(data->pipe_crc);
+
 	i = 0;
 	while (i < iterations || loop_forever) {
 		/* randomize planes and set up the holes */
 		prepare_planes(data, pipe, &blue, tiling, c, output);
 
 		igt_display_commit2(&data->display, COMMIT_ATOMIC);
-		if (!crc_enabled) {
+		if (!crc_enabled && !is_i915_device(data->drm_fd)) {
 			igt_pipe_crc_start(data->pipe_crc);
 			crc_enabled = 1;
 		}
 
 		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &crc);
+		igt_assert_crc_equal(&data->ref_crc, &crc);
+		igt_pipe_crc_stop(data->pipe_crc);
 
 		for_each_plane_on_pipe(&data->display, pipe, plane)
 			igt_plane_set_fb(plane, NULL);
@@ -352,8 +357,6 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
 		for (int x = 0; x < c; x++)
 			igt_remove_fb(data->drm_fd, &data->fb[x]);
 
-		igt_assert_crc_equal(&data->ref_crc, &crc);
-
 		i++;
 	}
 
-- 
2.33.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-10-13 17:56 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 14:23 [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Fix regression in test_plane_position_with_output Vidya Srinivas
2021-09-16 18:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-16 20:37 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-24 10:45 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Fix regression test_plane_position_with_output Vidya Srinivas
2021-09-24 11:04   ` Srinivas, Vidya
2021-10-08  6:18   ` Karthik B S
2021-10-08  6:23     ` Srinivas, Vidya
2021-09-24 11:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Fix regression in test_plane_position_with_output (rev2) Patchwork
2021-09-24 13:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-10-13  7:50 ` [igt-dev] [i-g-t v3] tests/kms_plane_multiple: Fix regression test_plane_position_with_output Bhanuprakash Modem
2021-10-13  8:49 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_multiple: Fix regression in test_plane_position_with_output (rev3) Patchwork
2021-10-13 10:28 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-13 10:55   ` Modem, Bhanuprakash
2021-10-13 10:56   ` Modem, Bhanuprakash
2021-10-13 17:56     ` Vudum, Lakshminarayana
2021-10-13 15:26 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.