Re: [dpdk-dev] [PATCH v3 1/3] ethdev: support PPP and L2TPV2 procotol

[Ori Kam <orika@nvidia.com>]

HI Jie,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, October 15, 2021 2:10 PM
> Subject: Re: [PATCH v3 1/3] ethdev: support PPP and L2TPV2 procotol
> 
> On 10/15/2021 10:58 AM, Jie Wang wrote:
> > +/**
> > + * @warning
> > + * @b EXPERIMENTAL: this structure may change without prior notice
> > + * RTE_FLOW_ITEM_TYPE_PPP
> > + *
> > + * Matches PPP Header
> > + */
> > +struct rte_flow_item_ppp {
> > +	uint8_t addr; /**< ppp address(8) */
> > +	uint8_t ctrl; /**< ppp control(8) */
> > +	rte_be16_t proto_id; /**< ppp protocol id(16) */ };
> 
> Hi Jie,
> 
> Can't we do same thing for ppp, have the protocol header in the lib/net and use it within the
> 'rte_flow_item_ppp'?
+1
Ori