* [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
@ 2022-08-24 6:40 Prike Liang
2022-08-24 12:40 ` Liang, Prike
0 siblings, 1 reply; 5+ messages in thread
From: Prike Liang @ 2022-08-24 6:40 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Yifan1.Zhang, Prike Liang, ray.huang
Correct the isa version for handling KFD test.
Fixes: 7c4f4f197e0c ("drm/amdkfd: Add GC 10.3.6 and 10.3.7 KFD definitions")
Signed-off-by: Prike Liang <Prike.Liang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index fdad1415f8bd..5ebbeac61379 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -388,7 +388,7 @@ struct kfd_dev *kgd2kfd_probe(struct amdgpu_device *adev, bool vf)
f2g = &gfx_v10_3_kfd2kgd;
break;
case IP_VERSION(10, 3, 7):
- gfx_target_version = 100307;
+ gfx_target_version = 100306;
if (!vf)
f2g = &gfx_v10_3_kfd2kgd;
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
2022-08-24 6:40 [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7 Prike Liang
@ 2022-08-24 12:40 ` Liang, Prike
2022-08-25 0:15 ` Liu, Aaron
0 siblings, 1 reply; 5+ messages in thread
From: Liang, Prike @ 2022-08-24 12:40 UTC (permalink / raw)
To: Liang, Prike, amd-gfx
Cc: Deucher, Alexander, Zhang, Yifan, Huang, Ray, Liu, Aaron,
Limonciello, Mario
[Public]
Add more for the review and awareness.
Regards,
--Prike
-----Original Message-----
From: Prike Liang <Prike.Liang@amd.com>
Sent: Wednesday, August 24, 2022 2:41 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Liang, Prike <Prike.Liang@amd.com>
Subject: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
Correct the isa version for handling KFD test.
Fixes: 7c4f4f197e0c ("drm/amdkfd: Add GC 10.3.6 and 10.3.7 KFD definitions")
Signed-off-by: Prike Liang <Prike.Liang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index fdad1415f8bd..5ebbeac61379 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -388,7 +388,7 @@ struct kfd_dev *kgd2kfd_probe(struct amdgpu_device *adev, bool vf)
f2g = &gfx_v10_3_kfd2kgd;
break;
case IP_VERSION(10, 3, 7):
- gfx_target_version = 100307;
+ gfx_target_version = 100306;
if (!vf)
f2g = &gfx_v10_3_kfd2kgd;
break;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
2022-08-24 12:40 ` Liang, Prike
@ 2022-08-25 0:15 ` Liu, Aaron
2022-08-25 0:27 ` Liu, Aaron
0 siblings, 1 reply; 5+ messages in thread
From: Liu, Aaron @ 2022-08-25 0:15 UTC (permalink / raw)
To: Liang, Prike, amd-gfx
Cc: Deucher, Alexander, Zhang, Yifan, Huang, Ray, Limonciello, Mario
[Public]
Reviewed-by: Aaron Liu <aaron.liu@amd.com>
> -----Original Message-----
> From: Liang, Prike <Prike.Liang@amd.com>
> Sent: Wednesday, August 24, 2022 8:40 PM
> To: Liang, Prike <Prike.Liang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Liu, Aaron
> <Aaron.Liu@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
>
> [Public]
>
> Add more for the review and awareness.
>
> Regards,
> --Prike
>
> -----Original Message-----
> From: Prike Liang <Prike.Liang@amd.com>
> Sent: Wednesday, August 24, 2022 2:41 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Liang,
> Prike <Prike.Liang@amd.com>
> Subject: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
>
> Correct the isa version for handling KFD test.
>
> Fixes: 7c4f4f197e0c ("drm/amdkfd: Add GC 10.3.6 and 10.3.7 KFD
> definitions")
> Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index fdad1415f8bd..5ebbeac61379 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -388,7 +388,7 @@ struct kfd_dev *kgd2kfd_probe(struct
> amdgpu_device *adev, bool vf)
> f2g = &gfx_v10_3_kfd2kgd;
> break;
> case IP_VERSION(10, 3, 7):
> - gfx_target_version = 100307;
> + gfx_target_version = 100306;
> if (!vf)
> f2g = &gfx_v10_3_kfd2kgd;
> break;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
2022-08-25 0:15 ` Liu, Aaron
@ 2022-08-25 0:27 ` Liu, Aaron
2022-08-25 1:25 ` Liang, Prike
0 siblings, 1 reply; 5+ messages in thread
From: Liu, Aaron @ 2022-08-25 0:27 UTC (permalink / raw)
To: Liang, Prike, amd-gfx
Cc: Deucher, Alexander, Zhang, Yifan, Huang, Ray, Limonciello, Mario
[Public]
Because GC_IP_VERSION 10.3.6&10.3.7 all use 1036 ISA version, one nit-pick as below. It looks better.
case IP_VERSION(10, 3, 6):
case IP_VERSION(10, 3, 7):
gfx_target_version = 100306;
if (!vf)
f2g = &gfx_v10_3_kfd2kgd;
break;
> -----Original Message-----
> From: Liu, Aaron
> Sent: Thursday, August 25, 2022 8:15 AM
> To: Liang, Prike <Prike.Liang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>;
> Limonciello, Mario <Mario.Limonciello@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
>
> [Public]
>
> Reviewed-by: Aaron Liu <aaron.liu@amd.com>
>
> > -----Original Message-----
> > From: Liang, Prike <Prike.Liang@amd.com>
> > Sent: Wednesday, August 24, 2022 8:40 PM
> > To: Liang, Prike <Prike.Liang@amd.com>; amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> > <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Liu,
> Aaron
> > <Aaron.Liu@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>
> > Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
> >
> > [Public]
> >
> > Add more for the review and awareness.
> >
> > Regards,
> > --Prike
> >
> > -----Original Message-----
> > From: Prike Liang <Prike.Liang@amd.com>
> > Sent: Wednesday, August 24, 2022 2:41 PM
> > To: amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> > <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Liang,
> Prike
> > <Prike.Liang@amd.com>
> > Subject: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
> >
> > Correct the isa version for handling KFD test.
> >
> > Fixes: 7c4f4f197e0c ("drm/amdkfd: Add GC 10.3.6 and 10.3.7 KFD
> > definitions")
> > Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > index fdad1415f8bd..5ebbeac61379 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > @@ -388,7 +388,7 @@ struct kfd_dev *kgd2kfd_probe(struct
> amdgpu_device
> > *adev, bool vf)
> > f2g = &gfx_v10_3_kfd2kgd;
> > break;
> > case IP_VERSION(10, 3, 7):
> > - gfx_target_version = 100307;
> > + gfx_target_version = 100306;
> > if (!vf)
> > f2g = &gfx_v10_3_kfd2kgd;
> > break;
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
2022-08-25 0:27 ` Liu, Aaron
@ 2022-08-25 1:25 ` Liang, Prike
0 siblings, 0 replies; 5+ messages in thread
From: Liang, Prike @ 2022-08-25 1:25 UTC (permalink / raw)
To: Liu, Aaron, amd-gfx
Cc: Deucher, Alexander, Zhang, Yifan, Huang, Ray, Limonciello, Mario
Thanks, it makes sense and will refine the code before push.
Regards,
--Prike
-----Original Message-----
From: Liu, Aaron <Aaron.Liu@amd.com>
Sent: Thursday, August 25, 2022 8:28 AM
To: Liang, Prike <Prike.Liang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>
Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
[Public]
Because GC_IP_VERSION 10.3.6&10.3.7 all use 1036 ISA version, one nit-pick as below. It looks better.
case IP_VERSION(10, 3, 6):
case IP_VERSION(10, 3, 7):
gfx_target_version = 100306;
if (!vf)
f2g = &gfx_v10_3_kfd2kgd;
break;
> -----Original Message-----
> From: Liu, Aaron
> Sent: Thursday, August 25, 2022 8:15 AM
> To: Liang, Prike <Prike.Liang@amd.com>; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Limonciello,
> Mario <Mario.Limonciello@amd.com>
> Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
>
> [Public]
>
> Reviewed-by: Aaron Liu <aaron.liu@amd.com>
>
> > -----Original Message-----
> > From: Liang, Prike <Prike.Liang@amd.com>
> > Sent: Wednesday, August 24, 2022 8:40 PM
> > To: Liang, Prike <Prike.Liang@amd.com>;
> > amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> > <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Liu,
> Aaron
> > <Aaron.Liu@amd.com>; Limonciello, Mario <Mario.Limonciello@amd.com>
> > Subject: RE: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
> >
> > [Public]
> >
> > Add more for the review and awareness.
> >
> > Regards,
> > --Prike
> >
> > -----Original Message-----
> > From: Prike Liang <Prike.Liang@amd.com>
> > Sent: Wednesday, August 24, 2022 2:41 PM
> > To: amd-gfx@lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> > <Ray.Huang@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>; Liang,
> Prike
> > <Prike.Liang@amd.com>
> > Subject: [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7
> >
> > Correct the isa version for handling KFD test.
> >
> > Fixes: 7c4f4f197e0c ("drm/amdkfd: Add GC 10.3.6 and 10.3.7 KFD
> > definitions")
> > Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > index fdad1415f8bd..5ebbeac61379 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> > @@ -388,7 +388,7 @@ struct kfd_dev *kgd2kfd_probe(struct
> amdgpu_device
> > *adev, bool vf)
> > f2g = &gfx_v10_3_kfd2kgd;
> > break;
> > case IP_VERSION(10, 3, 7):
> > - gfx_target_version = 100307;
> > + gfx_target_version = 100306;
> > if (!vf)
> > f2g = &gfx_v10_3_kfd2kgd;
> > break;
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-25 7:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-24 6:40 [PATCH] drm/amdkfd: Fix isa version for the GC 10.3.7 Prike Liang
2022-08-24 12:40 ` Liang, Prike
2022-08-25 0:15 ` Liu, Aaron
2022-08-25 0:27 ` Liu, Aaron
2022-08-25 1:25 ` Liang, Prike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.