From: Peng Fan <peng.fan@nxp.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "l.stach@pengutronix.de" <l.stach@pengutronix.de> Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>, "marex@denx.de" <marex@denx.de>, "paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>, "aford173@gmail.com" <aford173@gmail.com>, "Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>, "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Aisheng Dong <aisheng.dong@nxp.com> Subject: RE: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl Date: Thu, 21 Jul 2022 10:38:50 +0000 [thread overview] Message-ID: <DU0PR04MB94172A78F8E9E74FC842F22B88919@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw) In-Reply-To: <9c1735bf-3f29-4bf1-f7cf-f9e211c505ac@linaro.org> > Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl > > On 19/07/2022 11:58, Peng Fan wrote: > >>> + interconnects: > >>> + items: > >>> + - description: G1 decoder interconnect > >>> + - description: G2 decoder interconnect > >>> + - description: VC8000E encoder interconnect > >>> + > >>> + interconnect-names: > >>> + items: > >>> + - const: g1 > >>> + - const: g2 > >>> + - const: vc8000e > >> > >> Include interconnects+names in list of all properties and disallow > >> them for other variants. > > > > I not understand well about > > " Include interconnects+names in list of all properties ", could you > > please explain a bit more? > > > > And there is already an "if" to check whether the compatible contains > > " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect valid for > > i.MX8MP, so it is not valid to other variants. > > Defining properties in some if: clause is not really readable and > maintainable. The properties should be defined in top-level properties:. Maybe I should also include i.MX8MM interconnect and make it a separate patch, then i.MX8MP/i.MX8MM just use their own names just like other properities. In final, as below: Tow patch: 1. Add interconnect property for i.MX8MM VPU BLK CTRL 2. Add i.MX8MP VPU BLK CTRL dt bindings In top-level: + interconnects: + maxItems: 3 + interconnect-names: + maxItems: 3 For i.MX8MM + interconnects: + items: + - description: G1 decoder interconnect + - description: G2 decoder interconnect + - description: H1 encoder interconnect + + interconnect-names: + items: + - const: g1 + - const: g2 + - const: h1 For i.MX8MP: + interconnects: + items: + - description: G1 decoder interconnect + - description: G2 decoder interconnect + - description: VC8000E encoder interconnect + + interconnect-names: + items: + - const: g1 + - const: g2 + - const: vc8000e How do you think? Thanks, Peng. > > > Best regards, > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "l.stach@pengutronix.de" <l.stach@pengutronix.de> Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>, "marex@denx.de" <marex@denx.de>, "paul.elder@ideasonboard.com" <paul.elder@ideasonboard.com>, "aford173@gmail.com" <aford173@gmail.com>, "Markus.Niebel@ew.tq-group.com" <Markus.Niebel@ew.tq-group.com>, "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Aisheng Dong <aisheng.dong@nxp.com> Subject: RE: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl Date: Thu, 21 Jul 2022 10:38:50 +0000 [thread overview] Message-ID: <DU0PR04MB94172A78F8E9E74FC842F22B88919@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw) In-Reply-To: <9c1735bf-3f29-4bf1-f7cf-f9e211c505ac@linaro.org> > Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl > > On 19/07/2022 11:58, Peng Fan wrote: > >>> + interconnects: > >>> + items: > >>> + - description: G1 decoder interconnect > >>> + - description: G2 decoder interconnect > >>> + - description: VC8000E encoder interconnect > >>> + > >>> + interconnect-names: > >>> + items: > >>> + - const: g1 > >>> + - const: g2 > >>> + - const: vc8000e > >> > >> Include interconnects+names in list of all properties and disallow > >> them for other variants. > > > > I not understand well about > > " Include interconnects+names in list of all properties ", could you > > please explain a bit more? > > > > And there is already an "if" to check whether the compatible contains > > " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect valid for > > i.MX8MP, so it is not valid to other variants. > > Defining properties in some if: clause is not really readable and > maintainable. The properties should be defined in top-level properties:. Maybe I should also include i.MX8MM interconnect and make it a separate patch, then i.MX8MP/i.MX8MM just use their own names just like other properities. In final, as below: Tow patch: 1. Add interconnect property for i.MX8MM VPU BLK CTRL 2. Add i.MX8MP VPU BLK CTRL dt bindings In top-level: + interconnects: + maxItems: 3 + interconnect-names: + maxItems: 3 For i.MX8MM + interconnects: + items: + - description: G1 decoder interconnect + - description: G2 decoder interconnect + - description: H1 encoder interconnect + + interconnect-names: + items: + - const: g1 + - const: g2 + - const: h1 For i.MX8MP: + interconnects: + items: + - description: G1 decoder interconnect + - description: G2 decoder interconnect + - description: VC8000E encoder interconnect + + interconnect-names: + items: + - const: g1 + - const: g2 + - const: vc8000e How do you think? Thanks, Peng. > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-21 10:39 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-19 5:50 [PATCH V3 0/7] imx: add i.MX8MP hdmi blk ctrl hdcp/hrv and vpu blk ctrl Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS) 2022-07-19 5:50 ` [PATCH V3 1/7] dt-bindings: power: imx8mp-power: add HDMI HDCP/HRV Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS) 2022-07-19 5:50 ` [PATCH V3 2/7] dt-bindings: soc: imx: drop minItems for i.MX8MM vpu blk ctrl Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS) 2022-07-19 9:52 ` Krzysztof Kozlowski 2022-07-19 9:52 ` Krzysztof Kozlowski 2022-07-19 5:50 ` [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP " Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS) 2022-07-19 9:53 ` Krzysztof Kozlowski 2022-07-19 9:53 ` Krzysztof Kozlowski 2022-07-19 9:58 ` Peng Fan 2022-07-19 9:58 ` Peng Fan 2022-07-19 19:08 ` Krzysztof Kozlowski 2022-07-19 19:08 ` Krzysztof Kozlowski 2022-07-21 10:38 ` Peng Fan [this message] 2022-07-21 10:38 ` Peng Fan 2022-07-21 13:49 ` Krzysztof Kozlowski 2022-07-21 13:49 ` Krzysztof Kozlowski 2022-07-19 5:50 ` [PATCH V3 4/7] soc: imx: add i.MX8MP HDMI blk ctrl HDCP/HRV Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS) 2022-07-19 15:34 ` kernel test robot 2022-07-19 15:34 ` kernel test robot 2022-07-20 0:51 ` Peng Fan 2022-07-20 0:51 ` Peng Fan 2022-07-20 0:51 ` Peng Fan 2022-07-20 8:27 ` kernel test robot 2022-07-20 8:27 ` kernel test robot 2022-07-19 5:50 ` [PATCH V3 5/7] soc: imx: imx8m-blk-ctrl: add i.MX8MP VPU blk ctrl Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS) 2022-07-20 9:58 ` kernel test robot 2022-07-20 9:58 ` kernel test robot 2022-07-19 5:50 ` [PATCH V3 6/7] arm64: dts: imx8mp: add vpu pgc nodes Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS) 2022-07-19 5:50 ` [PATCH V3 7/7] arm64: dts: imx8mp: add VPU blk ctrl node Peng Fan (OSS) 2022-07-19 5:50 ` Peng Fan (OSS)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DU0PR04MB94172A78F8E9E74FC842F22B88919@DU0PR04MB9417.eurprd04.prod.outlook.com \ --to=peng.fan@nxp.com \ --cc=Markus.Niebel@ew.tq-group.com \ --cc=aford173@gmail.com \ --cc=aisheng.dong@nxp.com \ --cc=alexander.stein@ew.tq-group.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=l.stach@pengutronix.de \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=marex@denx.de \ --cc=paul.elder@ideasonboard.com \ --cc=peng.fan@oss.nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.