From: Peng Fan <peng.fan@nxp.com>
To: Michal Orzel <michal.orzel@arm.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"julien@xen.org" <julien@xen.org>,
"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
"bertrand.marquis@arm.com" <bertrand.marquis@arm.com>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"wl@xen.org" <wl@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"van.freenix@gmail.com" <van.freenix@gmail.com>
Subject: RE: [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support
Date: Fri, 8 Apr 2022 13:29:20 +0000 [thread overview]
Message-ID: <DU0PR04MB9417803BB8B28A9A1DDCB29488E99@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <363333de-0ec9-dff7-09c3-426530657a43@arm.com>
Hi Michal,
> -----Original Message-----
> From: Michal Orzel [mailto:michal.orzel@arm.com]
> Sent: 2022年4月8日 18:23
> To: Peng Fan (OSS) <peng.fan@oss.nxp.com>; sstabellini@kernel.org;
> julien@xen.org; Volodymyr_Babchuk@epam.com;
> bertrand.marquis@arm.com
> Cc: andrew.cooper3@citrix.com; george.dunlap@citrix.com;
> jbeulich@suse.com; wl@xen.org; xen-devel@lists.xenproject.org;
> van.freenix@gmail.com; Peng Fan <peng.fan@nxp.com>
> Subject: Re: [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support
>
> Hi Peng,
>
> On 07.04.2022 04:44, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > xen/arch/arm/Kconfig.debug | 14 +++++++
> > xen/arch/arm/arm64/debug-imx-lpuart.inc | 52
> +++++++++++++++++++++++++
> > xen/arch/arm/include/asm/imx-lpuart.h | 22 +++++------
> > 3 files changed, 77 insertions(+), 11 deletions(-) create mode
> > 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc
> >
> > diff --git a/xen/arch/arm/include/asm/imx-lpuart.h
> > b/xen/arch/arm/include/asm/imx-lpuart.h
> > index 111640edb4..26e2cf0249 100644
> > --- a/xen/arch/arm/include/asm/imx-lpuart.h
> > +++ b/xen/arch/arm/include/asm/imx-lpuart.h
> > @@ -30,10 +30,10 @@
> > #define UARTFIFO (0x28)
> > #define UARTWATER (0x2c)
> >
> > -#define UARTSTAT_TDRE BIT(23)
> > -#define UARTSTAT_TC BIT(22)
> > -#define UARTSTAT_RDRF BIT(21)
> > -#define UARTSTAT_OR BIT(19)
> > +#define UARTSTAT_TDRE BIT(23, UL)
> > +#define UARTSTAT_TC BIT(22, UL)
> > +#define UARTSTAT_RDRF BIT(21, UL)
> > +#define UARTSTAT_OR BIT(19, UL)
> >
> > #define UARTBAUD_OSR_SHIFT (24)
> > #define UARTBAUD_OSR_MASK (0x1f)
> > @@ -42,13 +42,13 @@
> > #define UARTBAUD_TDMAE (0x00800000)
> > #define UARTBAUD_RDMAE (0x00200000)
> >
> > -#define UARTCTRL_TIE BIT(23)
> > -#define UARTCTRL_TCIE BIT(22)
> > -#define UARTCTRL_RIE BIT(21)
> > -#define UARTCTRL_ILIE BIT(20)
> > -#define UARTCTRL_TE BIT(19)
> > -#define UARTCTRL_RE BIT(18)
> > -#define UARTCTRL_M BIT(4)
> > +#define UARTCTRL_TIE BIT(23, UL)
> > +#define UARTCTRL_TCIE BIT(22, UL)
> > +#define UARTCTRL_RIE BIT(21, UL)
> > +#define UARTCTRL_ILIE BIT(20, UL)
> > +#define UARTCTRL_TE BIT(19, UL)
> > +#define UARTCTRL_RE BIT(18, UL)
> > +#define UARTCTRL_M BIT(4, UL)
> >
> > #define UARTWATER_RXCNT_OFF 24
> >
>
> I find it a bit strange that you fix the header file in the patch 2/2 while patch
> 1/2 introduces it. Could you do these fixes in the patch where you create this
> file?
Oops. I missed to merge that BIT fix into patch 1. Just send out V4.
Thanks,
Peng.
>
> Cheers,
> Michal
prev parent reply other threads:[~2022-04-08 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 2:44 [PATCH V3 0/2] xen/arm: add i.MX lpuart and i.MX8QM initial support Peng Fan (OSS)
2022-04-07 2:44 ` [PATCH V3 1/2] xen/arm: Add i.MX lpuart driver Peng Fan (OSS)
2022-04-08 11:04 ` Michal Orzel
2022-04-07 2:44 ` [PATCH V3 2/2] xen/arm: Add i.MX lpuart early printk support Peng Fan (OSS)
2022-04-08 10:22 ` Michal Orzel
2022-04-08 13:29 ` Peng Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0PR04MB9417803BB8B28A9A1DDCB29488E99@DU0PR04MB9417.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@arm.com \
--cc=peng.fan@oss.nxp.com \
--cc=sstabellini@kernel.org \
--cc=van.freenix@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.