All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Clark Wang <xiaoning.wang@nxp.com>
Subject: RE: [PATCH 0/6] i2c-imx-lpi2c: add IPG clock
Date: Mon, 15 Aug 2022 00:52:58 +0000	[thread overview]
Message-ID: <DU0PR04MB9417D62230578AC8CA4234F288689@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <f1add9c7-fc2e-a600-49a6-a6579f17db1b@linaro.org>

Hi Krzysztof,

> Subject: Re: [PATCH 0/6] i2c-imx-lpi2c: add IPG clock
> 
> On 12/08/2022 07:34, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The i.MX LPI2C needs PER and IPG clock, not just PER or IPG clock.
> > This patch is to enable both PER and IPG clock for imx-i2c-lpi2c.
> 
> This patchset breaks the ABI and is not bisectable. The justification is very
> limited (one sentence), so not really enough.

ARM32 i.MX7ULP and ARM64 i.MX8QXP/i.MX8ULP all need to use two
clocks, PER and IPG. But current dt-bindings and dts, use one clock.

This patchset includes dts changes patch 4 and patch 5.
Patch 6 is to update driver use two clocks.

I think the patch order in this patchset would not break git bisect, it
just break ABI. But I not find good way how could not break ABI,
because only use one clock is wrong whether in dt-bindings or dtbs.

Should I use a fixes tag to dt-bindings, then break ABI is allowed?

Thanks,
Peng.

> 
> Best regards,
> Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Clark Wang <xiaoning.wang@nxp.com>
Subject: RE: [PATCH 0/6] i2c-imx-lpi2c: add IPG clock
Date: Mon, 15 Aug 2022 00:52:58 +0000	[thread overview]
Message-ID: <DU0PR04MB9417D62230578AC8CA4234F288689@DU0PR04MB9417.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <f1add9c7-fc2e-a600-49a6-a6579f17db1b@linaro.org>

Hi Krzysztof,

> Subject: Re: [PATCH 0/6] i2c-imx-lpi2c: add IPG clock
> 
> On 12/08/2022 07:34, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > The i.MX LPI2C needs PER and IPG clock, not just PER or IPG clock.
> > This patch is to enable both PER and IPG clock for imx-i2c-lpi2c.
> 
> This patchset breaks the ABI and is not bisectable. The justification is very
> limited (one sentence), so not really enough.

ARM32 i.MX7ULP and ARM64 i.MX8QXP/i.MX8ULP all need to use two
clocks, PER and IPG. But current dt-bindings and dts, use one clock.

This patchset includes dts changes patch 4 and patch 5.
Patch 6 is to update driver use two clocks.

I think the patch order in this patchset would not break git bisect, it
just break ABI. But I not find good way how could not break ABI,
because only use one clock is wrong whether in dt-bindings or dtbs.

Should I use a fixes tag to dt-bindings, then break ABI is allowed?

Thanks,
Peng.

> 
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-15  0:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  4:34 [PATCH 0/6] i2c-imx-lpi2c: add IPG clock Peng Fan (OSS)
2022-08-12  4:34 ` Peng Fan (OSS)
2022-08-12  4:34 ` [PATCH 1/6] dt-bindings: i2c: i2c-imx-lpi2c: add ipg clk Peng Fan (OSS)
2022-08-12  4:34   ` Peng Fan (OSS)
2022-08-12 10:11   ` Krzysztof Kozlowski
2022-08-12 10:11     ` Krzysztof Kozlowski
2022-08-12 15:13   ` Rob Herring
2022-08-12 15:13     ` Rob Herring
2022-08-12  4:34 ` [PATCH 2/6] dt-bindings: i2c: i2c-imx-lpi2c: add dmas property Peng Fan (OSS)
2022-08-12  4:34   ` Peng Fan (OSS)
2022-08-12 10:11   ` Krzysztof Kozlowski
2022-08-12 10:11     ` Krzysztof Kozlowski
2022-08-12  4:34 ` [PATCH 3/6] dt-bindings: i2c: i2c-imx-lpi2c: add i.MX93 Peng Fan (OSS)
2022-08-12  4:34   ` Peng Fan (OSS)
2022-08-12 10:11   ` Krzysztof Kozlowski
2022-08-12 10:11     ` Krzysztof Kozlowski
2022-08-12  4:34 ` [PATCH 4/6] arm64: dts: imx8-ss-dma: add IPG clock for i2c Peng Fan (OSS)
2022-08-12  4:34   ` Peng Fan (OSS)
2022-08-12  4:34 ` [PATCH 5/6] ARM: dts: imx7ulp: Add PER clock for lpi2c Peng Fan (OSS)
2022-08-12  4:34   ` Peng Fan (OSS)
2022-08-12  4:34 ` [PATCH 6/6] i2c: imx-lpi2c: handle IPG clock Peng Fan (OSS)
2022-08-12  4:34   ` Peng Fan (OSS)
2022-08-12 10:13   ` Krzysztof Kozlowski
2022-08-12 10:13     ` Krzysztof Kozlowski
2022-08-12 18:58     ` Krzysztof Kozlowski
2022-08-12 18:58       ` Krzysztof Kozlowski
2022-08-12 10:14 ` [PATCH 0/6] i2c-imx-lpi2c: add " Krzysztof Kozlowski
2022-08-12 10:14   ` Krzysztof Kozlowski
2022-08-15  0:52   ` Peng Fan [this message]
2022-08-15  0:52     ` Peng Fan
2022-08-16  6:01     ` Krzysztof Kozlowski
2022-08-16  6:01       ` Krzysztof Kozlowski
2022-08-16  6:31       ` Peng Fan
2022-08-16  6:31         ` Peng Fan
2022-08-16  8:43       ` Peng Fan
2022-08-16  8:43         ` Peng Fan
2022-08-16  9:44         ` Krzysztof Kozlowski
2022-08-16  9:44           ` Krzysztof Kozlowski
2022-08-16  9:47           ` Peng Fan
2022-08-16  9:47             ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DU0PR04MB9417D62230578AC8CA4234F288689@DU0PR04MB9417.eurprd04.prod.outlook.com \
    --to=peng.fan@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.