* [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat
@ 2023-12-21 1:55 David Lin
2023-12-21 2:38 ` Brian Norris
2023-12-21 14:41 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: David Lin @ 2023-12-21 1:55 UTC (permalink / raw)
To: linux-wireless
Cc: linux-kernel, briannorris, kvalo, francesco, tsung-hsien.hsieh,
David Lin, stable, kernel test robot, Dan Carpenter
Variable firmware_stat is possible to be used without initialization.
Signed-off-by: David Lin <yu-hao.lin@nxp.com>
Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202312192236.ZflaWYCw-lkp@intel.com/
---
v2:
- corrected spelling error: possilbe -> possible.
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index ef3e68d1059c..75f53c2f1e1f 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -779,7 +779,7 @@ static int mwifiex_check_fw_status(struct mwifiex_adapter *adapter,
{
struct sdio_mmc_card *card = adapter->card;
int ret = 0;
- u16 firmware_stat;
+ u16 firmware_stat = 0;
u32 tries;
for (tries = 0; tries < poll_num; tries++) {
base-commit: 783004b6dbda2cfe9a552a4cc9c1d168a2068f6c
prerequisite-patch-id: ee10b03f813ab1e72d05c59aef4e07a26afdf678
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat
2023-12-21 1:55 [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat David Lin
@ 2023-12-21 2:38 ` Brian Norris
2023-12-21 8:18 ` [EXT] " David Lin
2023-12-21 14:41 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Brian Norris @ 2023-12-21 2:38 UTC (permalink / raw)
To: David Lin
Cc: linux-wireless, linux-kernel, kvalo, francesco,
tsung-hsien.hsieh, stable, kernel test robot, Dan Carpenter
On Thu, Dec 21, 2023 at 09:55:11AM +0800, David Lin wrote:
> Variable firmware_stat is possible to be used without initialization.
>
> Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
> Cc: stable@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202312192236.ZflaWYCw-lkp@intel.com/
Repeating:
Acked-by: Brian Norris <briannorris@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat
2023-12-21 2:38 ` Brian Norris
@ 2023-12-21 8:18 ` David Lin
0 siblings, 0 replies; 4+ messages in thread
From: David Lin @ 2023-12-21 8:18 UTC (permalink / raw)
To: Brian Norris
Cc: linux-wireless, linux-kernel, kvalo, francesco, Pete Hsieh,
stable, kernel test robot, Dan Carpenter
> From: Brian Norris <briannorris@chromium.org>
> Sent: Thursday, December 21, 2023 10:39 AM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; stable@vger.kernel.org; kernel test robot
> <lkp@intel.com>; Dan Carpenter <error27@gmail.com>
> Subject: [EXT] Re: [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Thu, Dec 21, 2023 at 09:55:11AM +0800, David Lin wrote:
> > Variable firmware_stat is possible to be used without initialization.
> >
> > Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> > Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
> > Cc: stable@vger.kernel.org
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <error27@gmail.com>
> > Closes:
> https://lore.kern/
> el.org%2Fr%2F202312192236.ZflaWYCw-lkp%40intel.com%2F&data=05%7C02
> %7Cyu-hao.lin%40nxp.com%7C813d1bc65e8b41e8349808dc01cdf23f%7C686e
> a1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638387231239605883%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mGQ3tVhTOnyO9wXiE
> qI%2Bsym7LqLP5B6bEMofhhsXBzg%3D&reserved=0
>
> Repeating:
>
> Acked-by: Brian Norris <briannorris@chromium.org>
Sorry. I sent out v2 then I found you acked v1. That is the reason I won't add "Acked-by" to v2.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat
2023-12-21 1:55 [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat David Lin
2023-12-21 2:38 ` Brian Norris
@ 2023-12-21 14:41 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-12-21 14:41 UTC (permalink / raw)
To: David Lin
Cc: linux-wireless, linux-kernel, briannorris, francesco,
tsung-hsien.hsieh, David Lin, stable, kernel test robot,
Dan Carpenter
David Lin <yu-hao.lin@nxp.com> wrote:
> Variable firmware_stat is possible to be used without initialization.
>
> Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> Fixes: 1c5d463c0770 ("wifi: mwifiex: add extra delay for firmware ready")
> Cc: stable@vger.kernel.org
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202312192236.ZflaWYCw-lkp@intel.com/
> Acked-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-next.git, thanks.
3df95e265924 wifi: mwifiex: fix uninitialized firmware_stat
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231221015511.1032128-1-yu-hao.lin@nxp.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-21 14:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21 1:55 [PATCH v2] wifi: mwifiex: fix uninitialized firmware_stat David Lin
2023-12-21 2:38 ` Brian Norris
2023-12-21 8:18 ` [EXT] " David Lin
2023-12-21 14:41 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.