All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leo Li <leoyang.li@nxp.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Biwen Li <biwen.li@nxp.com>
Subject: RE: [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes
Date: Wed, 13 Apr 2022 18:07:20 +0000	[thread overview]
Message-ID: <DU2PR04MB894984A336667EF01DF709988FEC9@DU2PR04MB8949.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20220413163306.hp5qyxxgdlekczet@skbuf>



> -----Original Message-----
> From: Vladimir Oltean <olteanv@gmail.com>
> Sent: Wednesday, April 13, 2022 11:33 AM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Biwen Li
> <biwen.li@nxp.com>
> Subject: Re: [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm
> nodes
> 
> On Tue, Dec 14, 2021 at 03:32:35AM -0600, Li Yang wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> >
> > Add pwm nodes using flextimer controller.
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > ---
> >  .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 95 +++++++++++++++++++
> >  1 file changed, 95 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index f2564faf7067..5a7b26a1bad2 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -66,6 +66,13 @@ CPU_PW20: cpu-pw20 {
> >  		};
> >  	};
> >
> > +	rtc_clk: rtc-clk {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <32768>;
> > +		clock-output-names = "rtc_clk";
> > +	};
> > +
> >  	sysclk: sysclk {
> >  		compatible = "fixed-clock";
> >  		#clock-cells = <0>;
> > @@ -1186,6 +1193,94 @@ ierb@1f0800000 {
> >  			reg = <0x01 0xf0800000 0x0 0x10000>;
> >  		};
> >
> > +		pwm0: pwm@2800000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2800000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm1: pwm@2810000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2810000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm2: pwm@2820000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2820000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm3: pwm@2830000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2830000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm4: pwm@2840000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2840000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm5: pwm@2850000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2850000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm6: pwm@2860000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2860000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm7: pwm@2870000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2870000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> >  		rcpm: power-controller@1e34040 {
> >  			compatible = "fsl,ls1028a-rcpm", "fsl,qoriq-rcpm-
> 2.1+";
> >  			reg = <0x0 0x1e34040 0x0 0x1c>;
> > --
> > 2.25.1
> >
> 
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1210.21-1219.5: Warning
> (unique_unit_address): /soc/pwm@2800000: duplicate unit-address (also
> used in node /soc/timer@2800000)
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1221.21-1230.5: Warning
> (unique_unit_address): /soc/pwm@2810000: duplicate unit-address (also
> used in node /soc/timer@2810000)

Well, this is similar situation as pcie.  The flextimer controller can be used as timer, PWM or alarm.  We have separate drivers and bindings for these modes which resulted in different nodes for the same controller.

Regards,
Leo

WARNING: multiple messages have this Message-ID (diff)
From: Leo Li <leoyang.li@nxp.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Biwen Li <biwen.li@nxp.com>
Subject: RE: [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes
Date: Wed, 13 Apr 2022 18:07:20 +0000	[thread overview]
Message-ID: <DU2PR04MB894984A336667EF01DF709988FEC9@DU2PR04MB8949.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20220413163306.hp5qyxxgdlekczet@skbuf>



> -----Original Message-----
> From: Vladimir Oltean <olteanv@gmail.com>
> Sent: Wednesday, April 13, 2022 11:33 AM
> To: Leo Li <leoyang.li@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Biwen Li
> <biwen.li@nxp.com>
> Subject: Re: [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm
> nodes
> 
> On Tue, Dec 14, 2021 at 03:32:35AM -0600, Li Yang wrote:
> > From: Biwen Li <biwen.li@nxp.com>
> >
> > Add pwm nodes using flextimer controller.
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > Signed-off-by: Li Yang <leoyang.li@nxp.com>
> > ---
> >  .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 95 +++++++++++++++++++
> >  1 file changed, 95 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index f2564faf7067..5a7b26a1bad2 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -66,6 +66,13 @@ CPU_PW20: cpu-pw20 {
> >  		};
> >  	};
> >
> > +	rtc_clk: rtc-clk {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <32768>;
> > +		clock-output-names = "rtc_clk";
> > +	};
> > +
> >  	sysclk: sysclk {
> >  		compatible = "fixed-clock";
> >  		#clock-cells = <0>;
> > @@ -1186,6 +1193,94 @@ ierb@1f0800000 {
> >  			reg = <0x01 0xf0800000 0x0 0x10000>;
> >  		};
> >
> > +		pwm0: pwm@2800000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2800000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm1: pwm@2810000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2810000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm2: pwm@2820000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2820000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm3: pwm@2830000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2830000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm4: pwm@2840000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2840000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm5: pwm@2850000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2850000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm6: pwm@2860000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2860000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> > +		pwm7: pwm@2870000 {
> > +			compatible = "fsl,vf610-ftm-pwm";
> > +			#pwm-cells = <3>;
> > +			reg = <0x0 0x2870000 0x0 0x10000>;
> > +			clock-names = "ftm_sys", "ftm_ext",
> > +				      "ftm_fix", "ftm_cnt_clk_en";
> > +			clocks = <&clockgen 4 1>, <&clockgen 4 1>,
> > +				 <&rtc_clk>, <&clockgen 4 1>;
> > +			status = "disabled";
> > +		};
> > +
> >  		rcpm: power-controller@1e34040 {
> >  			compatible = "fsl,ls1028a-rcpm", "fsl,qoriq-rcpm-
> 2.1+";
> >  			reg = <0x0 0x1e34040 0x0 0x1c>;
> > --
> > 2.25.1
> >
> 
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1210.21-1219.5: Warning
> (unique_unit_address): /soc/pwm@2800000: duplicate unit-address (also
> used in node /soc/timer@2800000)
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1221.21-1230.5: Warning
> (unique_unit_address): /soc/pwm@2810000: duplicate unit-address (also
> used in node /soc/timer@2810000)

Well, this is similar situation as pcie.  The flextimer controller can be used as timer, PWM or alarm.  We have separate drivers and bindings for these modes which resulted in different nodes for the same controller.

Regards,
Leo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-13 18:07 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14  9:32 [PATCH v3 0/8] ls1028a device tree update Li Yang
2021-12-14  9:32 ` Li Yang
2021-12-14  9:32 ` [PATCH v3 1/8] arm64: dts: ls1028a: Add PCIe EP nodes Li Yang
2021-12-14  9:32   ` Li Yang
2022-04-13 16:32   ` Vladimir Oltean
2022-04-13 16:32     ` Vladimir Oltean
2022-04-13 18:03     ` Leo Li
2022-04-13 18:03       ` Leo Li
2022-04-13 18:22       ` Vladimir Oltean
2022-04-13 18:22         ` Vladimir Oltean
2022-04-13 18:38         ` Leo Li
2022-04-13 18:38           ` Leo Li
2021-12-14  9:32 ` [PATCH v3 2/8] arm64: dts: ls1028a: add ftm_alarm1 node to be used as wakeup source Li Yang
2021-12-14  9:32   ` Li Yang
2021-12-14  9:32 ` [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes Li Yang
2021-12-14  9:32   ` Li Yang
2022-04-13 16:33   ` Vladimir Oltean
2022-04-13 16:33     ` Vladimir Oltean
2022-04-13 18:07     ` Leo Li [this message]
2022-04-13 18:07       ` Leo Li
2022-04-13 18:23       ` Vladimir Oltean
2022-04-13 18:23         ` Vladimir Oltean
2022-04-13 19:10         ` Leo Li
2022-04-13 19:10           ` Leo Li
2022-07-28  9:33           ` Michael Walle
2022-07-28  9:33             ` Michael Walle
2022-08-16  9:04             ` Michael Walle
2022-08-16  9:04               ` Michael Walle
2022-08-17 20:20             ` Sean Anderson
2022-08-17 20:20               ` Sean Anderson
2021-12-14  9:32 ` [PATCH v3 4/8] arm64: dts: ls1028a-rdb: reorder nodes to be alphabetic Li Yang
2021-12-14  9:32   ` Li Yang
2021-12-16 10:01   ` Shawn Guo
2021-12-16 10:01     ` Shawn Guo
2021-12-14  9:32 ` [PATCH v3 5/8] arm64: dts: ls1028a-rdb: enable pwm0 Li Yang
2021-12-14  9:32   ` Li Yang
2021-12-14  9:32 ` [PATCH v3 6/8] arm64: dts: ls1028a-qds: move rtc node to the correct i2c bus Li Yang
2021-12-14  9:32   ` Li Yang
2021-12-14  9:32 ` [PATCH v3 7/8] arm64: dts: ls1028a-qds: enable lpuart1 Li Yang
2021-12-14  9:32   ` Li Yang
2021-12-14  9:32 ` [PATCH v3 8/8] arm64: dts: ls1028a-qds: add overlays for various serdes protocols Li Yang
2021-12-14  9:32   ` Li Yang
2022-01-26  8:33   ` Shawn Guo
2022-01-26  8:33     ` Shawn Guo
2022-01-26  8:55     ` Leo Li
2022-01-26  8:55       ` Leo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DU2PR04MB894984A336667EF01DF709988FEC9@DU2PR04MB8949.eurprd04.prod.outlook.com \
    --to=leoyang.li@nxp.com \
    --cc=biwen.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.