* Re: [PATCH lttng-tools] Cleanup: Remove fun from code base
[not found] <1474828347-21108-1-git-send-email-mathieu.desnoyers@efficios.com>
@ 2016-09-27 12:57 ` Jesper Derehag
2016-09-27 19:13 ` Jérémie Galarneau
[not found] ` <CA+jJMxup+Xu1BsQ0ZKcEqmoC0+9spSe0O14WTM5VxOPz7_FUNw@mail.gmail.com>
2 siblings, 0 replies; 4+ messages in thread
From: Jesper Derehag @ 2016-09-27 12:57 UTC (permalink / raw)
To: Mathieu Desnoyers, jgalar; +Cc: lttng-dev
ehhh... taking all the fun out of the job? =)
----------------------------------------
> From: mathieu.desnoyers@efficios.com
> To: jgalar@efficios.com
> Date: Sun, 25 Sep 2016 14:32:27 -0400
> CC: lttng-dev@lists.lttng.org
> Subject: [lttng-dev] [PATCH lttng-tools] Cleanup: Remove fun from code base
>
> It appears choosing the release names provides plenty of enjoyment to
> LTTng developers, thus allowing us to remove those easter eggs.
>
> Incidentally, it will allow me to demo the LTTng project without
> carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
> time I issue a "lttng" command.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> ---
> src/bin/lttng-sessiond/main.c | 6 ------
> src/bin/lttng/lttng.c | 8 --------
> 2 files changed, 14 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
> index b067461..5e19f37 100644
> --- a/src/bin/lttng-sessiond/main.c
> +++ b/src/bin/lttng-sessiond/main.c
> @@ -760,12 +760,6 @@ static void sessiond_cleanup_options(void)
> free(kmod_extra_probes_list);
>
> run_as_destroy_worker();
> -
> - /* <fun> */
> - DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
> - "Matthew, BEET driven development works!%c[%dm",
> - 27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
> - /* </fun> */
> }
>
> /*
> diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
> index 34816be..9317e83 100644
> --- a/src/bin/lttng/lttng.c
> +++ b/src/bin/lttng/lttng.c
> @@ -389,14 +389,6 @@ static int parse_args(int argc, char **argv)
> goto error;
> }
>
> - /* For Mathieu Desnoyers a.k.a. Dr. Tracing */
> - user = getenv("USER");
> - if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
> - strncmp("compudj", user, 7) == 0))) {
> - MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
> - }
> - /* Thanks Mathieu */
> -
> /*
> * Handle leftovers which is a first level command with the trailing
> * options.
> --
> 2.1.4
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH lttng-tools] Cleanup: Remove fun from code base
[not found] <1474828347-21108-1-git-send-email-mathieu.desnoyers@efficios.com>
2016-09-27 12:57 ` [PATCH lttng-tools] Cleanup: Remove fun from code base Jesper Derehag
@ 2016-09-27 19:13 ` Jérémie Galarneau
[not found] ` <CA+jJMxup+Xu1BsQ0ZKcEqmoC0+9spSe0O14WTM5VxOPz7_FUNw@mail.gmail.com>
2 siblings, 0 replies; 4+ messages in thread
From: Jérémie Galarneau @ 2016-09-27 19:13 UTC (permalink / raw)
To: Mathieu Desnoyers; +Cc: lttng-dev, Jeremie Galarneau
Fun removed from master, thanks... ;)
Jérémie
On 25 September 2016 at 14:32, Mathieu Desnoyers
<mathieu.desnoyers@efficios.com> wrote:
> It appears choosing the release names provides plenty of enjoyment to
> LTTng developers, thus allowing us to remove those easter eggs.
>
> Incidentally, it will allow me to demo the LTTng project without
> carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
> time I issue a "lttng" command.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> ---
> src/bin/lttng-sessiond/main.c | 6 ------
> src/bin/lttng/lttng.c | 8 --------
> 2 files changed, 14 deletions(-)
>
> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
> index b067461..5e19f37 100644
> --- a/src/bin/lttng-sessiond/main.c
> +++ b/src/bin/lttng-sessiond/main.c
> @@ -760,12 +760,6 @@ static void sessiond_cleanup_options(void)
> free(kmod_extra_probes_list);
>
> run_as_destroy_worker();
> -
> - /* <fun> */
> - DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
> - "Matthew, BEET driven development works!%c[%dm",
> - 27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
> - /* </fun> */
> }
>
> /*
> diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
> index 34816be..9317e83 100644
> --- a/src/bin/lttng/lttng.c
> +++ b/src/bin/lttng/lttng.c
> @@ -389,14 +389,6 @@ static int parse_args(int argc, char **argv)
> goto error;
> }
>
> - /* For Mathieu Desnoyers a.k.a. Dr. Tracing */
> - user = getenv("USER");
> - if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
> - strncmp("compudj", user, 7) == 0))) {
> - MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
> - }
> - /* Thanks Mathieu */
> -
> /*
> * Handle leftovers which is a first level command with the trailing
> * options.
> --
> 2.1.4
>
--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH lttng-tools] Cleanup: Remove fun from code base
[not found] ` <CA+jJMxup+Xu1BsQ0ZKcEqmoC0+9spSe0O14WTM5VxOPz7_FUNw@mail.gmail.com>
@ 2016-09-27 19:24 ` Philippe Proulx
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Proulx @ 2016-09-27 19:24 UTC (permalink / raw)
To: Jérémie Galarneau; +Cc: lttng-dev, Jeremie Galarneau
Finally this project is getting serious!
Philippe Proulx
On Tue, Sep 27, 2016 at 3:13 PM, Jérémie Galarneau
<jeremie.galarneau@efficios.com> wrote:
> Fun removed from master, thanks... ;)
>
> Jérémie
>
> On 25 September 2016 at 14:32, Mathieu Desnoyers
> <mathieu.desnoyers@efficios.com> wrote:
>> It appears choosing the release names provides plenty of enjoyment to
>> LTTng developers, thus allowing us to remove those easter eggs.
>>
>> Incidentally, it will allow me to demo the LTTng project without
>> carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
>> time I issue a "lttng" command.
>>
>> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
>> ---
>> src/bin/lttng-sessiond/main.c | 6 ------
>> src/bin/lttng/lttng.c | 8 --------
>> 2 files changed, 14 deletions(-)
>>
>> diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
>> index b067461..5e19f37 100644
>> --- a/src/bin/lttng-sessiond/main.c
>> +++ b/src/bin/lttng-sessiond/main.c
>> @@ -760,12 +760,6 @@ static void sessiond_cleanup_options(void)
>> free(kmod_extra_probes_list);
>>
>> run_as_destroy_worker();
>> -
>> - /* <fun> */
>> - DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
>> - "Matthew, BEET driven development works!%c[%dm",
>> - 27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
>> - /* </fun> */
>> }
>>
>> /*
>> diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
>> index 34816be..9317e83 100644
>> --- a/src/bin/lttng/lttng.c
>> +++ b/src/bin/lttng/lttng.c
>> @@ -389,14 +389,6 @@ static int parse_args(int argc, char **argv)
>> goto error;
>> }
>>
>> - /* For Mathieu Desnoyers a.k.a. Dr. Tracing */
>> - user = getenv("USER");
>> - if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
>> - strncmp("compudj", user, 7) == 0))) {
>> - MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
>> - }
>> - /* Thanks Mathieu */
>> -
>> /*
>> * Handle leftovers which is a first level command with the trailing
>> * options.
>> --
>> 2.1.4
>>
>
>
>
> --
> Jérémie Galarneau
> EfficiOS Inc.
> http://www.efficios.com
> _______________________________________________
> lttng-dev mailing list
> lttng-dev@lists.lttng.org
> https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH lttng-tools] Cleanup: Remove fun from code base
@ 2016-09-25 18:32 Mathieu Desnoyers
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Desnoyers @ 2016-09-25 18:32 UTC (permalink / raw)
To: jgalar; +Cc: lttng-dev
It appears choosing the release names provides plenty of enjoyment to
LTTng developers, thus allowing us to remove those easter eggs.
Incidentally, it will allow me to demo the LTTng project without
carrying this <yellow>Welcome back Dr Tracing!</yellow> message each
time I issue a "lttng" command.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
src/bin/lttng-sessiond/main.c | 6 ------
src/bin/lttng/lttng.c | 8 --------
2 files changed, 14 deletions(-)
diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index b067461..5e19f37 100644
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -760,12 +760,6 @@ static void sessiond_cleanup_options(void)
free(kmod_extra_probes_list);
run_as_destroy_worker();
-
- /* <fun> */
- DBG("%c[%d;%dm*** assert failed :-) *** ==> %c[%dm%c[%d;%dm"
- "Matthew, BEET driven development works!%c[%dm",
- 27, 1, 31, 27, 0, 27, 1, 33, 27, 0);
- /* </fun> */
}
/*
diff --git a/src/bin/lttng/lttng.c b/src/bin/lttng/lttng.c
index 34816be..9317e83 100644
--- a/src/bin/lttng/lttng.c
+++ b/src/bin/lttng/lttng.c
@@ -389,14 +389,6 @@ static int parse_args(int argc, char **argv)
goto error;
}
- /* For Mathieu Desnoyers a.k.a. Dr. Tracing */
- user = getenv("USER");
- if (user != NULL && ((strncmp(progname, "drtrace", 7) == 0 ||
- strncmp("compudj", user, 7) == 0))) {
- MSG("%c[%d;%dmWelcome back Dr Tracing!%c[%dm\n", 27,1,33,27,0);
- }
- /* Thanks Mathieu */
-
/*
* Handle leftovers which is a first level command with the trailing
* options.
--
2.1.4
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-27 19:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1474828347-21108-1-git-send-email-mathieu.desnoyers@efficios.com>
2016-09-27 12:57 ` [PATCH lttng-tools] Cleanup: Remove fun from code base Jesper Derehag
2016-09-27 19:13 ` Jérémie Galarneau
[not found] ` <CA+jJMxup+Xu1BsQ0ZKcEqmoC0+9spSe0O14WTM5VxOPz7_FUNw@mail.gmail.com>
2016-09-27 19:24 ` Philippe Proulx
2016-09-25 18:32 Mathieu Desnoyers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.