From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Yoni Gilad <yonig@radcom.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] tools: fix active interface detection in dpdk-devbind.py
Date: Tue, 10 Jan 2017 09:22:41 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476C0F16@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1483979853-16386-1-git-send-email-yonig@radcom.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yoni Gilad
> Sent: Monday, January 09, 2017 4:38 PM
> To: De Lara Guarch, Pablo; Jain, Deepak K
> Cc: dev@dpdk.org; Yoni Gilad; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] tools: fix active interface detection in dpdk-
> devbind.py
>
> When adding crypto devices, the "Active" and "Ssh_if" attributes of
> existing network devices were reset. This causes the follwing issues:
>
> - Network interfaces aren't marked as "*Active*" in the --status output.
> - Active network interfaces can be unbound without the --force option,
> causing loss of network connection.
>
> The reset was caused by the call to devices[d].update in
> get_crypto_details.
>
> This patch prevents the update on non-crypto devices.
>
> Fixes: cb4a1d1 ("tools: bind crypto devices")
>
> CC: stable@dpdk.org
>
> Signed-off-by: Yoni Gilad <yonig@radcom.com>
> ---
> usertools/dpdk-devbind.py | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index e057b87..1b9c651 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -328,6 +328,9 @@ def get_crypto_details():
>
> # based on the basic info, get extended text details
> for d in devices.keys():
> + if devices[d]["Class"][0:2] != CRYPTO_BASE_CLASS:
> + continue
> +
> # get additional info and add it to existing data
> devices[d] = devices[d].copy()
> devices[d].update(get_pci_device_details(d).items())
> --
> 1.7.1
Typo in "follwing". Also, the fixline SHA should be " cb4a1d14bf3e", the first 6 bytes.
Apart from this,
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2017-01-10 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 16:37 [PATCH] tools: fix active interface detection in dpdk-devbind.py Yoni Gilad
2017-01-10 9:22 ` De Lara Guarch, Pablo [this message]
2017-01-10 17:14 ` [PATCH v2] " Yoni Gilad
2017-01-30 16:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897476C0F16@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=yonig@radcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.