* [PATCH] crypto/scheduler: remove deprecation functions
@ 2017-05-25 7:29 Fan Zhang
2017-05-29 12:42 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Fan Zhang @ 2017-05-25 7:29 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch
This patch remove the deprecation functions as well as notice for
scheduler mode set/get API changes.
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
doc/guides/rel_notes/deprecation.rst | 6 ----
drivers/crypto/scheduler/rte_cryptodev_scheduler.c | 13 ---------
drivers/crypto/scheduler/rte_cryptodev_scheduler.h | 32 ----------------------
.../scheduler/rte_pmd_crypto_scheduler_version.map | 2 --
4 files changed, 53 deletions(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ba9b5a2..9499b56 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -117,12 +117,6 @@ Deprecation Notices
and ``rte_crypto_sym_xform`` will be restructured in 17.08,
for correctness and improvement.
-* crypto/scheduler: the following two functions are deprecated starting
- from 17.05 and will be removed in 17.08:
-
- - ``rte_crpytodev_scheduler_mode_get``, replaced by ``rte_cryptodev_scheduler_mode_get``
- - ``rte_crpytodev_scheduler_mode_set``, replaced by ``rte_cryptodev_scheduler_mode_set``
-
* librte_table: The ``key_mask`` parameter will be added to all the hash tables
that currently do not have it, as well as to the hash compute function prototype.
The non-"do-sig" versions of the hash tables will be removed
diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
index 319dcf0..95566d5 100644
--- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
+++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
@@ -359,13 +359,6 @@ rte_cryptodev_scheduler_mode_set(uint8_t scheduler_id,
return 0;
}
-int
-rte_crpytodev_scheduler_mode_set(uint8_t scheduler_id,
- enum rte_cryptodev_scheduler_mode mode)
-{
- return rte_cryptodev_scheduler_mode_set(scheduler_id, mode);
-}
-
enum rte_cryptodev_scheduler_mode
rte_cryptodev_scheduler_mode_get(uint8_t scheduler_id)
{
@@ -387,12 +380,6 @@ rte_cryptodev_scheduler_mode_get(uint8_t scheduler_id)
return sched_ctx->mode;
}
-enum rte_cryptodev_scheduler_mode
-rte_crpytodev_scheduler_mode_get(uint8_t scheduler_id)
-{
- return rte_cryptodev_scheduler_mode_get(scheduler_id);
-}
-
int
rte_cryptodev_scheduler_ordering_set(uint8_t scheduler_id,
uint32_t enable_reorder)
diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.h b/drivers/crypto/scheduler/rte_cryptodev_scheduler.h
index 2ba6e47..33570ec 100644
--- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.h
+++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.h
@@ -186,38 +186,6 @@ enum rte_cryptodev_scheduler_mode
rte_cryptodev_scheduler_mode_get(uint8_t scheduler_id);
/**
- * @deprecated
- * Set the scheduling mode
- *
- * @param scheduler_id
- * The target scheduler device ID
- * @param mode
- * The scheduling mode
- *
- * @return
- * 0 if attaching successful, negative integer if otherwise.
- */
-__rte_deprecated
-int
-rte_crpytodev_scheduler_mode_set(uint8_t scheduler_id,
- enum rte_cryptodev_scheduler_mode mode);
-
-/**
- * @deprecated
- * Get the current scheduling mode
- *
- * @param scheduler_id
- * The target scheduler device ID
- *
- * @return
- * If successful, returns the scheduling mode, negative integer
- * otherwise
- */
-__rte_deprecated
-enum rte_cryptodev_scheduler_mode
-rte_crpytodev_scheduler_mode_get(uint8_t scheduler_id);
-
-/**
* Set the crypto ops reordering feature on/off
*
* @param scheduler_id
diff --git a/drivers/crypto/scheduler/rte_pmd_crypto_scheduler_version.map b/drivers/crypto/scheduler/rte_pmd_crypto_scheduler_version.map
index 0a8b471..5c43127 100644
--- a/drivers/crypto/scheduler/rte_pmd_crypto_scheduler_version.map
+++ b/drivers/crypto/scheduler/rte_pmd_crypto_scheduler_version.map
@@ -4,8 +4,6 @@ DPDK_17.02 {
rte_cryptodev_scheduler_load_user_scheduler;
rte_cryptodev_scheduler_slave_attach;
rte_cryptodev_scheduler_slave_detach;
- rte_crpytodev_scheduler_mode_set;
- rte_crpytodev_scheduler_mode_get;
rte_cryptodev_scheduler_ordering_set;
rte_cryptodev_scheduler_ordering_get;
--
2.9.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto/scheduler: remove deprecation functions
2017-05-25 7:29 [PATCH] crypto/scheduler: remove deprecation functions Fan Zhang
@ 2017-05-29 12:42 ` De Lara Guarch, Pablo
2017-06-28 19:53 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2017-05-29 12:42 UTC (permalink / raw)
To: Zhang, Roy Fan, dev
> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Thursday, May 25, 2017 8:30 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] crypto/scheduler: remove deprecation functions
>
> This patch remove the deprecation functions as well as notice for
> scheduler mode set/get API changes.
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Should be "deprecated functions", but I can change that when merging.
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto/scheduler: remove deprecation functions
2017-05-29 12:42 ` De Lara Guarch, Pablo
@ 2017-06-28 19:53 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2017-06-28 19:53 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Zhang, Roy Fan, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Monday, May 29, 2017 1:42 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: remove deprecation
> functions
>
>
>
> > -----Original Message-----
> > From: Zhang, Roy Fan
> > Sent: Thursday, May 25, 2017 8:30 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo
> > Subject: [PATCH] crypto/scheduler: remove deprecation functions
> >
> > This patch remove the deprecation functions as well as notice for
> > scheduler mode set/get API changes.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>
> Should be "deprecated functions", but I can change that when merging.
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-28 19:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25 7:29 [PATCH] crypto/scheduler: remove deprecation functions Fan Zhang
2017-05-29 12:42 ` De Lara Guarch, Pablo
2017-06-28 19:53 ` De Lara Guarch, Pablo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.