All of lore.kernel.org
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: 'Akhil Goyal' <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] crypto/dpaa2_sec: update driver name string
Date: Thu, 6 Jul 2017 07:49:31 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBD6F66@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20170705162142.11170-1-akhil.goyal@nxp.com>

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Wednesday, July 5, 2017 5:22 PM
> To: dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
> 
> while registering driver to dpaa2, hard coded string is used.
> It is now updated as per the latest changes in string name.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> index 769a139..b0794f5 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
> rte_dpaa2_sec_driver = {
>  	.remove = cryptodev_dpaa2_sec_remove,
>  };
> 
> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
> rte_dpaa2_sec_driver);
>  RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
> cryptodev_driver_id);
> --
> 2.9.3

Now that the name is internal, and since this not used to create a vdev and therefore,
it is not used publicly, could we modify the name from "crypto_dpaa2_sec_pmd" to
"crypto_dpaa2_sec", to follow the crypto driver name convention (crypto_<pmd_name>?

Thanks,
Pablo

  reply	other threads:[~2017-07-06  7:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 16:21 [PATCH] crypto/dpaa2_sec: update driver name string Akhil Goyal
2017-07-06  7:49 ` De Lara Guarch, Pablo [this message]
2017-07-06  8:54   ` Akhil Goyal
2017-07-06  8:56     ` De Lara Guarch, Pablo
2017-07-06 11:00     ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBD6F66@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.