All of lore.kernel.org
 help / color / mirror / Atom feed
* cpufreq/linux/arch/i386/kernel/cpufreq speedstep-piix4.c,1.5,1.6
@ 2003-07-11 13:11 Ducrot Bruno
  0 siblings, 0 replies; only message in thread
From: Ducrot Bruno @ 2003-07-11 13:11 UTC (permalink / raw)
  To: cpufreq

Update of /mnt/src/cvsroot/cpufreq/linux/arch/i386/kernel/cpufreq
In directory flint:/tmp/cvs-serv27166

Modified Files:
	speedstep-piix4.c 
Log Message:
- typo fix in a dprintk statement (pcntrl was printed as the same).
- Touching the CC_EN bit in the PCNTRL IO register seems to be a really bad
  idea, actually.  That break in fact more systems than it resolve.
- seems that we do not need to do a dummy read with port 0x80 after all.


Index: speedstep-piix4.c
===================================================================
RCS file: /mnt/src/cvsroot/cpufreq/linux/arch/i386/kernel/cpufreq/speedstep-piix4.c,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- speedstep-piix4.c	27 Jun 2003 12:43:57 -0000	1.5
+++ speedstep-piix4.c	11 Jul 2003 13:11:15 -0000	1.6
@@ -116,14 +116,14 @@
 	cntb |= (1 << 5);       /* CPU_SEL = 1 */
 
 	dprintk(KERN_DEBUG "cntb before: 0x%.8x\n", cntb_save);
-	dprintk(KERN_DEBUG "cntb after:  0x%.8x\n", cntb_save);
+	dprintk(KERN_DEBUG "cntb after:  0x%.8x\n", cntb);
 
 	pci_write_config_dword(speedstep_chipset_dev, 0x48, cntb);
 
 	/* read state */
 	value = inb_p(pmbase + gpo_hilo_port);
 
-	/* write new state */
+	/* compute new state */
 	value &= ~(1 << gpo_hilo_shift);
 	value |= state << gpo_hilo_shift;
 
@@ -139,7 +139,6 @@
 	pcntrl |= 1 << 12;              /* STPCLK_EN = 1 */
 	pcntrl |= 1 << 11;              /* SLEEP_EN = 1 */
 	pcntrl &= ~(1 << 10);           /* BURST_EN = 0 */
-	pcntrl |= 1 << 9;               /* CC_EN = 1 */
 	pcntrl &= ~(1 << 4);            /* THT_EN = 0 */
 
 	dprintk(KERN_DEBUG "pcntrl before: 0x%.8x\n", pcntrl_save);
@@ -151,9 +150,6 @@
 	outb_p(value, pmbase + gpo_hilo_port);
 	wbinvd();
 	inb_p(pmbase + 0x15);
-
-	/* We may have to do a dummy read after C3. */
-	inb(0x80);
 
 	/* cleanup */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-07-11 13:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-11 13:11 cpufreq/linux/arch/i386/kernel/cpufreq speedstep-piix4.c,1.5,1.6 Ducrot Bruno

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.