All of lore.kernel.org
 help / color / mirror / Atom feed
* [DTC PATCH] remove check for interrupt-controller property under /chosen
@ 2007-02-19 17:28 Stuart Yoder
  2007-02-20 17:57 ` Jon Loeliger
  0 siblings, 1 reply; 2+ messages in thread
From: Stuart Yoder @ 2007-02-19 17:28 UTC (permalink / raw)
  To: jdl; +Cc: linuxppc-dev, linuxppc-release


Remove warning for missing interrupt-controller property
under /chosen.  There is consensus that this
property does not belong here.

Also, add a warning if interrupt-controller _is_ found
under /chosen.

Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>
---
 livetree.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/livetree.c b/livetree.c
index ede29fb..1a2764d 100644
--- a/livetree.c
+++ b/livetree.c
@@ -594,7 +594,14 @@ static int check_chosen(struct node *roo
 
 	CHECK_HAVE_WARN_STRING(chosen, "bootargs");
 	CHECK_HAVE_WARN_STRING(chosen, "linux,stdout-path");
-	CHECK_HAVE_WARN_PHANDLE(chosen, "interrupt-controller", root);
+
+        /* give warning for obsolete interrupt-controller property */
+	do {
+		if ((prop = get_property(chosen, "interrupt-controller")) != NULL) {
+			WARNMSG("%s has obsolete \"%s\" property\n",
+                                 chosen->fullpath, "interrupt-controller"); 
+                }
+	} while (0);
 
 	return ok;	
 }
-- 
1.4.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [DTC PATCH] remove check for interrupt-controller property under /chosen
  2007-02-19 17:28 [DTC PATCH] remove check for interrupt-controller property under /chosen Stuart Yoder
@ 2007-02-20 17:57 ` Jon Loeliger
  0 siblings, 0 replies; 2+ messages in thread
From: Jon Loeliger @ 2007-02-20 17:57 UTC (permalink / raw)
  To: Stuart Yoder; +Cc: linuxppc-dev

So, like, the other day Stuart Yoder mumbled:
> 
> Remove warning for missing interrupt-controller property
> under /chosen.  There is consensus that this
> property does not belong here.
> 
> Also, add a warning if interrupt-controller _is_ found
> under /chosen.
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@freescale.com>

Applied.

Thanks,
jdl

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-02-20 17:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-19 17:28 [DTC PATCH] remove check for interrupt-controller property under /chosen Stuart Yoder
2007-02-20 17:57 ` Jon Loeliger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.