* [Qemu-devel] [7166] qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf)
@ 2009-04-17 20:44 Anthony Liguori
0 siblings, 0 replies; only message in thread
From: Anthony Liguori @ 2009-04-17 20:44 UTC (permalink / raw)
To: qemu-devel
Revision: 7166
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7166
Author: aliguori
Date: 2009-04-17 20:44:41 +0000 (Fri, 17 Apr 2009)
Log Message:
-----------
qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf)
This patch fixes a qcow2 corruption bug introduced in SVN Rev 5861. L2 tables
are big endian, so entries must be converted before being passed to functions.
This bug is easy to trigger. The following script will create and destroy a
qcow2 image (the header is gone after three loop iterations):
#!/bin/bash
qemu-img create -f qcow2 test.qcow 1M
for i in $(seq 1 10); do
qemu-system-x86_64 -hda test.qcow -monitor stdio > /dev/null 2>&1 <<EOF
savevm test-$i
quit
EOF
done
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Revision Links:
--------------
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5861
Modified Paths:
--------------
branches/stable_0_10/block-qcow2.c
Modified: branches/stable_0_10/block-qcow2.c
===================================================================
--- branches/stable_0_10/block-qcow2.c 2009-04-17 20:44:06 UTC (rev 7165)
+++ branches/stable_0_10/block-qcow2.c 2009-04-17 20:44:41 UTC (rev 7166)
@@ -916,7 +916,7 @@
goto err;
for (i = 0; i < j; i++)
- free_any_clusters(bs, old_cluster[i], 1);
+ free_any_clusters(bs, be64_to_cpu(old_cluster[i]), 1);
ret = 0;
err:
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-04-17 20:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-17 20:44 [Qemu-devel] [7166] qcow2 corruption: Fix alloc_cluster_link_l2 (Kevin Wolf) Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.