* [Qemu-devel] [PATCH 1/2] Fix QCOW2 debugging code to compile with DEBUG_ALLOC defined.
@ 2009-06-23 13:46 Filip Navara
2009-06-23 14:44 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Filip Navara @ 2009-06-23 13:46 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Filip Navara <filip.navara@gmail.com>
---
block/qcow2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 9acbddf..fdcd20b 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -251,7 +251,7 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags)
goto fail;
#ifdef DEBUG_ALLOC
- check_refcounts(bs);
+ qcow2_check_refcounts(bs);
#endif
return 0;
--
1.6.3.msysgit.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] Fix QCOW2 debugging code to compile with DEBUG_ALLOC defined.
2009-06-23 13:46 [Qemu-devel] [PATCH 1/2] Fix QCOW2 debugging code to compile with DEBUG_ALLOC defined Filip Navara
@ 2009-06-23 14:44 ` Kevin Wolf
2009-06-23 15:28 ` Filip Navara
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2009-06-23 14:44 UTC (permalink / raw)
To: Filip Navara; +Cc: qemu-devel
Filip Navara schrieb:
> Signed-off-by: Filip Navara <filip.navara@gmail.com>
> ---
> block/qcow2.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 9acbddf..fdcd20b 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -251,7 +251,7 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags)
> goto fail;
>
> #ifdef DEBUG_ALLOC
> - check_refcounts(bs);
> + qcow2_check_refcounts(bs);
> #endif
> return 0;
>
Good point. However, this is not complete. During the qcow2 source split
the #ifdefs have been spread over the files, but the #define hasn't
moved to qcow2.h. To fix debugging you should move it there and fix the
additional compile errors in the other files, too. Also, defining
DEBUG_ALLOC2 gives even more errors, so maybe they should handled here
as well.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1/2] Fix QCOW2 debugging code to compile with DEBUG_ALLOC defined.
2009-06-23 14:44 ` Kevin Wolf
@ 2009-06-23 15:28 ` Filip Navara
0 siblings, 0 replies; 3+ messages in thread
From: Filip Navara @ 2009-06-23 15:28 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Tue, Jun 23, 2009 at 4:44 PM, Kevin Wolf<kwolf@redhat.com> wrote:
> Filip Navara schrieb:
>> Signed-off-by: Filip Navara <filip.navara@gmail.com>
>> ---
>> block/qcow2.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/block/qcow2.c b/block/qcow2.c
>> index 9acbddf..fdcd20b 100644
>> --- a/block/qcow2.c
>> +++ b/block/qcow2.c
>> @@ -251,7 +251,7 @@ static int qcow_open(BlockDriverState *bs, const char *filename, int flags)
>> goto fail;
>>
>> #ifdef DEBUG_ALLOC
>> - check_refcounts(bs);
>> + qcow2_check_refcounts(bs);
>> #endif
>> return 0;
>>
>
> Good point. However, this is not complete. During the qcow2 source split
> the #ifdefs have been spread over the files, but the #define hasn't
> moved to qcow2.h. To fix debugging you should move it there and fix the
> additional compile errors in the other files, too. Also, defining
> DEBUG_ALLOC2 gives even more errors, so maybe they should handled here
> as well.
>
> Kevin
I have sent a new patch that fixes all the QCOW2 debugging code in my
environment and moves the definitions to qcow2.h. Thanks for comments.
Best regards,
Filip Navara
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-23 15:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-23 13:46 [Qemu-devel] [PATCH 1/2] Fix QCOW2 debugging code to compile with DEBUG_ALLOC defined Filip Navara
2009-06-23 14:44 ` Kevin Wolf
2009-06-23 15:28 ` Filip Navara
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.