All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmaengine: PL08x: Fix trivial build error
@ 2011-08-06  8:40 Russell King - ARM Linux
  2011-08-08  4:37 ` Koul, Vinod
  2011-08-08 11:42 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: Russell King - ARM Linux @ 2011-08-06  8:40 UTC (permalink / raw)
  To: linux-arm-kernel

Something changed during the 3.1 merge window in the include files
which now causes the pl08x DMA engine driver to fail to build.  Fix
this by adding the now necessary dma-mapping.h include:

drivers/dma/amba-pl08x.c: In function ?pl08x_unmap_buffers?:
drivers/dma/amba-pl08x.c:1524: error: implicit declaration of function ?dma_unmap_single?
drivers/dma/amba-pl08x.c:1527: error: implicit declaration of function ?dma_unmap_page?

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
If you can provide an ack, and I'll push this through my pending
'fixes' merge.

 drivers/dma/amba-pl08x.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 196a737..be21e3f 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -80,6 +80,7 @@
 #include <linux/interrupt.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
+#include <linux/dma-mapping.h>
 #include <linux/dmapool.h>
 #include <linux/dmaengine.h>
 #include <linux/amba/bus.h>
-- 
1.7.4.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] dmaengine: PL08x: Fix trivial build error
  2011-08-06  8:40 [PATCH] dmaengine: PL08x: Fix trivial build error Russell King - ARM Linux
@ 2011-08-08  4:37 ` Koul, Vinod
  2011-08-08 11:42 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Koul, Vinod @ 2011-08-08  4:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, 2011-08-06 at 09:40 +0100, Russell King - ARM Linux wrote:
> Something changed during the 3.1 merge window in the include files
> which now causes the pl08x DMA engine driver to fail to build.  Fix
> this by adding the now necessary dma-mapping.h include:
> 
> drivers/dma/amba-pl08x.c: In function ?pl08x_unmap_buffers?:
> drivers/dma/amba-pl08x.c:1524: error: implicit declaration of function ?dma_unmap_single?
> drivers/dma/amba-pl08x.c:1527: error: implicit declaration of function ?dma_unmap_page?
> 
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> If you can provide an ack, and I'll push this through my pending
> 'fixes' merge.
Sure...
Acked-by: Vinod Koul <vinod.koul@intel.com>
> 
>  drivers/dma/amba-pl08x.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 196a737..be21e3f 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -80,6 +80,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/slab.h>
>  #include <linux/delay.h>
> +#include <linux/dma-mapping.h>
>  #include <linux/dmapool.h>
>  #include <linux/dmaengine.h>
>  #include <linux/amba/bus.h>


-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] dmaengine: PL08x: Fix trivial build error
  2011-08-06  8:40 [PATCH] dmaengine: PL08x: Fix trivial build error Russell King - ARM Linux
  2011-08-08  4:37 ` Koul, Vinod
@ 2011-08-08 11:42 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2011-08-08 11:42 UTC (permalink / raw)
  To: linux-arm-kernel

2011/8/6 Russell King - ARM Linux <linux@arm.linux.org.uk>:

> Something changed during the 3.1 merge window in the include files
> which now causes the pl08x DMA engine driver to fail to build. ?Fix
> this by adding the now necessary dma-mapping.h include:
>
> drivers/dma/amba-pl08x.c: In function ?pl08x_unmap_buffers?:
> drivers/dma/amba-pl08x.c:1524: error: implicit declaration of function ?dma_unmap_single?
> drivers/dma/amba-pl08x.c:1527: error: implicit declaration of function ?dma_unmap_page?
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> If you can provide an ack, and I'll push this through my pending
> 'fixes' merge.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-08 11:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-06  8:40 [PATCH] dmaengine: PL08x: Fix trivial build error Russell King - ARM Linux
2011-08-08  4:37 ` Koul, Vinod
2011-08-08 11:42 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.