* [PATCH v2 1/2] drm/panel: remove unnecessary dependencies
@ 2014-06-12 16:09 ` Russell King
0 siblings, 0 replies; 6+ messages in thread
From: Russell King @ 2014-06-12 16:09 UTC (permalink / raw)
To: linux-arm-kernel
DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
DRM_PANEL && DRM. This is nonsense for two reasons:
(a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
without DRM first being enabled. Hence the && DRM is useless.
(b) These two configs are already beneath a menu which depends on
DRM_PANEL being enabled; these options will not be visible without
DRM_PANEL already being enabled.
Let's just remove this unnecessary verbosity.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/gpu/drm/panel/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 4ec874da5668..d83958d39f43 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -5,7 +5,7 @@ config DRM_PANEL
Panel registration and lookup framework.
menu "Display Panels"
- depends on DRM_PANEL
+ depends on DRM && DRM_PANEL
config DRM_PANEL_SIMPLE
tristate "support for simple panels"
@@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE
config DRM_PANEL_LD9040
tristate "LD9040 RGB/SPI panel"
- depends on DRM && DRM_PANEL
depends on OF
select SPI
select VIDEOMODE_HELPERS
config DRM_PANEL_S6E8AA0
tristate "S6E8AA0 DSI video mode panel"
- depends on DRM && DRM_PANEL
depends on OF
select DRM_MIPI_DSI
select VIDEOMODE_HELPERS
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] drm/panel: remove unnecessary dependencies
@ 2014-06-12 16:09 ` Russell King
0 siblings, 0 replies; 6+ messages in thread
From: Russell King @ 2014-06-12 16:09 UTC (permalink / raw)
To: David Airlie, Thierry Reding; +Cc: Arnd Bergmann, linux-arm-kernel, dri-devel
DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
DRM_PANEL && DRM. This is nonsense for two reasons:
(a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
without DRM first being enabled. Hence the && DRM is useless.
(b) These two configs are already beneath a menu which depends on
DRM_PANEL being enabled; these options will not be visible without
DRM_PANEL already being enabled.
Let's just remove this unnecessary verbosity.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
drivers/gpu/drm/panel/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 4ec874da5668..d83958d39f43 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -5,7 +5,7 @@ config DRM_PANEL
Panel registration and lookup framework.
menu "Display Panels"
- depends on DRM_PANEL
+ depends on DRM && DRM_PANEL
config DRM_PANEL_SIMPLE
tristate "support for simple panels"
@@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE
config DRM_PANEL_LD9040
tristate "LD9040 RGB/SPI panel"
- depends on DRM && DRM_PANEL
depends on OF
select SPI
select VIDEOMODE_HELPERS
config DRM_PANEL_S6E8AA0
tristate "S6E8AA0 DSI video mode panel"
- depends on DRM && DRM_PANEL
depends on OF
select DRM_MIPI_DSI
select VIDEOMODE_HELPERS
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] drm/panel: remove unnecessary dependencies
2014-06-12 16:09 ` Russell King
@ 2014-06-13 5:54 ` Andrzej Hajda
-1 siblings, 0 replies; 6+ messages in thread
From: Andrzej Hajda @ 2014-06-13 5:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Russel,
Thanks for both fixes. Just one nitpick.
On 06/12/2014 06:09 PM, Russell King wrote:
> DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
> DRM_PANEL && DRM. This is nonsense for two reasons:
>
> (a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
> without DRM first being enabled. Hence the && DRM is useless.
This reason is invalid and do not describe the patch anymore.
Regards
Andrzej
>
> (b) These two configs are already beneath a menu which depends on
> DRM_PANEL being enabled; these options will not be visible without
> DRM_PANEL already being enabled.
>
> Let's just remove this unnecessary verbosity.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> drivers/gpu/drm/panel/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 4ec874da5668..d83958d39f43 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -5,7 +5,7 @@ config DRM_PANEL
> Panel registration and lookup framework.
>
> menu "Display Panels"
> - depends on DRM_PANEL
> + depends on DRM && DRM_PANEL
>
> config DRM_PANEL_SIMPLE
> tristate "support for simple panels"
> @@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE
>
> config DRM_PANEL_LD9040
> tristate "LD9040 RGB/SPI panel"
> - depends on DRM && DRM_PANEL
> depends on OF
> select SPI
> select VIDEOMODE_HELPERS
>
> config DRM_PANEL_S6E8AA0
> tristate "S6E8AA0 DSI video mode panel"
> - depends on DRM && DRM_PANEL
> depends on OF
> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] drm/panel: remove unnecessary dependencies
@ 2014-06-13 5:54 ` Andrzej Hajda
0 siblings, 0 replies; 6+ messages in thread
From: Andrzej Hajda @ 2014-06-13 5:54 UTC (permalink / raw)
To: Russell King, David Airlie, Thierry Reding
Cc: dri-devel, linux-arm-kernel, Arnd Bergmann
Hi Russel,
Thanks for both fixes. Just one nitpick.
On 06/12/2014 06:09 PM, Russell King wrote:
> DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
> DRM_PANEL && DRM. This is nonsense for two reasons:
>
> (a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
> without DRM first being enabled. Hence the && DRM is useless.
This reason is invalid and do not describe the patch anymore.
Regards
Andrzej
>
> (b) These two configs are already beneath a menu which depends on
> DRM_PANEL being enabled; these options will not be visible without
> DRM_PANEL already being enabled.
>
> Let's just remove this unnecessary verbosity.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> drivers/gpu/drm/panel/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 4ec874da5668..d83958d39f43 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -5,7 +5,7 @@ config DRM_PANEL
> Panel registration and lookup framework.
>
> menu "Display Panels"
> - depends on DRM_PANEL
> + depends on DRM && DRM_PANEL
>
> config DRM_PANEL_SIMPLE
> tristate "support for simple panels"
> @@ -18,14 +18,12 @@ config DRM_PANEL_SIMPLE
>
> config DRM_PANEL_LD9040
> tristate "LD9040 RGB/SPI panel"
> - depends on DRM && DRM_PANEL
> depends on OF
> select SPI
> select VIDEOMODE_HELPERS
>
> config DRM_PANEL_S6E8AA0
> tristate "S6E8AA0 DSI video mode panel"
> - depends on DRM && DRM_PANEL
> depends on OF
> select DRM_MIPI_DSI
> select VIDEOMODE_HELPERS
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] drm/panel: remove unnecessary dependencies
2014-06-13 5:54 ` Andrzej Hajda
@ 2014-06-13 13:06 ` Russell King - ARM Linux
-1 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2014-06-13 13:06 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jun 13, 2014 at 07:54:45AM +0200, Andrzej Hajda wrote:
> Hi Russel,
>
> Thanks for both fixes. Just one nitpick.
>
> On 06/12/2014 06:09 PM, Russell King wrote:
> > DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
> > DRM_PANEL && DRM. This is nonsense for two reasons:
> >
> > (a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
> > without DRM first being enabled. Hence the && DRM is useless.
>
> This reason is invalid and do not describe the patch anymore.
Thanks, expect v3 in your mailbox shortly (or already there.)
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] drm/panel: remove unnecessary dependencies
@ 2014-06-13 13:06 ` Russell King - ARM Linux
0 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2014-06-13 13:06 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: dri-devel, linux-arm-kernel, Arnd Bergmann
On Fri, Jun 13, 2014 at 07:54:45AM +0200, Andrzej Hajda wrote:
> Hi Russel,
>
> Thanks for both fixes. Just one nitpick.
>
> On 06/12/2014 06:09 PM, Russell King wrote:
> > DRM_PANEL_LD9040 and DRM_PANEL_S6E8AA0 both explicitly depended on
> > DRM_PANEL && DRM. This is nonsense for two reasons:
> >
> > (a) DRM_PANEL already depends on DRM, so DRM_PANEL can not be enabled
> > without DRM first being enabled. Hence the && DRM is useless.
>
> This reason is invalid and do not describe the patch anymore.
Thanks, expect v3 in your mailbox shortly (or already there.)
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-13 13:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-12 16:09 [PATCH v2 1/2] drm/panel: remove unnecessary dependencies Russell King
2014-06-12 16:09 ` Russell King
2014-06-13 5:54 ` Andrzej Hajda
2014-06-13 5:54 ` Andrzej Hajda
2014-06-13 13:06 ` Russell King - ARM Linux
2014-06-13 13:06 ` Russell King - ARM Linux
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.