[PATCH] mmc: sdhci: avoid double-delay while transitioning to 1.8V

[PATCH] mmc: sdhci: avoid double-delay while transitioning to 1.8V

[Russell King]

The MMC core in mmc_set_signal_voltage() already provides for the delay
required to switch to 1.8V, so there is no need for drivers to perform
this wait themselves.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
This patch was missed from the previous set because v2 was never sent.

 drivers/mmc/host/sdhci.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index d558f70756b0..3c8b91d3a793 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1762,9 +1762,6 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host,
 		ctrl |= SDHCI_CTRL_VDD_180;
 		sdhci_writew(host, ctrl, SDHCI_HOST_CONTROL2);
 
-		/* Wait for 5ms */
-		usleep_range(5000, 5500);
-
 		/* 1.8V regulator output should be stable within 5 ms */
 		ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2);
 		if (ctrl & SDHCI_CTRL_VDD_180)
-- 
1.8.3.1

Re: [PATCH] mmc: sdhci: avoid double-delay while transitioning to 1.8V

[Ulf Hansson]

On 26 June 2014 16:50, Russell King <rmk+kernel@arm.linux.org.uk> wrote:
> The MMC core in mmc_set_signal_voltage() already provides for the delay
> required to switch to 1.8V, so there is no need for drivers to perform
> this wait themselves.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

Thanks! Applied for next.

Kind regards
Uffe

> ---
> This patch was missed from the previous set because v2 was never sent.
>
>  drivers/mmc/host/sdhci.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index d558f70756b0..3c8b91d3a793 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1762,9 +1762,6 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host,
>                 ctrl |= SDHCI_CTRL_VDD_180;
>                 sdhci_writew(host, ctrl, SDHCI_HOST_CONTROL2);
>
> -               /* Wait for 5ms */
> -               usleep_range(5000, 5500);
> -
>                 /* 1.8V regulator output should be stable within 5 ms */
>                 ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2);
>                 if (ctrl & SDHCI_CTRL_VDD_180)
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html