All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: da7218: fix boolreturn.cocci warnings
  2015-11-30 18:40 [asoc:topic/da7218 2/2] sound/soc/codecs/da7218.c:3214:9-10: WARNING: return of 0/1 in function 'da7218_volatile_register' with return type bool kbuild test robot
@ 2015-11-30 18:40   ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2015-11-30 18:40 UTC (permalink / raw)
  To: Adam Thomson
  Cc: kbuild-all, alsa-devel, Mark Brown, Support Opensource,
	Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel

sound/soc/codecs/da7218.c:3214:9-10: WARNING: return of 0/1 in function 'da7218_volatile_register' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 da7218.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/sound/soc/codecs/da7218.c
+++ b/sound/soc/codecs/da7218.c
@@ -3211,9 +3211,9 @@ static bool da7218_volatile_register(str
 	case DA7218_HPLDET_TEST:
 	case DA7218_EVENT_STATUS:
 	case DA7218_EVENT:
-		return 1;
+		return true;
 	default:
-		return 0;
+		return false;
 	}
 }
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [asoc:topic/da7218 2/2] sound/soc/codecs/da7218.c:3214:9-10: WARNING: return of 0/1 in function 'da7218_volatile_register' with return type bool
@ 2015-11-30 18:40 kbuild test robot
  2015-11-30 18:40   ` kbuild test robot
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2015-11-30 18:40 UTC (permalink / raw)
  To: Adam Thomson; +Cc: alsa-devel, Mark Brown, kbuild-all

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/da7218
head:   4d50934abd2261fd467320d52c470efff309fd74
commit: 4d50934abd2261fd467320d52c470efff309fd74 [2/2] ASoC: da7218: Add da7218 codec driver


coccinelle warnings: (new ones prefixed by >>)

>> sound/soc/codecs/da7218.c:3214:9-10: WARNING: return of 0/1 in function 'da7218_volatile_register' with return type bool

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ASoC: da7218: fix boolreturn.cocci warnings
@ 2015-11-30 18:40   ` kbuild test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2015-11-30 18:40 UTC (permalink / raw)
  To: Adam Thomson
  Cc: alsa-devel, Support Opensource, linux-kernel, Takashi Iwai,
	Liam Girdwood, Mark Brown, kbuild-all

sound/soc/codecs/da7218.c:3214:9-10: WARNING: return of 0/1 in function 'da7218_volatile_register' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 da7218.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/sound/soc/codecs/da7218.c
+++ b/sound/soc/codecs/da7218.c
@@ -3211,9 +3211,9 @@ static bool da7218_volatile_register(str
 	case DA7218_HPLDET_TEST:
 	case DA7218_EVENT_STATUS:
 	case DA7218_EVENT:
-		return 1;
+		return true;
 	default:
-		return 0;
+		return false;
 	}
 }
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Applied "ASoC: da7218: fix boolreturn.cocci warnings" to the asoc tree
  2015-11-30 18:40   ` kbuild test robot
  (?)
@ 2015-12-01 22:59   ` Mark Brown
  -1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-12-01 22:59 UTC (permalink / raw)
  To: Fengguang Wu, Mark Brown; +Cc: alsa-devel

The patch

   ASoC: da7218: fix boolreturn.cocci warnings

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 112446aa2e1262c41fddfc664fa418ce2d615328 Mon Sep 17 00:00:00 2001
From: kbuild test robot <fengguang.wu@intel.com>
Date: Tue, 1 Dec 2015 02:40:51 +0800
Subject: [PATCH] ASoC: da7218: fix boolreturn.cocci warnings

sound/soc/codecs/da7218.c:3214:9-10: WARNING: return of 0/1 in function 'da7218_volatile_register' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/da7218.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c
index ed0c9a26065b..4fee7aeaadc7 100644
--- a/sound/soc/codecs/da7218.c
+++ b/sound/soc/codecs/da7218.c
@@ -3211,9 +3211,9 @@ static bool da7218_volatile_register(struct device *dev, unsigned int reg)
 	case DA7218_HPLDET_TEST:
 	case DA7218_EVENT_STATUS:
 	case DA7218_EVENT:
-		return 1;
+		return true;
 	default:
-		return 0;
+		return false;
 	}
 }
 
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-12-01 22:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-30 18:40 [asoc:topic/da7218 2/2] sound/soc/codecs/da7218.c:3214:9-10: WARNING: return of 0/1 in function 'da7218_volatile_register' with return type bool kbuild test robot
2015-11-30 18:40 ` [PATCH] ASoC: da7218: fix boolreturn.cocci warnings kbuild test robot
2015-11-30 18:40   ` kbuild test robot
2015-12-01 22:59   ` Applied "ASoC: da7218: fix boolreturn.cocci warnings" to the asoc tree Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.