From: rmk@armlinux.org.uk (Russell King) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] arm: fix kernel image size Date: Fri, 17 Jun 2016 20:44:42 +0100 [thread overview] Message-ID: <E1bDzh4-0006a4-7p@e0050434b2927.dyn.armlinux.org.uk> (raw) In-Reply-To: <20160617194405.GN1041@n2100.armlinux.org.uk> If we want to assume that the compressed image will expand by a maximum of 4x, we actually need to reserve 5x the space, since we need to keep a copy of the compessed image around while decompressing. Signed-off-by: Russell King <rmk@armlinux.org.uk> --- kexec/arch/arm/kexec-zImage-arm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kexec/arch/arm/kexec-zImage-arm.c b/kexec/arch/arm/kexec-zImage-arm.c index 297b7fd8..9400d1f4 100644 --- a/kexec/arch/arm/kexec-zImage-arm.c +++ b/kexec/arch/arm/kexec-zImage-arm.c @@ -526,8 +526,10 @@ int zImage_arm_load(int argc, char **argv, const char *buf, off_t len, initrd_base = kernel_base + _ALIGN(kexec_arm_image_size, getpagesize()); } else { /* Otherwise, assume the maximum kernel compression ratio - * is 4, and just to be safe, place ramdisk after that */ - initrd_base = kernel_base + _ALIGN(len * 4, getpagesize()); + * is 4, and just to be safe, place ramdisk after that. + * Note that we must include space for the compressed + * image here as well. */ + initrd_base = kernel_base + _ALIGN(len * 5, getpagesize()); } if (use_atags) { -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Russell King <rmk@armlinux.org.uk> To: Kees Cook <keescook@google.com>, Simon Horman <horms@verge.net.au>, Baoquan He <bhe@redhat.com>, Pratyush Anand <panand@redhat.com> Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] arm: fix kernel image size Date: Fri, 17 Jun 2016 20:44:42 +0100 [thread overview] Message-ID: <E1bDzh4-0006a4-7p@e0050434b2927.dyn.armlinux.org.uk> (raw) In-Reply-To: <20160617194405.GN1041@n2100.armlinux.org.uk> If we want to assume that the compressed image will expand by a maximum of 4x, we actually need to reserve 5x the space, since we need to keep a copy of the compessed image around while decompressing. Signed-off-by: Russell King <rmk@armlinux.org.uk> --- kexec/arch/arm/kexec-zImage-arm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kexec/arch/arm/kexec-zImage-arm.c b/kexec/arch/arm/kexec-zImage-arm.c index 297b7fd8..9400d1f4 100644 --- a/kexec/arch/arm/kexec-zImage-arm.c +++ b/kexec/arch/arm/kexec-zImage-arm.c @@ -526,8 +526,10 @@ int zImage_arm_load(int argc, char **argv, const char *buf, off_t len, initrd_base = kernel_base + _ALIGN(kexec_arm_image_size, getpagesize()); } else { /* Otherwise, assume the maximum kernel compression ratio - * is 4, and just to be safe, place ramdisk after that */ - initrd_base = kernel_base + _ALIGN(len * 4, getpagesize()); + * is 4, and just to be safe, place ramdisk after that. + * Note that we must include space for the compressed + * image here as well. */ + initrd_base = kernel_base + _ALIGN(len * 5, getpagesize()); } if (use_atags) { -- 1.9.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2016-06-17 19:44 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-17 19:44 [PATCH 0/2] Simple fix to the ARM kexec tools implementation Russell King - ARM Linux 2016-06-17 19:44 ` Russell King - ARM Linux 2016-06-17 19:44 ` [PATCH 1/2] arm: take account of TEXT_OFFSET for subsequent images Russell King 2016-06-17 19:44 ` Russell King 2016-06-17 19:44 ` Russell King [this message] 2016-06-17 19:44 ` [PATCH 2/2] arm: fix kernel image size Russell King [not found] ` <E1bDzh4-0006a4-7p-yeZebKftTXNiEPTqdM/vLBqCBvEC6TWiNEsB0oqw8pBaa/9Udqfwiw@public.gmane.org> 2016-06-21 7:43 ` Tony Lindgren 2016-06-21 7:43 ` Tony Lindgren 2016-06-21 7:43 ` Tony Lindgren [not found] ` <20160621074319.GH22406-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2016-06-21 9:47 ` Russell King - ARM Linux 2016-06-21 9:47 ` Russell King - ARM Linux 2016-06-21 9:47 ` Russell King - ARM Linux [not found] ` <20160621094737.GA5783-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2016-06-21 10:38 ` Tony Lindgren 2016-06-21 10:38 ` Tony Lindgren 2016-06-21 10:38 ` Tony Lindgren [not found] ` <20160621103810.GI22406-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2016-06-21 10:57 ` Tony Lindgren 2016-06-21 10:57 ` Tony Lindgren 2016-06-21 10:57 ` Tony Lindgren [not found] ` <20160621105720.GK22406-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2016-06-21 15:44 ` Russell King - ARM Linux 2016-06-21 15:44 ` Russell King - ARM Linux 2016-06-21 15:44 ` Russell King - ARM Linux [not found] ` <20160621154407.GB5783-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2016-06-21 16:55 ` Tony Lindgren 2016-06-21 16:55 ` Tony Lindgren 2016-06-21 16:55 ` Tony Lindgren [not found] ` <20160621165523.GY22406-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2016-06-21 21:51 ` Russell King - ARM Linux 2016-06-21 21:51 ` Russell King - ARM Linux 2016-06-21 21:51 ` Russell King - ARM Linux [not found] ` <20160621215141.GC5783-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2016-06-22 7:36 ` Tony Lindgren 2016-06-22 7:36 ` Tony Lindgren 2016-06-22 7:36 ` Tony Lindgren [not found] ` <20160622073614.GZ22406-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2016-06-22 8:29 ` Russell King - ARM Linux 2016-06-22 8:29 ` Russell King - ARM Linux 2016-06-22 8:29 ` Russell King - ARM Linux [not found] ` <20160622082958.GD5783-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> 2016-06-22 8:51 ` Tony Lindgren 2016-06-22 8:51 ` Tony Lindgren 2016-06-22 8:51 ` Tony Lindgren 2016-06-21 11:02 ` Mason 2016-06-21 6:11 ` [PATCH 0/2] Simple fix to the ARM kexec tools implementation Pratyush Anand 2016-06-21 6:11 ` Pratyush Anand 2016-06-21 8:20 ` Russell King - ARM Linux 2016-06-21 8:20 ` Russell King - ARM Linux 2016-06-23 0:41 ` Simon Horman 2016-06-23 0:41 ` Simon Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E1bDzh4-0006a4-7p@e0050434b2927.dyn.armlinux.org.uk \ --to=rmk@armlinux.org.uk \ --cc=linux-arm-kernel@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.