All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: es8316: add I2C dependency
@ 2017-06-21 22:09 ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-06-21 22:09 UTC (permalink / raw)
  To: Mark Brown
  Cc: Daniel Drake, David Yang, Arnd Bergmann, Liam Girdwood,
	alsa-devel, linux-kernel

Without CONFIG_I2C, we get a build failure:

sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]

This adds the required Kconfig dependency.

Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c6286e5ba511..f0f794186186 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -546,6 +546,7 @@ config SND_SOC_ES7134
 
 config SND_SOC_ES8316
 	tristate "Everest Semi ES8316 CODEC"
+	depends on I2C
 
 config SND_SOC_ES8328
 	tristate
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] ASoC: es8316: add I2C dependency
@ 2017-06-21 22:09 ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2017-06-21 22:09 UTC (permalink / raw)
  To: Mark Brown
  Cc: alsa-devel, Arnd Bergmann, Liam Girdwood, linux-kernel,
	Daniel Drake, David Yang

Without CONFIG_I2C, we get a build failure:

sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]

This adds the required Kconfig dependency.

Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c6286e5ba511..f0f794186186 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -546,6 +546,7 @@ config SND_SOC_ES7134
 
 config SND_SOC_ES8316
 	tristate "Everest Semi ES8316 CODEC"
+	depends on I2C
 
 config SND_SOC_ES8328
 	tristate
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: es8316: add I2C dependency
  2017-06-21 22:09 ` Arnd Bergmann
  (?)
@ 2017-06-22 13:14 ` Daniel Drake
  -1 siblings, 0 replies; 5+ messages in thread
From: Daniel Drake @ 2017-06-22 13:14 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Mark Brown, David Yang, Liam Girdwood, alsa-devel, Linux Kernel

On Wed, Jun 21, 2017 at 4:09 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Without CONFIG_I2C, we get a build failure:
>
> sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
> sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
> sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]
>
> This adds the required Kconfig dependency.
>
> Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Daniel Drake <drake@endlessm.com>

Thanks for the patch.

> ---
>  sound/soc/codecs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index c6286e5ba511..f0f794186186 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -546,6 +546,7 @@ config SND_SOC_ES7134
>
>  config SND_SOC_ES8316
>         tristate "Everest Semi ES8316 CODEC"
> +       depends on I2C
>
>  config SND_SOC_ES8328
>         tristate
> --
> 2.9.0
>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Applied "ASoC: es8316: add I2C dependency" to the asoc tree
  2017-06-21 22:09 ` Arnd Bergmann
@ 2017-06-22 14:18   ` Mark Brown
  -1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-06-22 14:18 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Mark Brown, Mark Brown, alsa-devel, Liam Girdwood, linux-kernel,
	Daniel Drake, David Yang, alsa-devel

The patch

   ASoC: es8316: add I2C dependency

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 664d00d187608c66904e62ff2f24e7df49611ba5 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 22 Jun 2017 00:09:23 +0200
Subject: [PATCH] ASoC: es8316: add I2C dependency

Without CONFIG_I2C, we get a build failure:

sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]

This adds the required Kconfig dependency.

Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c6286e5ba511..f0f794186186 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -546,6 +546,7 @@ config SND_SOC_ES7134
 
 config SND_SOC_ES8316
 	tristate "Everest Semi ES8316 CODEC"
+	depends on I2C
 
 config SND_SOC_ES8328
 	tristate
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Applied "ASoC: es8316: add I2C dependency" to the asoc tree
@ 2017-06-22 14:18   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-06-22 14:18 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Mark Brown

The patch

   ASoC: es8316: add I2C dependency

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 664d00d187608c66904e62ff2f24e7df49611ba5 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 22 Jun 2017 00:09:23 +0200
Subject: [PATCH] ASoC: es8316: add I2C dependency

Without CONFIG_I2C, we get a build failure:

sound/soc/codecs/es8316.c:633:1: error: data definition has no type or storage class [-Werror]
sound/soc/codecs/es8316.c:633:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/es8316.c:633:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/es8316.c:623:26: error: 'es8316_i2c_driver' defined but not used [-Werror=unused-variable]

This adds the required Kconfig dependency.

Fixes: b8b88b70875a ("ASoC: add es8316 codec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c6286e5ba511..f0f794186186 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -546,6 +546,7 @@ config SND_SOC_ES7134
 
 config SND_SOC_ES8316
 	tristate "Everest Semi ES8316 CODEC"
+	depends on I2C
 
 config SND_SOC_ES8328
 	tristate
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-22 14:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-21 22:09 [PATCH] ASoC: es8316: add I2C dependency Arnd Bergmann
2017-06-21 22:09 ` Arnd Bergmann
2017-06-22 13:14 ` Daniel Drake
2017-06-22 14:18 ` Applied "ASoC: es8316: add I2C dependency" to the asoc tree Mark Brown
2017-06-22 14:18   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.