[U-Boot] [PATCH] rockchip: rk3288: Add support for drive-strength in PINCTRL

[U-Boot] [PATCH] rockchip: rk3288: Add support for drive-strength in PINCTRL

[Romain Perier]

Currently, drive-strenght to 12ma are described and supposed to be used
on RK3288. However, the pinctrl driver for this SoC only handles muxing
and pull up/pull down via PU/PD control registers. So complex IPs like
GMAC are working in normal ethernet 100mbps, but not at 1gbps typically.

This commit adds support for handling drive-strength of 12ma, when it's
defined in the DT.

Signed-off-by: Romain Perier <romain.perier@collabora.com>
---
 drivers/pinctrl/rockchip/pinctrl_rk3288.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/rockchip/pinctrl_rk3288.c b/drivers/pinctrl/rockchip/pinctrl_rk3288.c
index 47cefc5abf..a21b64044b 100644
--- a/drivers/pinctrl/rockchip/pinctrl_rk3288.c
+++ b/drivers/pinctrl/rockchip/pinctrl_rk3288.c
@@ -729,7 +729,7 @@ static int rk3288_pinctrl_set_pins(struct udevice *dev, int banknum, int index,
 	value |= (mask << (shift + 16)) | (muxval << shift);
 	writel(value, addr);
 
-	/* Handle pullup/pulldown */
+	/* Handle pullup/pulldown/drive-strength */
 	if (flags) {
 		uint val = 0;
 
@@ -737,10 +737,15 @@ static int rk3288_pinctrl_set_pins(struct udevice *dev, int banknum, int index,
 			val = 1;
 		else if (flags & (1 << PIN_CONFIG_BIAS_PULL_DOWN))
 			val = 2;
+		else if (flags & (1 << PIN_CONFIG_DRIVE_STRENGTH))
+			val = 3;
+
 		shift = (index & 7) * 2;
 		ind = index >> 3;
 		if (banknum == 0)
 			addr = &priv->pmu->gpio0pull[ind];
+		else if (flags & (1 << PIN_CONFIG_DRIVE_STRENGTH))
+			addr = &priv->grf->gpio1_e[banknum - 1][ind];
 		else
 			addr = &priv->grf->gpio1_p[banknum - 1][ind];
 		debug("%s: addr=%p, val=%x, shift=%x\n", __func__, addr, val,
@@ -779,6 +784,9 @@ static int rk3288_pinctrl_set_state(struct udevice *dev, struct udevice *config)
 		if (flags < 0)
 			return flags;
 
+		if (fdtdec_get_int(blob, pcfg_node, "drive-strength", 0) == 12)
+			flags |= 1 << PIN_CONFIG_DRIVE_STRENGTH;
+
 		ret = rk3288_pinctrl_set_pins(dev, ptr[0], ptr[1], ptr[2],
 					      flags);
 		if (ret)
-- 
2.11.0

[U-Boot] rockchip: rk3288: Add support for drive-strength in PINCTRL

[Philipp Tomsich]

> Currently, drive-strenght to 12ma are described and supposed to be used
> on RK3288. However, the pinctrl driver for this SoC only handles muxing
> and pull up/pull down via PU/PD control registers. So complex IPs like
> GMAC are working in normal ethernet 100mbps, but not at 1gbps typically.
> 
> This commit adds support for handling drive-strength of 12ma, when it's
> defined in the DT.
> 
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> ---
>  drivers/pinctrl/rockchip/pinctrl_rk3288.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] rockchip: rk3288: Add support for drive-strength in PINCTRL

[Philipp Tomsich]

> Currently, drive-strenght to 12ma are described and supposed to be used
> on RK3288. However, the pinctrl driver for this SoC only handles muxing
> and pull up/pull down via PU/PD control registers. So complex IPs like
> GMAC are working in normal ethernet 100mbps, but not at 1gbps typically.
> 
> This commit adds support for handling drive-strength of 12ma, when it's
> defined in the DT.
> 
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  drivers/pinctrl/rockchip/pinctrl_rk3288.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

[U-Boot] rockchip: rk3288: Add support for drive-strength in PINCTRL

[Philipp Tomsich]

> Currently, drive-strenght to 12ma are described and supposed to be used
> on RK3288. However, the pinctrl driver for this SoC only handles muxing
> and pull up/pull down via PU/PD control registers. So complex IPs like
> GMAC are working in normal ethernet 100mbps, but not at 1gbps typically.
> 
> This commit adds support for handling drive-strength of 12ma, when it's
> defined in the DT.
> 
> Signed-off-by: Romain Perier <romain.perier@collabora.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>  drivers/pinctrl/rockchip/pinctrl_rk3288.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Applied to u-boot-rockchip, thanks!