* [U-Boot] [PATCH 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET
@ 2017-09-27 18:23 Heinrich Schuchardt
2017-09-29 16:15 ` [U-Boot] [U-Boot, " Philipp Tomsich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2017-09-27 18:23 UTC (permalink / raw)
To: u-boot
CONFIG_ENV_OFFSET is already defined in
include/configs/rockchip-common.h
For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET
to an unsuitable value. We were lucky to get a compiler warning.
Remove the incorrect redefinition.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
include/configs/evb_rk3399.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h
index 015f25a774..66ead6c117 100644
--- a/include/configs/evb_rk3399.h
+++ b/include/configs/evb_rk3399.h
@@ -10,12 +10,6 @@
#include <configs/rk3399_common.h>
#define CONFIG_SYS_MMC_ENV_DEV 1
-/*
- * SPL @ 32k for ~36k
- * ENV @ 96k
- * u-boot @ 128K
- */
-#define CONFIG_ENV_OFFSET (96 * 1024)
#define SDRAM_BANK_SIZE (2UL << 30)
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot, 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET
2017-09-27 18:23 [U-Boot] [PATCH 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET Heinrich Schuchardt
@ 2017-09-29 16:15 ` Philipp Tomsich
2017-09-29 16:15 ` Philipp Tomsich
2017-09-29 16:44 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2017-09-29 16:15 UTC (permalink / raw)
To: u-boot
> CONFIG_ENV_OFFSET is already defined in
> include/configs/rockchip-common.h
>
> For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET
> to an unsuitable value. We were lucky to get a compiler warning.
>
> Remove the incorrect redefinition.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/configs/evb_rk3399.h | 6 ------
> 1 file changed, 6 deletions(-)
>
Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot, 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET
2017-09-27 18:23 [U-Boot] [PATCH 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET Heinrich Schuchardt
2017-09-29 16:15 ` [U-Boot] [U-Boot, " Philipp Tomsich
@ 2017-09-29 16:15 ` Philipp Tomsich
2017-09-29 16:44 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2017-09-29 16:15 UTC (permalink / raw)
To: u-boot
> CONFIG_ENV_OFFSET is already defined in
> include/configs/rockchip-common.h
>
> For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET
> to an unsuitable value. We were lucky to get a compiler warning.
>
> Remove the incorrect redefinition.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/configs/evb_rk3399.h | 6 ------
> 1 file changed, 6 deletions(-)
>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [U-Boot, 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET
2017-09-27 18:23 [U-Boot] [PATCH 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET Heinrich Schuchardt
2017-09-29 16:15 ` [U-Boot] [U-Boot, " Philipp Tomsich
2017-09-29 16:15 ` Philipp Tomsich
@ 2017-09-29 16:44 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2017-09-29 16:44 UTC (permalink / raw)
To: u-boot
> CONFIG_ENV_OFFSET is already defined in
> include/configs/rockchip-common.h
>
> For CONFIG_ROCKCHIP_BACK_TO_BROM=y we redefine CONFIG_ENV_OFFSET
> to an unsuitable value. We were lucky to get a compiler warning.
>
> Remove the incorrect redefinition.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> include/configs/evb_rk3399.h | 6 ------
> 1 file changed, 6 deletions(-)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-29 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-27 18:23 [U-Boot] [PATCH 1/1] evb-rk3399: avoid redefinition of CONFIG_ENV_OFFSET Heinrich Schuchardt
2017-09-29 16:15 ` [U-Boot] [U-Boot, " Philipp Tomsich
2017-09-29 16:15 ` Philipp Tomsich
2017-09-29 16:44 ` Philipp Tomsich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.