* [PATCH] ASoC: tfa9879: Export OF device ID as module alias
@ 2017-11-30 17:56 Javier Martinez Canillas
2017-11-30 18:56 ` Peter Rosin
2017-12-01 13:44 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Javier Martinez Canillas @ 2017-11-30 17:56 UTC (permalink / raw)
To: linux-kernel
Cc: Fabio Estevam, Javier Martinez Canillas, Jaroslav Kysela,
alsa-devel, Mark Brown, Takashi Iwai, Liam Girdwood, Peter Rosin
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Before this patch:
$ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
alias: i2c:tfa9879
After this patch:
$ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
alias: i2c:tfa9879
alias: of:N*T*Cnxp,tfa9879C*
alias: of:N*T*Cnxp,tfa9879
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
sound/soc/codecs/tfa9879.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
index f8dd67ca0744..e7ca764b5729 100644
--- a/sound/soc/codecs/tfa9879.c
+++ b/sound/soc/codecs/tfa9879.c
@@ -316,6 +316,7 @@ static const struct of_device_id tfa9879_of_match[] = {
{ .compatible = "nxp,tfa9879", },
{ }
};
+MODULE_DEVICE_TABLE(of, tfa9879_of_match);
static struct i2c_driver tfa9879_i2c_driver = {
.driver = {
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: tfa9879: Export OF device ID as module alias
2017-11-30 17:56 [PATCH] ASoC: tfa9879: Export OF device ID as module alias Javier Martinez Canillas
@ 2017-11-30 18:56 ` Peter Rosin
2017-12-01 13:44 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Peter Rosin @ 2017-11-30 18:56 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Fabio Estevam, Jaroslav Kysela, alsa-devel, Mark Brown,
Takashi Iwai, Liam Girdwood
On 2017-11-30 18:56, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
Looks ok to me,
Reviewed-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
> Before this patch:
>
> $ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
> alias: i2c:tfa9879
>
> After this patch:
>
> $ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
> alias: i2c:tfa9879
> alias: of:N*T*Cnxp,tfa9879C*
> alias: of:N*T*Cnxp,tfa9879
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> ---
>
> sound/soc/codecs/tfa9879.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
> index f8dd67ca0744..e7ca764b5729 100644
> --- a/sound/soc/codecs/tfa9879.c
> +++ b/sound/soc/codecs/tfa9879.c
> @@ -316,6 +316,7 @@ static const struct of_device_id tfa9879_of_match[] = {
> { .compatible = "nxp,tfa9879", },
> { }
> };
> +MODULE_DEVICE_TABLE(of, tfa9879_of_match);
>
> static struct i2c_driver tfa9879_i2c_driver = {
> .driver = {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: tfa9879: Export OF device ID as module alias
@ 2017-11-30 18:56 ` Peter Rosin
0 siblings, 0 replies; 5+ messages in thread
From: Peter Rosin @ 2017-11-30 18:56 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: alsa-devel, Liam Girdwood, Takashi Iwai, Mark Brown, Fabio Estevam
On 2017-11-30 18:56, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
Looks ok to me,
Reviewed-by: Peter Rosin <peda@axentia.se>
Cheers,
Peter
> Before this patch:
>
> $ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
> alias: i2c:tfa9879
>
> After this patch:
>
> $ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
> alias: i2c:tfa9879
> alias: of:N*T*Cnxp,tfa9879C*
> alias: of:N*T*Cnxp,tfa9879
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> ---
>
> sound/soc/codecs/tfa9879.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
> index f8dd67ca0744..e7ca764b5729 100644
> --- a/sound/soc/codecs/tfa9879.c
> +++ b/sound/soc/codecs/tfa9879.c
> @@ -316,6 +316,7 @@ static const struct of_device_id tfa9879_of_match[] = {
> { .compatible = "nxp,tfa9879", },
> { }
> };
> +MODULE_DEVICE_TABLE(of, tfa9879_of_match);
>
> static struct i2c_driver tfa9879_i2c_driver = {
> .driver = {
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "ASoC: tfa9879: Export OF device ID as module alias" to the asoc tree
2017-11-30 17:56 [PATCH] ASoC: tfa9879: Export OF device ID as module alias Javier Martinez Canillas
@ 2017-12-01 13:44 ` Mark Brown
2017-12-01 13:44 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-12-01 13:44 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Mark Brown, linux-kernel, alsa-devel, Liam Girdwood,
Takashi Iwai, Mark Brown, Fabio Estevam, Peter Rosin, alsa-devel
The patch
ASoC: tfa9879: Export OF device ID as module alias
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 56ae83f11db58a3a62d0d309efb84544f2c02e3b Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javierm@redhat.com>
Date: Thu, 30 Nov 2017 18:56:16 +0100
Subject: [PATCH] ASoC: tfa9879: Export OF device ID as module alias
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Before this patch:
$ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
alias: i2c:tfa9879
After this patch:
$ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
alias: i2c:tfa9879
alias: of:N*T*Cnxp,tfa9879C*
alias: of:N*T*Cnxp,tfa9879
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/tfa9879.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
index f8dd67ca0744..e7ca764b5729 100644
--- a/sound/soc/codecs/tfa9879.c
+++ b/sound/soc/codecs/tfa9879.c
@@ -316,6 +316,7 @@ static const struct of_device_id tfa9879_of_match[] = {
{ .compatible = "nxp,tfa9879", },
{ }
};
+MODULE_DEVICE_TABLE(of, tfa9879_of_match);
static struct i2c_driver tfa9879_i2c_driver = {
.driver = {
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "ASoC: tfa9879: Export OF device ID as module alias" to the asoc tree
@ 2017-12-01 13:44 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-12-01 13:44 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Mark Brown, linux-kernel, alsa-devel, Liam Girdwood, Takashi Iwai
The patch
ASoC: tfa9879: Export OF device ID as module alias
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 56ae83f11db58a3a62d0d309efb84544f2c02e3b Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javierm@redhat.com>
Date: Thu, 30 Nov 2017 18:56:16 +0100
Subject: [PATCH] ASoC: tfa9879: Export OF device ID as module alias
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Before this patch:
$ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
alias: i2c:tfa9879
After this patch:
$ modinfo sound/soc/codecs/snd-soc-tfa9879.ko | grep alias
alias: i2c:tfa9879
alias: of:N*T*Cnxp,tfa9879C*
alias: of:N*T*Cnxp,tfa9879
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/tfa9879.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
index f8dd67ca0744..e7ca764b5729 100644
--- a/sound/soc/codecs/tfa9879.c
+++ b/sound/soc/codecs/tfa9879.c
@@ -316,6 +316,7 @@ static const struct of_device_id tfa9879_of_match[] = {
{ .compatible = "nxp,tfa9879", },
{ }
};
+MODULE_DEVICE_TABLE(of, tfa9879_of_match);
static struct i2c_driver tfa9879_i2c_driver = {
.driver = {
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-01 13:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-30 17:56 [PATCH] ASoC: tfa9879: Export OF device ID as module alias Javier Martinez Canillas
2017-11-30 18:56 ` Peter Rosin
2017-11-30 18:56 ` Peter Rosin
2017-12-01 13:44 ` Applied "ASoC: tfa9879: Export OF device ID as module alias" to the asoc tree Mark Brown
2017-12-01 13:44 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.