[PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

[PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

[kbuild test robot]

From: Fengguang Wu <fengguang.wu@intel.com>

sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
CC: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 rt1305.c |    1 -
 1 file changed, 1 deletion(-)

--- a/sound/soc/codecs/rt1305.c
+++ b/sound/soc/codecs/rt1305.c
@@ -1171,7 +1171,6 @@ static void rt1305_i2c_shutdown(struct i
 static struct i2c_driver rt1305_i2c_driver = {
 	.driver = {
 		.name = "rt1305",
-		.owner = THIS_MODULE,
 #if defined(CONFIG_OF)
 		.of_match_table = rt1305_of_match,
 #endif

[asoc:for-4.18 35/37] sound/soc/codecs/rt1305.c:1179:23: error: implicit declaration of function 'ACPI_PTR'; did you mean 'ERR_PTR'?

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2233 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-4.18
head:   fbeabd09236664f34ea3e4a9f7dcf5a0cdb7fc47
commit: 29bc643ddd7efb741d07c8b2d9a4c3dd9228865b [35/37] ASoC: rt1305: Add RT1305/RT1306 amplifier driver
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 29bc643ddd7efb741d07c8b2d9a4c3dd9228865b
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

>> sound/soc/codecs/rt1305.c:1179:23: error: implicit declaration of function 'ACPI_PTR'; did you mean 'ERR_PTR'? [-Werror=implicit-function-declaration]
      .acpi_match_table = ACPI_PTR(rt1305_acpi_match)
                          ^~~~~~~~
                          ERR_PTR
>> sound/soc/codecs/rt1305.c:1179:23: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
   sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')
>> sound/soc/codecs/rt1305.c:1179:23: error: initializer element is not constant
   sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for 'rt1305_i2c_driver.driver.acpi_match_table')
   cc1: some warnings being treated as errors

coccinelle warnings: (new ones prefixed by >>)

>> sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

Please review and possibly fold the followup patch.

vim +1179 sound/soc/codecs/rt1305.c

  1169	
  1170	
  1171	static struct i2c_driver rt1305_i2c_driver = {
  1172		.driver = {
  1173			.name = "rt1305",
> 1174			.owner = THIS_MODULE,
  1175	#if defined(CONFIG_OF)
  1176			.of_match_table = rt1305_of_match,
  1177	#endif
  1178	#if defined(CONFIG_ACPI)
> 1179			.acpi_match_table = ACPI_PTR(rt1305_acpi_match)
  1180	#endif
  1181		},
  1182		.probe = rt1305_i2c_probe,
  1183		.remove   = rt1305_i2c_remove,
  1184		.shutdown = rt1305_i2c_shutdown,
  1185		.id_table = rt1305_i2c_id,
  1186	};
  1187	module_i2c_driver(rt1305_i2c_driver);
  1188	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62937 bytes --]

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]

Applied "ASoC: rt1305: fix platform_no_drv_owner.cocci warnings" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b999a19b3324ae3538bc13d11210bdfc8016616a Mon Sep 17 00:00:00 2001
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Tue, 17 Apr 2018 03:41:24 +0800
Subject: [PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
CC: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt1305.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt1305.c b/sound/soc/codecs/rt1305.c
index 84043068c0b7..f4c8c45f4010 100644
--- a/sound/soc/codecs/rt1305.c
+++ b/sound/soc/codecs/rt1305.c
@@ -1172,7 +1172,6 @@ static void rt1305_i2c_shutdown(struct i2c_client *client)
 static struct i2c_driver rt1305_i2c_driver = {
 	.driver = {
 		.name = "rt1305",
-		.owner = THIS_MODULE,
 #if defined(CONFIG_OF)
 		.of_match_table = rt1305_of_match,
 #endif
-- 
2.17.0

Applied "ASoC: rt1305: fix platform_no_drv_owner.cocci warnings" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b999a19b3324ae3538bc13d11210bdfc8016616a Mon Sep 17 00:00:00 2001
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Tue, 17 Apr 2018 03:41:24 +0800
Subject: [PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
CC: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt1305.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt1305.c b/sound/soc/codecs/rt1305.c
index 84043068c0b7..f4c8c45f4010 100644
--- a/sound/soc/codecs/rt1305.c
+++ b/sound/soc/codecs/rt1305.c
@@ -1172,7 +1172,6 @@ static void rt1305_i2c_shutdown(struct i2c_client *client)
 static struct i2c_driver rt1305_i2c_driver = {
 	.driver = {
 		.name = "rt1305",
-		.owner = THIS_MODULE,
 #if defined(CONFIG_OF)
 		.of_match_table = rt1305_of_match,
 #endif
-- 
2.17.0

Applied "ASoC: rt1305: fix platform_no_drv_owner.cocci warnings" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b999a19b3324ae3538bc13d11210bdfc8016616a Mon Sep 17 00:00:00 2001
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Tue, 17 Apr 2018 03:41:24 +0800
Subject: [PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
CC: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt1305.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt1305.c b/sound/soc/codecs/rt1305.c
index 84043068c0b7..f4c8c45f4010 100644
--- a/sound/soc/codecs/rt1305.c
+++ b/sound/soc/codecs/rt1305.c
@@ -1172,7 +1172,6 @@ static void rt1305_i2c_shutdown(struct i2c_client *client)
 static struct i2c_driver rt1305_i2c_driver = {
 	.driver = {
 		.name = "rt1305",
-		.owner = THIS_MODULE,
 #if defined(CONFIG_OF)
 		.of_match_table = rt1305_of_match,
 #endif
-- 
2.17.0

Applied "ASoC: rt1305: fix platform_no_drv_owner.cocci warnings" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b999a19b3324ae3538bc13d11210bdfc8016616a Mon Sep 17 00:00:00 2001
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Tue, 17 Apr 2018 03:41:24 +0800
Subject: [PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
CC: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt1305.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt1305.c b/sound/soc/codecs/rt1305.c
index 84043068c0b7..f4c8c45f4010 100644
--- a/sound/soc/codecs/rt1305.c
+++ b/sound/soc/codecs/rt1305.c
@@ -1172,7 +1172,6 @@ static void rt1305_i2c_shutdown(struct i2c_client *client)
 static struct i2c_driver rt1305_i2c_driver = {
 	.driver = {
 		.name = "rt1305",
-		.owner = THIS_MODULE,
 #if defined(CONFIG_OF)
 		.of_match_table = rt1305_of_match,
 #endif
-- 
2.17.0

Applied "ASoC: rt1305: fix platform_no_drv_owner.cocci warnings" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b999a19b3324ae3538bc13d11210bdfc8016616a Mon Sep 17 00:00:00 2001
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Tue, 17 Apr 2018 03:41:24 +0800
Subject: [PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
CC: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt1305.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt1305.c b/sound/soc/codecs/rt1305.c
index 84043068c0b7..f4c8c45f4010 100644
--- a/sound/soc/codecs/rt1305.c
+++ b/sound/soc/codecs/rt1305.c
@@ -1172,7 +1172,6 @@ static void rt1305_i2c_shutdown(struct i2c_client *client)
 static struct i2c_driver rt1305_i2c_driver = {
 	.driver = {
 		.name = "rt1305",
-		.owner = THIS_MODULE,
 #if defined(CONFIG_OF)
 		.of_match_table = rt1305_of_match,
 #endif
-- 
2.17.0

Applied "ASoC: rt1305: fix platform_no_drv_owner.cocci warnings" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b999a19b3324ae3538bc13d11210bdfc8016616a Mon Sep 17 00:00:00 2001
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Tue, 17 Apr 2018 03:41:24 +0800
Subject: [PATCH] ASoC: rt1305: fix platform_no_drv_owner.cocci warnings

sound/soc/codecs/rt1305.c:1174:3-8: No need to set .owner here. The core will do it.

 Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: 29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
CC: Shuming Fan <shumingf@realtek.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt1305.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt1305.c b/sound/soc/codecs/rt1305.c
index 84043068c0b7..f4c8c45f4010 100644
--- a/sound/soc/codecs/rt1305.c
+++ b/sound/soc/codecs/rt1305.c
@@ -1172,7 +1172,6 @@ static void rt1305_i2c_shutdown(struct i2c_client *client)
 static struct i2c_driver rt1305_i2c_driver = {
 	.driver = {
 		.name = "rt1305",
-		.owner = THIS_MODULE,
 #if defined(CONFIG_OF)
 		.of_match_table = rt1305_of_match,
 #endif
-- 
2.17.0