* [U-Boot] [PATCH] Revert "rockchip: firefly: Add "usb start" to auto-start USB device"
@ 2018-04-18 10:01 Kever Yang
2018-04-25 10:29 ` [U-Boot] " Philipp Tomsich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kever Yang @ 2018-04-18 10:01 UTC (permalink / raw)
To: u-boot
This reverts commit a1903c18db13e740e6bedb8955b3272dce5104e1.
It's really bad idea to add "usb start" in preboot, it will spend
a lot of time to scan usb bus, and most of people do not need this
feature.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---
include/configs/firefly-rk3288.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/configs/firefly-rk3288.h b/include/configs/firefly-rk3288.h
index d6bb9f6..2b0ac9e 100644
--- a/include/configs/firefly-rk3288.h
+++ b/include/configs/firefly-rk3288.h
@@ -10,8 +10,7 @@
#define ROCKCHIP_DEVICE_SETTINGS \
"stdin=serial,usbkbd\0" \
"stdout=serial,vidconsole\0" \
- "stderr=serial,vidconsole\0" \
- "preboot=usb start\0"
+ "stderr=serial,vidconsole\0"
#include <configs/rk3288_common.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] Revert "rockchip: firefly: Add "usb start" to auto-start USB device"
2018-04-18 10:01 [U-Boot] [PATCH] Revert "rockchip: firefly: Add "usb start" to auto-start USB device" Kever Yang
@ 2018-04-25 10:29 ` Philipp Tomsich
2018-04-25 10:29 ` Philipp Tomsich
2018-04-26 7:05 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2018-04-25 10:29 UTC (permalink / raw)
To: u-boot
> This reverts commit a1903c18db13e740e6bedb8955b3272dce5104e1.
>
> It's really bad idea to add "usb start" in preboot, it will spend
> a lot of time to scan usb bus, and most of people do not need this
> feature.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> include/configs/firefly-rk3288.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] Revert "rockchip: firefly: Add "usb start" to auto-start USB device"
2018-04-18 10:01 [U-Boot] [PATCH] Revert "rockchip: firefly: Add "usb start" to auto-start USB device" Kever Yang
2018-04-25 10:29 ` [U-Boot] " Philipp Tomsich
@ 2018-04-25 10:29 ` Philipp Tomsich
2018-04-26 7:05 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2018-04-25 10:29 UTC (permalink / raw)
To: u-boot
> This reverts commit a1903c18db13e740e6bedb8955b3272dce5104e1.
>
> It's really bad idea to add "usb start" in preboot, it will spend
> a lot of time to scan usb bus, and most of people do not need this
> feature.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> include/configs/firefly-rk3288.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] Revert "rockchip: firefly: Add "usb start" to auto-start USB device"
2018-04-18 10:01 [U-Boot] [PATCH] Revert "rockchip: firefly: Add "usb start" to auto-start USB device" Kever Yang
2018-04-25 10:29 ` [U-Boot] " Philipp Tomsich
2018-04-25 10:29 ` Philipp Tomsich
@ 2018-04-26 7:05 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2018-04-26 7:05 UTC (permalink / raw)
To: u-boot
> This reverts commit a1903c18db13e740e6bedb8955b3272dce5104e1.
>
> It's really bad idea to add "usb start" in preboot, it will spend
> a lot of time to scan usb bus, and most of people do not need this
> feature.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> include/configs/firefly-rk3288.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-26 7:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 10:01 [U-Boot] [PATCH] Revert "rockchip: firefly: Add "usb start" to auto-start USB device" Kever Yang
2018-04-25 10:29 ` [U-Boot] " Philipp Tomsich
2018-04-25 10:29 ` Philipp Tomsich
2018-04-26 7:05 ` Philipp Tomsich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.