All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
@ 2018-04-19  3:37 Kever Yang
  2018-04-19  3:37 ` [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550 Kever Yang
                   ` (3 more replies)
  0 siblings, 4 replies; 12+ messages in thread
From: Kever Yang @ 2018-04-19  3:37 UTC (permalink / raw)
  To: u-boot

All rockchip SoCs can use ns16550 driver, enable it for all
and set SYS_NS16550_MEM32 for all SoCs.

Version-changes: 2
- use imply instead of select

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v2: None

 arch/arm/Kconfig                  | 1 +
 arch/arm/mach-rockchip/Kconfig    | 1 -
 include/configs/rk3036_common.h   | 3 ---
 include/configs/rk3128_common.h   | 2 --
 include/configs/rk3188_common.h   | 2 --
 include/configs/rk322x_common.h   | 1 -
 include/configs/rk3288_common.h   | 2 --
 include/configs/rk3328_common.h   | 2 --
 include/configs/rk3368_common.h   | 2 --
 include/configs/rk3399_common.h   | 2 --
 include/configs/rockchip-common.h | 2 ++
 include/configs/rv1108_common.h   | 3 ---
 12 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 068ea1e..a90f870 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1199,6 +1199,7 @@ config ARCH_ROCKCHIP
 	imply TPL_SYSRESET
 	imply ADC
 	imply SARADC_ROCKCHIP
+	imply SYS_NS16550
 
 config TARGET_THUNDERX_88XX
 	bool "Support ThunderX 88xx"
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 55d3d5c..15b3ab5 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -103,7 +103,6 @@ config ROCKCHIP_RK3368
 	imply SPL_SERIAL_SUPPORT
 	imply TPL_SERIAL_SUPPORT
 	select DEBUG_UART_BOARD_INIT
-	select SYS_NS16550
 	help
 	  The Rockchip RK3368 is a ARM-based SoC with a octa-core (organised
 	  into a big and little cluster with 4 cores each) Cortex-A53 including
diff --git a/include/configs/rk3036_common.h b/include/configs/rk3036_common.h
index 7d83f81..effc74f 100644
--- a/include/configs/rk3036_common.h
+++ b/include/configs/rk3036_common.h
@@ -18,9 +18,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
 #define CONFIG_SYS_LOAD_ADDR		0x60800800
 #define CONFIG_SPL_STACK		0x10081fff
diff --git a/include/configs/rk3128_common.h b/include/configs/rk3128_common.h
index e7e137b..5643873 100644
--- a/include/configs/rk3128_common.h
+++ b/include/configs/rk3128_common.h
@@ -19,8 +19,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
 #define CONFIG_SYS_LOAD_ADDR		0x60800800
 
diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h
index e07facd..4f51f40 100644
--- a/include/configs/rk3188_common.h
+++ b/include/configs/rk3188_common.h
@@ -17,8 +17,6 @@
 #define CONFIG_SYS_MALLOC_LEN		(32 << 20)
 #define CONFIG_SYS_CBSIZE		1024
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #ifdef CONFIG_SPL_ROCKCHIP_BACK_TO_BROM
 /* Bootrom will load u-boot binary to 0x60000000 once return from SPL */
 #endif
diff --git a/include/configs/rk322x_common.h b/include/configs/rk322x_common.h
index 8f8a1ef..2549d41 100644
--- a/include/configs/rk322x_common.h
+++ b/include/configs/rk322x_common.h
@@ -18,7 +18,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550_MEM32
 #define CONFIG_SYS_INIT_SP_ADDR		0x60100000
 #define CONFIG_SYS_LOAD_ADDR		0x60800800
 #define CONFIG_SPL_STACK		0x10088000
diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
index 98cc9be..92ad203 100644
--- a/include/configs/rk3288_common.h
+++ b/include/configs/rk3288_common.h
@@ -19,8 +19,6 @@
 #define CONFIG_SYS_ARCH_TIMER
 #define CONFIG_SYS_HZ_CLOCK		24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #ifdef CONFIG_SPL_ROCKCHIP_BACK_TO_BROM
 /* Bootrom will load u-boot binary to 0x0 once return from SPL */
 #endif
diff --git a/include/configs/rk3328_common.h b/include/configs/rk3328_common.h
index 517d058..b6c3cc0 100644
--- a/include/configs/rk3328_common.h
+++ b/include/configs/rk3328_common.h
@@ -13,8 +13,6 @@
 #define CONFIG_SYS_CBSIZE		1024
 #define CONFIG_SKIP_LOWLEVEL_INIT
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x00300000
 #define CONFIG_SYS_LOAD_ADDR		0x00800800
 
diff --git a/include/configs/rk3368_common.h b/include/configs/rk3368_common.h
index 10f643f..f85b76f 100644
--- a/include/configs/rk3368_common.h
+++ b/include/configs/rk3368_common.h
@@ -24,8 +24,6 @@
 
 #define COUNTER_FREQUENCY               24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x00300000
 #define CONFIG_SYS_LOAD_ADDR		0x00280000
 
diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
index f0e550d..f43dc7e 100644
--- a/include/configs/rk3399_common.h
+++ b/include/configs/rk3399_common.h
@@ -19,8 +19,6 @@
 
 #define COUNTER_FREQUENCY               24000000
 
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_INIT_SP_ADDR		0x00300000
 #define CONFIG_SYS_LOAD_ADDR		0x00800800
 #define CONFIG_SPL_STACK		0xff8effff
diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
index 26d41b5..72333e2 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -8,6 +8,8 @@
 #define _ROCKCHIP_COMMON_H_
 #include <linux/sizes.h>
 
+#define CONFIG_SYS_NS16550_MEM32
+
 #ifndef CONFIG_SPL_BUILD
 
 /* First try to boot from SD (index 0), then eMMC (index 1) */
diff --git a/include/configs/rv1108_common.h b/include/configs/rv1108_common.h
index 349c53c..cd204e9 100644
--- a/include/configs/rv1108_common.h
+++ b/include/configs/rv1108_common.h
@@ -18,9 +18,6 @@
 #define CONFIG_SYS_TIMER_BASE		0x10350020
 #define CONFIG_SYS_TIMER_COUNTER	(CONFIG_SYS_TIMER_BASE + 8)
 
-#define CONFIG_SYS_NS16550
-#define CONFIG_SYS_NS16550_MEM32
-
 #define CONFIG_SYS_SDRAM_BASE		0x60000000
 #define CONFIG_NR_DRAM_BANKS		1
 #define CONFIG_SYS_INIT_SP_ADDR		(CONFIG_SYS_TEXT_BASE + 0x100000)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550
  2018-04-19  3:37 [U-Boot] [PATCH v2 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Kever Yang
@ 2018-04-19  3:37 ` Kever Yang
  2018-04-25 10:29   ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
                     ` (2 more replies)
  2018-04-25 10:29 ` [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Philipp Tomsich
                   ` (2 subsequent siblings)
  3 siblings, 3 replies; 12+ messages in thread
From: Kever Yang @ 2018-04-19  3:37 UTC (permalink / raw)
  To: u-boot

We have enable NS16550 in Kconfig, do not need enable at defconfig

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

Changes in v2:
- check and add some missing board

 configs/chromebit_mickey_defconfig  | 1 -
 configs/chromebook_jerry_defconfig  | 1 -
 configs/chromebook_minnie_defconfig | 1 -
 configs/evb-rk3128_defconfig        | 1 -
 configs/evb-rk3229_defconfig        | 1 -
 configs/evb-rk3288_defconfig        | 1 -
 configs/evb-rk3328_defconfig        | 1 -
 configs/evb-rk3399_defconfig        | 1 -
 configs/fennec-rk3288_defconfig     | 1 -
 configs/firefly-rk3288_defconfig    | 1 -
 configs/firefly-rk3399_defconfig    | 1 -
 configs/miqi-rk3288_defconfig       | 1 -
 configs/phycore-rk3288_defconfig    | 1 -
 configs/popmetal-rk3288_defconfig   | 1 -
 configs/puma-rk3399_defconfig       | 1 -
 configs/rock2_defconfig             | 1 -
 configs/rock_defconfig              | 1 -
 configs/tinker-rk3288_defconfig     | 1 -
 configs/vyasa-rk3288_defconfig      | 1 -
 19 files changed, 19 deletions(-)

diff --git a/configs/chromebit_mickey_defconfig b/configs/chromebit_mickey_defconfig
index fbe0e5d..35b339d 100644
--- a/configs/chromebit_mickey_defconfig
+++ b/configs/chromebit_mickey_defconfig
@@ -70,7 +70,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SERIAL=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y
diff --git a/configs/chromebook_jerry_defconfig b/configs/chromebook_jerry_defconfig
index bced22e..0f734df 100644
--- a/configs/chromebook_jerry_defconfig
+++ b/configs/chromebook_jerry_defconfig
@@ -71,7 +71,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SERIAL=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y
diff --git a/configs/chromebook_minnie_defconfig b/configs/chromebook_minnie_defconfig
index 913b32e..3eec404 100644
--- a/configs/chromebook_minnie_defconfig
+++ b/configs/chromebook_minnie_defconfig
@@ -70,7 +70,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SERIAL=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y
diff --git a/configs/evb-rk3128_defconfig b/configs/evb-rk3128_defconfig
index e7414c9..367c654 100644
--- a/configs/evb-rk3128_defconfig
+++ b/configs/evb-rk3128_defconfig
@@ -33,7 +33,6 @@ CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_BASE=0x20068000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
diff --git a/configs/evb-rk3229_defconfig b/configs/evb-rk3229_defconfig
index 5ec9788..96afda8 100644
--- a/configs/evb-rk3229_defconfig
+++ b/configs/evb-rk3229_defconfig
@@ -45,7 +45,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0x11030000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_GADGET=y
diff --git a/configs/evb-rk3288_defconfig b/configs/evb-rk3288_defconfig
index 7ba7178..b8189fd 100644
--- a/configs/evb-rk3288_defconfig
+++ b/configs/evb-rk3288_defconfig
@@ -64,7 +64,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/evb-rk3328_defconfig b/configs/evb-rk3328_defconfig
index 266d699..3fb1cfc 100644
--- a/configs/evb-rk3328_defconfig
+++ b/configs/evb-rk3328_defconfig
@@ -43,7 +43,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0xFF130000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
index b5ae073..7e3e97d 100644
--- a/configs/evb-rk3399_defconfig
+++ b/configs/evb-rk3399_defconfig
@@ -55,7 +55,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/fennec-rk3288_defconfig b/configs/fennec-rk3288_defconfig
index 11112ca..0b6e8b9 100644
--- a/configs/fennec-rk3288_defconfig
+++ b/configs/fennec-rk3288_defconfig
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
index adb6b5d..dc856b0 100644
--- a/configs/firefly-rk3288_defconfig
+++ b/configs/firefly-rk3288_defconfig
@@ -67,7 +67,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
index 03d0324..ed30652 100644
--- a/configs/firefly-rk3399_defconfig
+++ b/configs/firefly-rk3399_defconfig
@@ -57,7 +57,6 @@ CONFIG_BAUDRATE=1500000
 CONFIG_DEBUG_UART_BASE=0xFF1A0000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_XHCI_HCD=y
diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
index a2e58a7..c62158a 100644
--- a/configs/miqi-rk3288_defconfig
+++ b/configs/miqi-rk3288_defconfig
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/phycore-rk3288_defconfig b/configs/phycore-rk3288_defconfig
index bd698f5..8e4e04d 100644
--- a/configs/phycore-rk3288_defconfig
+++ b/configs/phycore-rk3288_defconfig
@@ -67,7 +67,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/popmetal-rk3288_defconfig b/configs/popmetal-rk3288_defconfig
index 0d85349..2beee6e 100644
--- a/configs/popmetal-rk3288_defconfig
+++ b/configs/popmetal-rk3288_defconfig
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
index 32aa72c..5d69b0e 100644
--- a/configs/puma-rk3399_defconfig
+++ b/configs/puma-rk3399_defconfig
@@ -81,7 +81,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xFF180000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_ROCKCHIP_SPI=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
diff --git a/configs/rock2_defconfig b/configs/rock2_defconfig
index 744a84a..4e220fe 100644
--- a/configs/rock2_defconfig
+++ b/configs/rock2_defconfig
@@ -64,7 +64,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/rock_defconfig b/configs/rock_defconfig
index e46cc29..2e27768 100644
--- a/configs/rock_defconfig
+++ b/configs/rock_defconfig
@@ -49,7 +49,6 @@ CONFIG_RAM=y
 CONFIG_DEBUG_UART_BASE=0x20064000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_ROCKCHIP_USB2_PHY=y
diff --git a/configs/tinker-rk3288_defconfig b/configs/tinker-rk3288_defconfig
index f8ff916..1c28817 100644
--- a/configs/tinker-rk3288_defconfig
+++ b/configs/tinker-rk3288_defconfig
@@ -66,7 +66,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
diff --git a/configs/vyasa-rk3288_defconfig b/configs/vyasa-rk3288_defconfig
index 24a955a..90f1028 100644
--- a/configs/vyasa-rk3288_defconfig
+++ b/configs/vyasa-rk3288_defconfig
@@ -63,7 +63,6 @@ CONFIG_SPL_RAM=y
 CONFIG_DEBUG_UART_BASE=0xff690000
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_DEBUG_UART_SHIFT=2
-CONFIG_SYS_NS16550=y
 CONFIG_SYSRESET=y
 CONFIG_USB=y
 CONFIG_USB_DWC2=y
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
  2018-04-19  3:37 [U-Boot] [PATCH v2 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Kever Yang
  2018-04-19  3:37 ` [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550 Kever Yang
@ 2018-04-25 10:29 ` Philipp Tomsich
  2018-04-25 10:29 ` Philipp Tomsich
  2018-04-26  7:05 ` Philipp Tomsich
  3 siblings, 0 replies; 12+ messages in thread
From: Philipp Tomsich @ 2018-04-25 10:29 UTC (permalink / raw)
  To: u-boot

> All rockchip SoCs can use ns16550 driver, enable it for all
> and set SYS_NS16550_MEM32 for all SoCs.
> 
> Version-changes: 2
> - use imply instead of select
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/Kconfig                  | 1 +
>  arch/arm/mach-rockchip/Kconfig    | 1 -
>  include/configs/rk3036_common.h   | 3 ---
>  include/configs/rk3128_common.h   | 2 --
>  include/configs/rk3188_common.h   | 2 --
>  include/configs/rk322x_common.h   | 1 -
>  include/configs/rk3288_common.h   | 2 --
>  include/configs/rk3328_common.h   | 2 --
>  include/configs/rk3368_common.h   | 2 --
>  include/configs/rk3399_common.h   | 2 --
>  include/configs/rockchip-common.h | 2 ++
>  include/configs/rv1108_common.h   | 3 ---
>  12 files changed, 3 insertions(+), 20 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550
  2018-04-19  3:37 ` [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550 Kever Yang
@ 2018-04-25 10:29   ` Philipp Tomsich
  2018-04-25 10:29   ` Philipp Tomsich
  2018-04-26  7:05   ` Philipp Tomsich
  2 siblings, 0 replies; 12+ messages in thread
From: Philipp Tomsich @ 2018-04-25 10:29 UTC (permalink / raw)
  To: u-boot

> We have enable NS16550 in Kconfig, do not need enable at defconfig
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> Changes in v2:
> - check and add some missing board
> 
>  configs/chromebit_mickey_defconfig  | 1 -
>  configs/chromebook_jerry_defconfig  | 1 -
>  configs/chromebook_minnie_defconfig | 1 -
>  configs/evb-rk3128_defconfig        | 1 -
>  configs/evb-rk3229_defconfig        | 1 -
>  configs/evb-rk3288_defconfig        | 1 -
>  configs/evb-rk3328_defconfig        | 1 -
>  configs/evb-rk3399_defconfig        | 1 -
>  configs/fennec-rk3288_defconfig     | 1 -
>  configs/firefly-rk3288_defconfig    | 1 -
>  configs/firefly-rk3399_defconfig    | 1 -
>  configs/miqi-rk3288_defconfig       | 1 -
>  configs/phycore-rk3288_defconfig    | 1 -
>  configs/popmetal-rk3288_defconfig   | 1 -
>  configs/puma-rk3399_defconfig       | 1 -
>  configs/rock2_defconfig             | 1 -
>  configs/rock_defconfig              | 1 -
>  configs/tinker-rk3288_defconfig     | 1 -
>  configs/vyasa-rk3288_defconfig      | 1 -
>  19 files changed, 19 deletions(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
  2018-04-19  3:37 [U-Boot] [PATCH v2 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Kever Yang
  2018-04-19  3:37 ` [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550 Kever Yang
  2018-04-25 10:29 ` [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Philipp Tomsich
@ 2018-04-25 10:29 ` Philipp Tomsich
  2018-04-26  7:05 ` Philipp Tomsich
  3 siblings, 0 replies; 12+ messages in thread
From: Philipp Tomsich @ 2018-04-25 10:29 UTC (permalink / raw)
  To: u-boot

> All rockchip SoCs can use ns16550 driver, enable it for all
> and set SYS_NS16550_MEM32 for all SoCs.
> 
> Version-changes: 2
> - use imply instead of select
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/Kconfig                  | 1 +
>  arch/arm/mach-rockchip/Kconfig    | 1 -
>  include/configs/rk3036_common.h   | 3 ---
>  include/configs/rk3128_common.h   | 2 --
>  include/configs/rk3188_common.h   | 2 --
>  include/configs/rk322x_common.h   | 1 -
>  include/configs/rk3288_common.h   | 2 --
>  include/configs/rk3328_common.h   | 2 --
>  include/configs/rk3368_common.h   | 2 --
>  include/configs/rk3399_common.h   | 2 --
>  include/configs/rockchip-common.h | 2 ++
>  include/configs/rv1108_common.h   | 3 ---
>  12 files changed, 3 insertions(+), 20 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550
  2018-04-19  3:37 ` [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550 Kever Yang
  2018-04-25 10:29   ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
@ 2018-04-25 10:29   ` Philipp Tomsich
  2018-04-26  7:05   ` Philipp Tomsich
  2 siblings, 0 replies; 12+ messages in thread
From: Philipp Tomsich @ 2018-04-25 10:29 UTC (permalink / raw)
  To: u-boot

> We have enable NS16550 in Kconfig, do not need enable at defconfig
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
> Changes in v2:
> - check and add some missing board
> 
>  configs/chromebit_mickey_defconfig  | 1 -
>  configs/chromebook_jerry_defconfig  | 1 -
>  configs/chromebook_minnie_defconfig | 1 -
>  configs/evb-rk3128_defconfig        | 1 -
>  configs/evb-rk3229_defconfig        | 1 -
>  configs/evb-rk3288_defconfig        | 1 -
>  configs/evb-rk3328_defconfig        | 1 -
>  configs/evb-rk3399_defconfig        | 1 -
>  configs/fennec-rk3288_defconfig     | 1 -
>  configs/firefly-rk3288_defconfig    | 1 -
>  configs/firefly-rk3399_defconfig    | 1 -
>  configs/miqi-rk3288_defconfig       | 1 -
>  configs/phycore-rk3288_defconfig    | 1 -
>  configs/popmetal-rk3288_defconfig   | 1 -
>  configs/puma-rk3399_defconfig       | 1 -
>  configs/rock2_defconfig             | 1 -
>  configs/rock_defconfig              | 1 -
>  configs/tinker-rk3288_defconfig     | 1 -
>  configs/vyasa-rk3288_defconfig      | 1 -
>  19 files changed, 19 deletions(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
  2018-04-19  3:37 [U-Boot] [PATCH v2 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Kever Yang
                   ` (2 preceding siblings ...)
  2018-04-25 10:29 ` Philipp Tomsich
@ 2018-04-26  7:05 ` Philipp Tomsich
  2018-05-08  7:30   ` Jonathan Gray
  3 siblings, 1 reply; 12+ messages in thread
From: Philipp Tomsich @ 2018-04-26  7:05 UTC (permalink / raw)
  To: u-boot

> All rockchip SoCs can use ns16550 driver, enable it for all
> and set SYS_NS16550_MEM32 for all SoCs.
> 
> Version-changes: 2
> - use imply instead of select
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2: None
> 
>  arch/arm/Kconfig                  | 1 +
>  arch/arm/mach-rockchip/Kconfig    | 1 -
>  include/configs/rk3036_common.h   | 3 ---
>  include/configs/rk3128_common.h   | 2 --
>  include/configs/rk3188_common.h   | 2 --
>  include/configs/rk322x_common.h   | 1 -
>  include/configs/rk3288_common.h   | 2 --
>  include/configs/rk3328_common.h   | 2 --
>  include/configs/rk3368_common.h   | 2 --
>  include/configs/rk3399_common.h   | 2 --
>  include/configs/rockchip-common.h | 2 ++
>  include/configs/rv1108_common.h   | 3 ---
>  12 files changed, 3 insertions(+), 20 deletions(-)
> 

Applied to u-boot-rockchip, thanks!

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550
  2018-04-19  3:37 ` [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550 Kever Yang
  2018-04-25 10:29   ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
  2018-04-25 10:29   ` Philipp Tomsich
@ 2018-04-26  7:05   ` Philipp Tomsich
  2 siblings, 0 replies; 12+ messages in thread
From: Philipp Tomsich @ 2018-04-26  7:05 UTC (permalink / raw)
  To: u-boot

> We have enable NS16550 in Kconfig, do not need enable at defconfig
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
> Changes in v2:
> - check and add some missing board
> 
>  configs/chromebit_mickey_defconfig  | 1 -
>  configs/chromebook_jerry_defconfig  | 1 -
>  configs/chromebook_minnie_defconfig | 1 -
>  configs/evb-rk3128_defconfig        | 1 -
>  configs/evb-rk3229_defconfig        | 1 -
>  configs/evb-rk3288_defconfig        | 1 -
>  configs/evb-rk3328_defconfig        | 1 -
>  configs/evb-rk3399_defconfig        | 1 -
>  configs/fennec-rk3288_defconfig     | 1 -
>  configs/firefly-rk3288_defconfig    | 1 -
>  configs/firefly-rk3399_defconfig    | 1 -
>  configs/miqi-rk3288_defconfig       | 1 -
>  configs/phycore-rk3288_defconfig    | 1 -
>  configs/popmetal-rk3288_defconfig   | 1 -
>  configs/puma-rk3399_defconfig       | 1 -
>  configs/rock2_defconfig             | 1 -
>  configs/rock_defconfig              | 1 -
>  configs/tinker-rk3288_defconfig     | 1 -
>  configs/vyasa-rk3288_defconfig      | 1 -
>  19 files changed, 19 deletions(-)
> 

Applied to u-boot-rockchip, thanks!

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
  2018-04-26  7:05 ` Philipp Tomsich
@ 2018-05-08  7:30   ` Jonathan Gray
  2018-05-08  7:41     ` Dr. Philipp Tomsich
  0 siblings, 1 reply; 12+ messages in thread
From: Jonathan Gray @ 2018-05-08  7:30 UTC (permalink / raw)
  To: u-boot

On Thu, Apr 26, 2018 at 09:05:37AM +0200, Philipp Tomsich wrote:
> > All rockchip SoCs can use ns16550 driver, enable it for all
> > and set SYS_NS16550_MEM32 for all SoCs.
> > 
> > Version-changes: 2
> > - use imply instead of select
> > 
> > Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > ---
> > 
> > Changes in v2: None
> > 
> >  arch/arm/Kconfig                  | 1 +
> >  arch/arm/mach-rockchip/Kconfig    | 1 -
> >  include/configs/rk3036_common.h   | 3 ---
> >  include/configs/rk3128_common.h   | 2 --
> >  include/configs/rk3188_common.h   | 2 --
> >  include/configs/rk322x_common.h   | 1 -
> >  include/configs/rk3288_common.h   | 2 --
> >  include/configs/rk3328_common.h   | 2 --
> >  include/configs/rk3368_common.h   | 2 --
> >  include/configs/rk3399_common.h   | 2 --
> >  include/configs/rockchip-common.h | 2 ++
> >  include/configs/rv1108_common.h   | 3 ---
> >  12 files changed, 3 insertions(+), 20 deletions(-)
> > 
> 
> Applied to u-boot-rockchip, thanks!

With U-Boot 2018.05 there is no serial console output on tinker-rk3288,
a regression from 2018.03.  I have bisected it to this commit.

Reverting c3c0331db1fb7b1f4ff41e144fc04353b37c785c and
eb3d707e99fcd2213d5f8f0fe4ae53ad416b377e restores serial output with
2018.05.

c3c0331db1fb7b1f4ff41e144fc04353b37c785c is the first bad commit
commit c3c0331db1fb7b1f4ff41e144fc04353b37c785c
Author: Kever Yang <kever.yang@rock-chips.com>
Date:   Thu Apr 19 11:37:09 2018 +0800

    rockchip: enable SYS_NS16550 for all SoCs by default
    
    All rockchip SoCs can use ns16550 driver, enable it for all
    and set SYS_NS16550_MEM32 for all SoCs.
    
    Version-changes: 2
    - use imply instead of select
    
    Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
    Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
    Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

:040000 040000 f7cc8b28ae8179fdc15896bbb55279f205a54008 d07108bbf467735f31f31c083a9068dff71da247 M      arch
:040000 040000 d0a0422fc55afdcb5abb82f24b9a0af8de3d39a6 33c7fcf6f28f44a8c416f95313e7a30b2f73f8f0 M      include

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
  2018-05-08  7:30   ` Jonathan Gray
@ 2018-05-08  7:41     ` Dr. Philipp Tomsich
  2018-05-08 10:31       ` Jonathan Gray
  0 siblings, 1 reply; 12+ messages in thread
From: Dr. Philipp Tomsich @ 2018-05-08  7:41 UTC (permalink / raw)
  To: u-boot

Kever,

Could you analyse and provide (against master) a patch for this?
We’ll need to catch any left-overs from your changes at the start of the cycle
before we try to merge any of the more invasive changes you have in-flight.

Thanks,
Philipp.

> On 8 May 2018, at 09:30, Jonathan Gray <jsg@jsg.id.au> wrote:
> 
> On Thu, Apr 26, 2018 at 09:05:37AM +0200, Philipp Tomsich wrote:
>>> All rockchip SoCs can use ns16550 driver, enable it for all
>>> and set SYS_NS16550_MEM32 for all SoCs.
>>> 
>>> Version-changes: 2
>>> - use imply instead of select
>>> 
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> ---
>>> 
>>> Changes in v2: None
>>> 
>>> arch/arm/Kconfig                  | 1 +
>>> arch/arm/mach-rockchip/Kconfig    | 1 -
>>> include/configs/rk3036_common.h   | 3 ---
>>> include/configs/rk3128_common.h   | 2 --
>>> include/configs/rk3188_common.h   | 2 --
>>> include/configs/rk322x_common.h   | 1 -
>>> include/configs/rk3288_common.h   | 2 --
>>> include/configs/rk3328_common.h   | 2 --
>>> include/configs/rk3368_common.h   | 2 --
>>> include/configs/rk3399_common.h   | 2 --
>>> include/configs/rockchip-common.h | 2 ++
>>> include/configs/rv1108_common.h   | 3 ---
>>> 12 files changed, 3 insertions(+), 20 deletions(-)
>>> 
>> 
>> Applied to u-boot-rockchip, thanks!
> 
> With U-Boot 2018.05 there is no serial console output on tinker-rk3288,
> a regression from 2018.03.  I have bisected it to this commit.
> 
> Reverting c3c0331db1fb7b1f4ff41e144fc04353b37c785c and
> eb3d707e99fcd2213d5f8f0fe4ae53ad416b377e restores serial output with
> 2018.05.
> 
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c is the first bad commit
> commit c3c0331db1fb7b1f4ff41e144fc04353b37c785c
> Author: Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>>
> Date:   Thu Apr 19 11:37:09 2018 +0800
> 
>    rockchip: enable SYS_NS16550 for all SoCs by default
> 
>    All rockchip SoCs can use ns16550 driver, enable it for all
>    and set SYS_NS16550_MEM32 for all SoCs.
> 
>    Version-changes: 2
>    - use imply instead of select
> 
>    Signed-off-by: Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang@rock-chips.com>>
>    Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:philipp.tomsich@theobroma-systems.com>>
>    Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:philipp.tomsich@theobroma-systems.com>>
> 
> :040000 040000 f7cc8b28ae8179fdc15896bbb55279f205a54008 d07108bbf467735f31f31c083a9068dff71da247 M      arch
> :040000 040000 d0a0422fc55afdcb5abb82f24b9a0af8de3d39a6 33c7fcf6f28f44a8c416f95313e7a30b2f73f8f0 M      include

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
  2018-05-08  7:41     ` Dr. Philipp Tomsich
@ 2018-05-08 10:31       ` Jonathan Gray
  2018-05-08 10:47         ` Dr. Philipp Tomsich
  0 siblings, 1 reply; 12+ messages in thread
From: Jonathan Gray @ 2018-05-08 10:31 UTC (permalink / raw)
  To: u-boot

On Tue, May 08, 2018 at 09:41:32AM +0200, Dr. Philipp Tomsich wrote:
> Kever,
> 
> Could you analyse and provide (against master) a patch for this?
> We???ll need to catch any left-overs from your changes at the start of the cycle
> before we try to merge any of the more invasive changes you have in-flight.
> 
> Thanks,
> Philipp.

The patch in https://patchwork.ozlabs.org/patch/900546/ had a change in
include/configs/rockchip-common.h which was not included in the commit
that made it into to tree as c3c0331db1fb7b1f4ff41e144fc04353b37c785c.

After adding that back it works.

diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
index dee82ca99d..68e1105a4b 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -7,6 +7,8 @@
 #define _ROCKCHIP_COMMON_H_
 #include <linux/sizes.h>
 
+#define CONFIG_SYS_NS16550_MEM32
+
 #ifndef CONFIG_SPL_BUILD
 
 /* First try to boot from SD (index 0), then eMMC (index 1) */

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default
  2018-05-08 10:31       ` Jonathan Gray
@ 2018-05-08 10:47         ` Dr. Philipp Tomsich
  0 siblings, 0 replies; 12+ messages in thread
From: Dr. Philipp Tomsich @ 2018-05-08 10:47 UTC (permalink / raw)
  To: u-boot

Good catch.  I had a few merge-conflicts when merging that series.
That one might have gotten lost.

> On 8 May 2018, at 12:31, Jonathan Gray <jsg@jsg.id.au> wrote:
> 
> On Tue, May 08, 2018 at 09:41:32AM +0200, Dr. Philipp Tomsich wrote:
>> Kever,
>> 
>> Could you analyse and provide (against master) a patch for this?
>> We???ll need to catch any left-overs from your changes at the start of the cycle
>> before we try to merge any of the more invasive changes you have in-flight.
>> 
>> Thanks,
>> Philipp.
> 
> The patch in https://patchwork.ozlabs.org/patch/900546/ had a change in
> include/configs/rockchip-common.h which was not included in the commit
> that made it into to tree as c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
> 
> After adding that back it works.
> 
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index dee82ca99d..68e1105a4b 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -7,6 +7,8 @@
> #define _ROCKCHIP_COMMON_H_
> #include <linux/sizes.h>
> 
> +#define CONFIG_SYS_NS16550_MEM32
> +
> #ifndef CONFIG_SPL_BUILD
> 
> /* First try to boot from SD (index 0), then eMMC (index 1) */

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-05-08 10:47 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  3:37 [U-Boot] [PATCH v2 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Kever Yang
2018-04-19  3:37 ` [U-Boot] [PATCH v2 2/2] rockchip: defconfig: remove CONFIG_SYS_NS16550 Kever Yang
2018-04-25 10:29   ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2018-04-25 10:29   ` Philipp Tomsich
2018-04-26  7:05   ` Philipp Tomsich
2018-04-25 10:29 ` [U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default Philipp Tomsich
2018-04-25 10:29 ` Philipp Tomsich
2018-04-26  7:05 ` Philipp Tomsich
2018-05-08  7:30   ` Jonathan Gray
2018-05-08  7:41     ` Dr. Philipp Tomsich
2018-05-08 10:31       ` Jonathan Gray
2018-05-08 10:47         ` Dr. Philipp Tomsich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.