From: Harald Geyer <harald@ccbib.org> To: Icenowy Zheng <icenowy@aosc.io> Cc: Maxime Ripard <maxime.ripard@bootlin.com>, Chen-Yu Tsai <wens@csie.org>, Kalle Valo <kvalo@codeaurora.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Przywara <andre.przywara@arm.com>, info@olimex.com, linux-wireless@vger.kernel.org Subject: Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop Date: Sun, 24 Jun 2018 18:34:40 +0200 [thread overview] Message-ID: <E1fX7yK-0000OC-HA@stardust.g4.wien.funkfeuer.at> (raw) In-Reply-To: <a7011fe78d171658742406bf01d50b7e3d7eaf1d.camel@aosc.io> Icenowy Zheng writes: > 在 2018-03-15四的 16:25 +0000,Harald Geyer写道: > > +&mmc1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&mmc1_pins>; > > + vmmc-supply = <®_aldo2>; > > + vqmmc-supply = <®_dldo4>; > > + mmc-pwrseq = <&wifi_pwrseq>; > > + bus-width = <4>; > > + non-removable; > > + status = "okay"; > > + > > + rtl8723bs: wifi@1 { > > + reg = <1>; > > + interrupt-parent = <&r_pio>; > > + interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ > > + interrupt-names = "host-wake"; > > + }; > > I think this node has some problem: Thanks for the heads up! Admittedly, I simply copied this node from sun50i-a64-olinuxino.dts and since it worked, didn't look into it in too much detail. > - This device node has no binding. The "host-wake" interrupt is part of > Broadcom SDIO Wi-Fi binding, rather than a generic one. I think the general mmc and interrupts bindings apply. And the mmc binding clearly states that for sub-nodes a compatible string is optional. However I just realized that the 'interrupt-names' property is not part of the general interrupts binding, so I guess at least this property should be removed. > - Without the interrupt this device node isn't needed, as RTL8723BS has > MAC eFUSE and doesn't need a MAC in device tree. Indeed. I wasn't aware of this, but I just tested and the device probes fine without the subnode present. I think the devicetree is mainly for information which cannot be probed, so maybe the subnode should just get removed. > In order to solve the problems. I suggest either drop this device node > or make a generic "sdio-wifi" device tree binding. Personally I prefer > the latter, as it's more accurate device representation. > > If such a device tree binding is added, I think it should contain the > "host-wake" interrupt and a "local-mac-address" property. Both can be > ignored by the driver. (This interrupt can be needed if a more card- > ventor-neutral name is found.) I don't feel qualified to comment on this. If you want to propose such a patch and fix above node accordingly, I won't object. Otherwise I'll just send a patch to remove the subnode. Thanks, Harald
WARNING: multiple messages have this Message-ID (diff)
From: harald@ccbib.org (Harald Geyer) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop Date: Sun, 24 Jun 2018 18:34:40 +0200 [thread overview] Message-ID: <E1fX7yK-0000OC-HA@stardust.g4.wien.funkfeuer.at> (raw) In-Reply-To: <a7011fe78d171658742406bf01d50b7e3d7eaf1d.camel@aosc.io> Icenowy Zheng writes: > ? 2018-03-15?? 16:25 +0000?Harald Geyer??? > > +&mmc1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&mmc1_pins>; > > + vmmc-supply = <®_aldo2>; > > + vqmmc-supply = <®_dldo4>; > > + mmc-pwrseq = <&wifi_pwrseq>; > > + bus-width = <4>; > > + non-removable; > > + status = "okay"; > > + > > + rtl8723bs: wifi at 1 { > > + reg = <1>; > > + interrupt-parent = <&r_pio>; > > + interrupts = <0 3 IRQ_TYPE_LEVEL_LOW>; /* PL3 */ > > + interrupt-names = "host-wake"; > > + }; > > I think this node has some problem: Thanks for the heads up! Admittedly, I simply copied this node from sun50i-a64-olinuxino.dts and since it worked, didn't look into it in too much detail. > - This device node has no binding. The "host-wake" interrupt is part of > Broadcom SDIO Wi-Fi binding, rather than a generic one. I think the general mmc and interrupts bindings apply. And the mmc binding clearly states that for sub-nodes a compatible string is optional. However I just realized that the 'interrupt-names' property is not part of the general interrupts binding, so I guess at least this property should be removed. > - Without the interrupt this device node isn't needed, as RTL8723BS has > MAC eFUSE and doesn't need a MAC in device tree. Indeed. I wasn't aware of this, but I just tested and the device probes fine without the subnode present. I think the devicetree is mainly for information which cannot be probed, so maybe the subnode should just get removed. > In order to solve the problems. I suggest either drop this device node > or make a generic "sdio-wifi" device tree binding. Personally I prefer > the latter, as it's more accurate device representation. > > If such a device tree binding is added, I think it should contain the > "host-wake" interrupt and a "local-mac-address" property. Both can be > ignored by the driver. (This interrupt can be needed if a more card- > ventor-neutral name is found.) I don't feel qualified to comment on this. If you want to propose such a patch and fix above node accordingly, I won't object. Otherwise I'll just send a patch to remove the subnode. Thanks, Harald
next prev parent reply other threads:[~2018-06-24 16:41 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-15 16:25 [PATCHv2 0/5] arm64: allwinner: Add support for TERES-I laptop Harald Geyer 2018-03-15 16:25 ` Harald Geyer 2018-03-15 16:25 ` [PATCHv2 1/5] arm64: dts: allwinner: a64: Add i2c0 pins Harald Geyer 2018-03-15 16:25 ` Harald Geyer 2018-03-15 16:25 ` [PATCHv2 2/5] arm64: dts: allwinner: a64: Add watchdog Harald Geyer 2018-03-15 16:25 ` Harald Geyer 2018-03-18 12:52 ` Rob Herring 2018-03-18 12:52 ` Rob Herring 2018-03-18 12:52 ` Rob Herring 2018-03-15 16:25 ` [PATCHv2 3/5] arm64: dts: allwinner: a64: add simplefb for A64 SoC Harald Geyer 2018-03-15 16:25 ` Harald Geyer 2018-03-15 16:25 ` [PATCHv2 4/5] arm64: dts: allwinner: a64: Add pwm device Harald Geyer 2018-03-15 16:25 ` Harald Geyer 2018-03-18 12:52 ` Rob Herring 2018-03-18 12:52 ` Rob Herring 2018-03-18 13:51 ` André Przywara 2018-03-18 13:51 ` André Przywara 2018-03-15 16:25 ` [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop Harald Geyer 2018-03-15 16:25 ` Harald Geyer 2018-03-16 6:37 ` afzal mohammed 2018-03-16 6:37 ` afzal mohammed 2018-03-16 17:50 ` afzal mohammed 2018-03-16 17:50 ` afzal mohammed 2018-03-18 20:22 ` Maxime Ripard 2018-03-18 20:22 ` Maxime Ripard 2018-03-19 7:17 ` afzal mohammed 2018-03-19 7:17 ` afzal mohammed 2018-03-19 21:27 ` Maxime Ripard 2018-03-19 21:27 ` Maxime Ripard 2018-03-19 21:27 ` Maxime Ripard 2018-03-19 15:27 ` Harald Geyer 2018-03-19 15:27 ` Harald Geyer 2018-03-20 14:13 ` Maxime Ripard 2018-03-20 14:13 ` Maxime Ripard 2018-03-20 17:09 ` Andre Przywara 2018-03-20 17:09 ` Andre Przywara 2018-03-22 17:59 ` Maxime Ripard 2018-03-22 17:59 ` Maxime Ripard 2018-06-22 16:27 ` Icenowy Zheng 2018-06-22 16:27 ` Icenowy Zheng 2018-06-24 16:34 ` Harald Geyer [this message] 2018-06-24 16:34 ` Harald Geyer 2018-06-25 7:43 ` Arend van Spriel 2018-06-25 7:43 ` Arend van Spriel 2018-06-25 7:47 ` Icenowy Zheng 2018-06-25 7:47 ` Icenowy Zheng 2018-06-25 8:13 ` Arend van Spriel 2018-06-25 8:13 ` Arend van Spriel 2018-06-25 10:42 ` Icenowy Zheng 2018-06-25 10:42 ` Icenowy Zheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E1fX7yK-0000OC-HA@stardust.g4.wien.funkfeuer.at \ --to=harald@ccbib.org \ --cc=andre.przywara@arm.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=icenowy@aosc.io \ --cc=info@olimex.com \ --cc=kvalo@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=wens@csie.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.