* [U-Boot] [PATCH] rockchip: video: mipi: Do not write to the version register
@ 2018-11-07 10:34 Richard Röjfors
2018-11-07 10:44 ` Philipp Tomsich
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Richard Röjfors @ 2018-11-07 10:34 UTC (permalink / raw)
To: u-boot
There was a copy and paste error where the data
enable setting was written to the version register.
Signed-off-by: Richard Röjfors <richard@puffinpack.se>
---
drivers/video/rockchip/rk_mipi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/rockchip/rk_mipi.c b/drivers/video/rockchip/rk_mipi.c
index 4fe8f47441..88bf56ea09 100644
--- a/drivers/video/rockchip/rk_mipi.c
+++ b/drivers/video/rockchip/rk_mipi.c
@@ -106,7 +106,7 @@ int rk_mipi_dsi_enable(struct udevice *dev,
rk_mipi_dsi_write(regs, VSYNC_ACTIVE_LOW, val);
val = (timing->flags & DISPLAY_FLAGS_DE_LOW) ? 1 : 0;
- rk_mipi_dsi_write(regs, DISPLAY_FLAGS_DE_LOW, val);
+ rk_mipi_dsi_write(regs, DATAEN_ACTIVE_LOW, val);
val = (timing->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE) ? 1 : 0;
rk_mipi_dsi_write(regs, COLORM_ACTIVE_LOW, val);
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] rockchip: video: mipi: Do not write to the version register
2018-11-07 10:34 [U-Boot] [PATCH] rockchip: video: mipi: Do not write to the version register Richard Röjfors
@ 2018-11-07 10:44 ` Philipp Tomsich
2018-11-14 20:45 ` [U-Boot] " Philipp Tomsich
2018-11-14 23:35 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2018-11-07 10:44 UTC (permalink / raw)
To: u-boot
> On 07.11.2018, at 11:34, Richard Röjfors <richard.rojfors@gmail.com> wrote:
>
> There was a copy and paste error where the data
> enable setting was written to the version register.
>
> Signed-off-by: Richard Röjfors <richard@puffinpack.se>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] rockchip: video: mipi: Do not write to the version register
2018-11-07 10:34 [U-Boot] [PATCH] rockchip: video: mipi: Do not write to the version register Richard Röjfors
2018-11-07 10:44 ` Philipp Tomsich
@ 2018-11-14 20:45 ` Philipp Tomsich
2018-11-14 23:35 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2018-11-14 20:45 UTC (permalink / raw)
To: u-boot
> There was a copy and paste error where the data
> enable setting was written to the version register.
>
> Signed-off-by: Richard Röjfors <richard@puffinpack.se>
> ---
> drivers/video/rockchip/rk_mipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] rockchip: video: mipi: Do not write to the version register
2018-11-07 10:34 [U-Boot] [PATCH] rockchip: video: mipi: Do not write to the version register Richard Röjfors
2018-11-07 10:44 ` Philipp Tomsich
2018-11-14 20:45 ` [U-Boot] " Philipp Tomsich
@ 2018-11-14 23:35 ` Philipp Tomsich
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Tomsich @ 2018-11-14 23:35 UTC (permalink / raw)
To: u-boot
> There was a copy and paste error where the data
> enable setting was written to the version register.
>
> Signed-off-by: Richard Röjfors <richard@puffinpack.se>
> ---
> drivers/video/rockchip/rk_mipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-14 23:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 10:34 [U-Boot] [PATCH] rockchip: video: mipi: Do not write to the version register Richard Röjfors
2018-11-07 10:44 ` Philipp Tomsich
2018-11-14 20:45 ` [U-Boot] " Philipp Tomsich
2018-11-14 23:35 ` Philipp Tomsich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.