* [git:media_tree/master] media: ti-vpe: cal: fix disable_irqs to only the intended target
@ 2020-03-05 21:47 Mauro Carvalho Chehab
2020-03-07 23:20 ` Sasha Levin
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2020-03-05 21:47 UTC (permalink / raw)
To: linuxtv-commits; +Cc: Benoit Parrot, stable, Hans Verkuil
This is an automatic generated email to let you know that the following patch were queued:
Subject: media: ti-vpe: cal: fix disable_irqs to only the intended target
Author: Benoit Parrot <bparrot@ti.com>
Date: Mon Mar 2 14:56:52 2020 +0100
disable_irqs() was mistakenly disabling all interrupts when called.
This cause all port stream to stop even if only stopping one of them.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/ti-vpe/cal.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
index 6e009e479be3..6d4cbb8782ed 100644
--- a/drivers/media/platform/ti-vpe/cal.c
+++ b/drivers/media/platform/ti-vpe/cal.c
@@ -722,16 +722,16 @@ static void enable_irqs(struct cal_ctx *ctx)
static void disable_irqs(struct cal_ctx *ctx)
{
+ u32 val;
+
/* Disable IRQ_WDMA_END 0/1 */
- reg_write_field(ctx->dev,
- CAL_HL_IRQENABLE_CLR(2),
- CAL_HL_IRQ_CLEAR,
- CAL_HL_IRQ_MASK(ctx->csi2_port));
+ val = 0;
+ set_field(&val, CAL_HL_IRQ_CLEAR, CAL_HL_IRQ_MASK(ctx->csi2_port));
+ reg_write(ctx->dev, CAL_HL_IRQENABLE_CLR(2), val);
/* Disable IRQ_WDMA_START 0/1 */
- reg_write_field(ctx->dev,
- CAL_HL_IRQENABLE_CLR(3),
- CAL_HL_IRQ_CLEAR,
- CAL_HL_IRQ_MASK(ctx->csi2_port));
+ val = 0;
+ set_field(&val, CAL_HL_IRQ_CLEAR, CAL_HL_IRQ_MASK(ctx->csi2_port));
+ reg_write(ctx->dev, CAL_HL_IRQENABLE_CLR(3), val);
/* Todo: Add VC_IRQ and CSI2_COMPLEXIO_IRQ handling */
reg_write(ctx->dev, CAL_CSI2_VC_IRQENABLE(1), 0);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [git:media_tree/master] media: ti-vpe: cal: fix disable_irqs to only the intended target
2020-03-05 21:47 [git:media_tree/master] media: ti-vpe: cal: fix disable_irqs to only the intended target Mauro Carvalho Chehab
@ 2020-03-07 23:20 ` Sasha Levin
0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2020-03-07 23:20 UTC (permalink / raw)
To: Sasha Levin, Mauro Carvalho Chehab, linuxtv-commits
Cc: Benoit Parrot, stable, stable, stable
Hi
[This is an automated email]
This commit has been processed because it contains a -stable tag.
The stable tag indicates that it's relevant for the following trees: all
The bot has tested the following trees: v5.5.8, v5.4.24, v4.19.108, v4.14.172, v4.9.215, v4.4.215.
v5.5.8: Build OK!
v5.4.24: Build OK!
v4.19.108: Build OK!
v4.14.172: Build OK!
v4.9.215: Build OK!
v4.4.215: Failed to apply! Possible dependencies:
343e89a792a5 ("[media] media: ti-vpe: Add CAL v4l2 camera capture driver")
NOTE: The patch will not be queued to stable trees until it is upstream.
How should we proceed with this patch?
--
Thanks
Sasha
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-07 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-05 21:47 [git:media_tree/master] media: ti-vpe: cal: fix disable_irqs to only the intended target Mauro Carvalho Chehab
2020-03-07 23:20 ` Sasha Levin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.