[PATCH net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops

[PATCH net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops

[Russell King (Oracle)]

The kernel build bot identified the following mistake in the recently
merged 860a9bed2651 ("net: dsa: xrs700x: provide own phylink MAC
operations") patch:

drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]
     714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
         |                                     ^~~~~~~~~~~~~~~~~~~~~~~

Fix the omitted assignment of ds->phylink_mac_ops.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
Normal builds don't catch this, and W=1 produces 5.3klines of warnings,
so its pretty difficult to build-test changes such as these and have
confidence that they are correct. If anyone knows of a solution to
this problem...

 drivers/net/dsa/xrs700x/xrs700x.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/xrs700x/xrs700x.c b/drivers/net/dsa/xrs700x/xrs700x.c
index 6605fa44bcf0..de3b768f2ff9 100644
--- a/drivers/net/dsa/xrs700x/xrs700x.c
+++ b/drivers/net/dsa/xrs700x/xrs700x.c
@@ -780,6 +780,7 @@ struct xrs700x *xrs700x_switch_alloc(struct device *base, void *devpriv)
 	INIT_DELAYED_WORK(&priv->mib_work, xrs700x_mib_work);
 
 	ds->ops = &xrs700x_ops;
+	ds->phylink_mac_ops = &xrs700x_phylink_mac_ops;
 	ds->priv = priv;
 	priv->dev = base;
 
-- 
2.30.2

Re: [PATCH net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 18 Apr 2024 11:51:21 +0100 you wrote:
> The kernel build bot identified the following mistake in the recently
> merged 860a9bed2651 ("net: dsa: xrs700x: provide own phylink MAC
> operations") patch:
> 
> drivers/net/dsa/xrs700x/xrs700x.c:714:37: warning: 'xrs700x_phylink_mac_ops' defined but not used [-Wunused-const-variable=]
>      714 | static const struct phylink_mac_ops xrs700x_phylink_mac_ops = {
>          |                                     ^~~~~~~~~~~~~~~~~~~~~~~
> 
> [...]

Here is the summary with links:
  - [net-next] net: dsa: xrs700x: fix missing initialisation of ds->phylink_mac_ops
    https://git.kernel.org/netdev/net-next/c/9fc31a9251de

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html