* [PATCH] tools/firmware: Fix typo in uninstall target
@ 2020-08-18 19:29 Hubert Jasudowicz
2020-08-19 8:07 ` Bertrand Marquis
0 siblings, 1 reply; 2+ messages in thread
From: Hubert Jasudowicz @ 2020-08-18 19:29 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, Wei Liu
When ipxe.bin is missing, make uninstall will fail due to
wrong switch (-r) passed to rm command. Replace it with -f.
Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@cert.pl>
---
tools/firmware/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
index 809a5fd025..1f27117794 100644
--- a/tools/firmware/Makefile
+++ b/tools/firmware/Makefile
@@ -72,7 +72,7 @@ ifeq ($(CONFIG_OVMF),y)
rm -f $(INST_DIR)/ovmf.bin
endif
ifeq ($(CONFIG_IPXE),y)
- rm -r $(INST_DIR)/ipxe.bin
+ rm -f $(INST_DIR)/ipxe.bin
endif
ifeq ($(CONFIG_PV_SHIM),y)
rm -f $(INST_DIR)/xen-shim
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/firmware: Fix typo in uninstall target
2020-08-18 19:29 [PATCH] tools/firmware: Fix typo in uninstall target Hubert Jasudowicz
@ 2020-08-19 8:07 ` Bertrand Marquis
0 siblings, 0 replies; 2+ messages in thread
From: Bertrand Marquis @ 2020-08-19 8:07 UTC (permalink / raw)
To: Hubert Jasudowicz; +Cc: Xen-devel, Ian Jackson, Wei Liu, nd
> On 18 Aug 2020, at 20:29, Hubert Jasudowicz <hubert.jasudowicz@cert.pl> wrote:
>
> When ipxe.bin is missing, make uninstall will fail due to
> wrong switch (-r) passed to rm command. Replace it with -f.
>
Having a make uninstall is quite unusual.
But the modification looks right so ...
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@cert.pl>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
> tools/firmware/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> index 809a5fd025..1f27117794 100644
> --- a/tools/firmware/Makefile
> +++ b/tools/firmware/Makefile
> @@ -72,7 +72,7 @@ ifeq ($(CONFIG_OVMF),y)
> rm -f $(INST_DIR)/ovmf.bin
> endif
> ifeq ($(CONFIG_IPXE),y)
> - rm -r $(INST_DIR)/ipxe.bin
> + rm -f $(INST_DIR)/ipxe.bin
> endif
> ifeq ($(CONFIG_PV_SHIM),y)
> rm -f $(INST_DIR)/xen-shim
> --
> 2.28.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-19 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-18 19:29 [PATCH] tools/firmware: Fix typo in uninstall target Hubert Jasudowicz
2020-08-19 8:07 ` Bertrand Marquis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.