[PATCH] x86: Restore reboot quirks by DMI, fix reboot on a number of systems

* [PATCH] x86: Restore reboot quirks by DMI, fix reboot on a number of systems
@ 2013-06-11 14:09 Ben Guthro
  2013-06-11 15:59 ` George Dunlap
  2013-06-21 10:34 ` [PATCH v2] " Jan Beulich
  0 siblings, 2 replies; 9+ messages in thread
From: Ben Guthro @ 2013-06-11 14:09 UTC (permalink / raw)
  To: Jan Beulich, xen-devel; +Cc: Ben Guthro

The following patch ports the functionality following changeset from linux (from 2008) to xen:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=14d7ca5c
It implements an additional reboot quirk to do a PCI reset via port CF9.

This also restores some code dropped in the x86_32 target removal (changeset
5d1181a5ea5e0f11d481a94b16ed00d883f9726e) which sets some quirks based on DMI matching.

This will add reboot quirks on the following systems that are known to be necessary on linux:

    Dell E520
    Dell PowerEdge 1300
    Dell PowerEdge 300
    Dell OptiPlex 745
    Dell OptiPlex 745
    Dell OptiPlex 745
    Dell OptiPlex 330
    Dell OptiPlex 360
    Dell OptiPlex 760
    Dell PowerEdge 2400
    Dell Precision T5400
    Dell Precision T7400
    HP Compaq Laptop
    Dell XPS710
    Dell DXP061
    Sony VGN-Z540N
    ASUS P4S800
    Acer Aspire One A110
    Apple MacBook5
    Apple MacBookPro5
    Apple Macmini3,1
    Apple iMac9,1
    Dell Latitude E6320
    Dell Latitude E5420
    Dell Latitude E6220
    Dell Latitude E6420
    Dell OptiPlex 990
    Dell OptiPlex 990
    Dell Latitude E6520
    Dell OptiPlex 790
    Dell OptiPlex 990
    Dell OptiPlex 390
    Dell Latitude E6320
    Dell Latitude E6420
    Dell Latitude E6520

I clearly have not been able to test on all of these systems.
It does fix rebooting on the Dell 790, and should *not* change the reboot paths of systems not on this DMI match list.

Signed-off-by: Ben Guthro <benjamin.guthro@citrix.com>
---
 xen/arch/x86/shutdown.c |  341 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 341 insertions(+)

diff --git a/xen/arch/x86/shutdown.c b/xen/arch/x86/shutdown.c
index 7593191..bbe7472 100644
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -32,6 +32,7 @@ enum reboot_type {
         BOOT_KBD = 'k',
         BOOT_ACPI = 'a',
         BOOT_BIOS = 'b',
+        BOOT_CF9 = 'p',
 };
 
 static long no_idt[2];
@@ -45,6 +46,7 @@ static int reboot_mode;
  * triple Force a triple fault (init)
  * kbd    Use the keyboard controller. cold reset (default)
  * acpi   Use the RESET_REG in the FADT
+ * pci    Use the so-called "PCI reset register", CF9
  */
 static enum reboot_type reboot_type = BOOT_ACPI;
 static void __init set_reboot_type(char *str)
@@ -66,6 +68,7 @@ static void __init set_reboot_type(char *str)
         case 'a':
         case 'k':
         case 't':
+        case 'p':
             reboot_type = *str;
             break;
         }
@@ -101,6 +104,334 @@ void machine_halt(void)
     __machine_halt(NULL);
 }
 
+static int __init set_bios_reboot(struct dmi_system_id *d)
+{
+    if ( reboot_type != BOOT_BIOS )
+    {
+        reboot_type = BOOT_BIOS;
+        printk("%s series board detected. "
+               "Selecting BIOS-method for reboots.\n", d->ident);
+    }
+    return 0;
+}
+
+static int __init set_pci_reboot(struct dmi_system_id *d)
+{
+    if ( reboot_type != BOOT_CF9 )
+    {
+        reboot_type = BOOT_CF9;
+        printk("%s series board detected. "
+               "Selecting pci-method for reboots.\n", d->ident);
+    }
+    return 0;
+}
+
+static int __init set_kbd_reboot(struct dmi_system_id *d)
+{
+    if (reboot_type != BOOT_KBD) {
+        reboot_type = BOOT_KBD;
+        printk("%s series board detected. Selecting KBD-method for reboot.\n",
+            d->ident);
+    }
+    return 0;
+}
+
+static struct dmi_system_id __initdata reboot_dmi_table[] = {
+    {    /* Handle problems with rebooting on Dell E520's */
+        .callback = set_bios_reboot,
+        .ident = "Dell E520",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Dell DM061"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell 1300's */
+        .callback = set_bios_reboot,
+        .ident = "Dell PowerEdge 1300",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+            DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge 1300/"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell 300's */
+        .callback = set_bios_reboot,
+        .ident = "Dell PowerEdge 300",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+            DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge 300/"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell Optiplex 745's SFF */
+        .callback = set_bios_reboot,
+        .ident = "Dell OptiPlex 745",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 745"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell Optiplex 745's DFF */
+        .callback = set_bios_reboot,
+        .ident = "Dell OptiPlex 745",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 745"),
+            DMI_MATCH(DMI_BOARD_NAME, "0MM599"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell Optiplex 745 with 0KW626 */
+        .callback = set_bios_reboot,
+        .ident = "Dell OptiPlex 745",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 745"),
+            DMI_MATCH(DMI_BOARD_NAME, "0KW626"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell Optiplex 330 with 0KP561 */
+        .callback = set_bios_reboot,
+        .ident = "Dell OptiPlex 330",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 330"),
+            DMI_MATCH(DMI_BOARD_NAME, "0KP561"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell Optiplex 360 with 0T656F */
+        .callback = set_bios_reboot,
+        .ident = "Dell OptiPlex 360",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 360"),
+            DMI_MATCH(DMI_BOARD_NAME, "0T656F"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell OptiPlex 760 with 0G919G */
+        .callback = set_bios_reboot,
+        .ident = "Dell OptiPlex 760",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 760"),
+            DMI_MATCH(DMI_BOARD_NAME, "0G919G"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell 2400's */
+        .callback = set_bios_reboot,
+        .ident = "Dell PowerEdge 2400",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
+            DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge 2400"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell T5400's */
+        .callback = set_bios_reboot,
+        .ident = "Dell Precision T5400",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Precision WorkStation T5400"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell T7400's */
+        .callback = set_bios_reboot,
+        .ident = "Dell Precision T7400",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Precision WorkStation T7400"),
+        },
+    },
+    {    /* Handle problems with rebooting on HP laptops */
+        .callback = set_bios_reboot,
+        .ident = "HP Compaq Laptop",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+            DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell XPS710 */
+        .callback = set_bios_reboot,
+        .ident = "Dell XPS710",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Dell XPS710"),
+        },
+    },
+    {    /* Handle problems with rebooting on Dell DXP061 */
+        .callback = set_bios_reboot,
+        .ident = "Dell DXP061",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Dell DXP061"),
+        },
+    },
+    {    /* Handle problems with rebooting on Sony VGN-Z540N */
+        .callback = set_bios_reboot,
+        .ident = "Sony VGN-Z540N",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+            DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
+        },
+    },
+    {    /* Handle problems with rebooting on ASUS P4S800 */
+        .callback = set_bios_reboot,
+        .ident = "ASUS P4S800",
+        .matches = {
+            DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
+            DMI_MATCH(DMI_BOARD_NAME, "P4S800"),
+        },
+    },
+    {    /* Handle reboot issue on Acer Aspire one */
+        .callback = set_kbd_reboot,
+        .ident = "Acer Aspire One A110",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+            DMI_MATCH(DMI_PRODUCT_NAME, "AOA110"),
+        },
+    },
+    {    /* Handle problems with rebooting on Apple MacBook5 */
+        .callback = set_pci_reboot,
+        .ident = "Apple MacBook5",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "MacBook5"),
+        },
+    },
+    {    /* Handle problems with rebooting on Apple MacBookPro5 */
+        .callback = set_pci_reboot,
+        .ident = "Apple MacBookPro5",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro5"),
+        },
+    },
+    {    /* Handle problems with rebooting on Apple Macmini3,1 */
+        .callback = set_pci_reboot,
+        .ident = "Apple Macmini3,1",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"),
+        },
+    },
+    {    /* Handle problems with rebooting on the iMac9,1. */
+        .callback = set_pci_reboot,
+        .ident = "Apple iMac9,1",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Latitude E6320. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E6320",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6320"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Latitude E5420. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E5420",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5420"),
+        },
+    },
+    {       /* Handle problems with rebooting on the Latitude E6220. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E6220",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6220"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Latitude E6420. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E6420",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6420"),
+        },
+    },
+    {    /* Handle problems with rebooting on the OptiPlex 990. */
+        .callback = set_pci_reboot,
+        .ident = "Dell OptiPlex 990",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 990"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Precision M6600. */
+        .callback = set_pci_reboot,
+        .ident = "Dell OptiPlex 990",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Precision M6600"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Latitude E6520. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E6520",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6520"),
+        },
+    },
+    {       /* Handle problems with rebooting on the OptiPlex 790. */
+        .callback = set_pci_reboot,
+        .ident = "Dell OptiPlex 790",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 790"),
+        },
+    },
+    {    /* Handle problems with rebooting on the OptiPlex 990. */
+        .callback = set_pci_reboot,
+        .ident = "Dell OptiPlex 990",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 990"),
+        },
+    },
+    {    /* Handle problems with rebooting on the OptiPlex 390. */
+        .callback = set_pci_reboot,
+        .ident = "Dell OptiPlex 390",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 390"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Latitude E6320. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E6320",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6320"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Latitude E6420. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E6420",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6420"),
+        },
+    },
+    {    /* Handle problems with rebooting on the Latitude E6520. */
+        .callback = set_pci_reboot,
+        .ident = "Dell Latitude E6520",
+        .matches = {
+            DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+            DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6520"),
+        },
+    },
+    { }
+};
+
+static int __init reboot_init(void)
+{
+    dmi_check_system(reboot_dmi_table);
+    return 0;
+}
+__initcall(reboot_init);
+
 static void __machine_restart(void *pdelay)
 {
     machine_restart(*(unsigned int *)pdelay);
@@ -183,6 +514,16 @@ void machine_restart(unsigned int delay_millisecs)
             acpi_reboot();
             reboot_type = BOOT_KBD;
             break;
+        case BOOT_CF9:
+            {
+                u8 cf9 = inb(0xcf9) & ~6;
+                outb(cf9|2, 0xcf9); /* Request hard reset */
+                udelay(50);
+                outb(cf9|6, 0xcf9); /* Actually do the reset */
+                udelay(50);
+            }
+            reboot_type = BOOT_ACPI;
+            break;
         }
     }
 }
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 9+ messages in thread