* [PATCH] git: make "git -C '' <cmd>" not to barf
@ 2015-03-03 15:41 Karthik Nayak
2015-03-03 16:22 ` Matthieu Moy
0 siblings, 1 reply; 4+ messages in thread
From: Karthik Nayak @ 2015-03-03 15:41 UTC (permalink / raw)
To: git; +Cc: Karthik Nayak
now it works like cd "" which silently succeeds
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
git.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/git.c b/git.c
index 8c7ee9c..f4c2285 100644
--- a/git.c
+++ b/git.c
@@ -204,7 +204,9 @@ static int handle_options(const char ***argv, int *argc, int *envchanged)
fprintf(stderr, "No directory given for -C.\n" );
usage(git_usage_string);
}
- if (chdir((*argv)[1]))
+ if (*(*argv)[1] == 0)
+ ; /* Ignore "" as a directory */
+ else if (chdir((*argv)[1]))
die_errno("Cannot change to '%s'", (*argv)[1]);
if (envchanged)
*envchanged = 1;
--
2.3.1.167.g7f4ba4b.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] git: make "git -C '' <cmd>" not to barf
2015-03-03 15:41 [PATCH] git: make "git -C '' <cmd>" not to barf Karthik Nayak
@ 2015-03-03 16:22 ` Matthieu Moy
2015-03-03 18:00 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Matthieu Moy @ 2015-03-03 16:22 UTC (permalink / raw)
To: Karthik Nayak; +Cc: git
Karthik Nayak <karthik.188@gmail.com> writes:
> now it works like cd "" which silently succeeds
Missing "." at end of sentence.
> git.c | 4 +++-
That would probably also deserve a test.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git: make "git -C '' <cmd>" not to barf
2015-03-03 16:22 ` Matthieu Moy
@ 2015-03-03 18:00 ` Junio C Hamano
2015-03-04 8:41 ` Karthik Nayak
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2015-03-03 18:00 UTC (permalink / raw)
To: Matthieu Moy; +Cc: Karthik Nayak, Git Mailing List
On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> now it works like cd "" which silently succeeds
>
> Missing "." at end of sentence.
And lack of capitalization at the beginning.
More importantly, lack of justification--why is it a good idea to make
"it works like cd ''" in the first place?
>
>> git.c | 4 +++-
>
> That would probably also deserve a test.
Another "huh?" I had on the actual code was if this counts as "envchanged", if
you are not actually changing the directory at all.
Is this meant as a "micro" for GSoC, by the way?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git: make "git -C '' <cmd>" not to barf
2015-03-03 18:00 ` Junio C Hamano
@ 2015-03-04 8:41 ` Karthik Nayak
0 siblings, 0 replies; 4+ messages in thread
From: Karthik Nayak @ 2015-03-04 8:41 UTC (permalink / raw)
To: Junio C Hamano, Matthieu Moy; +Cc: Git Mailing List
On March 3, 2015 11:30:13 PM GMT+05:30, Junio C Hamano <gitster@pobox.com> wrote:
>On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy
><Matthieu.Moy@grenoble-inp.fr> wrote:
>> Karthik Nayak <karthik.188@gmail.com> writes:
>>
>>> now it works like cd "" which silently succeeds
>>
>> Missing "." at end of sentence.
>
>And lack of capitalization at the beginning.
Yes, noted, Will fix with next patch.
>
>More importantly, lack of justification--why is it a good idea to make
>"it works like cd ''" in the first place?
>
>>
>>> git.c | 4 +++-
>>
>> That would probably also deserve a test.
Will include a patch with next patch version.
>
>Another "huh?" I had on the actual code was if this counts as
>"envchanged", if
>you are not actually changing the directory at all.
>
>Is this meant as a "micro" for GSoC, by the way?
Yes, it's meant for GSoC.
I did overlook that. Will fix in next patch version.
Thanks for your suggestions
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-04 8:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 15:41 [PATCH] git: make "git -C '' <cmd>" not to barf Karthik Nayak
2015-03-03 16:22 ` Matthieu Moy
2015-03-03 18:00 ` Junio C Hamano
2015-03-04 8:41 ` Karthik Nayak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.