* Re: Patch for libsocketcan
[not found] <6D9074C1-4B77-4D4B-BCF5-F13625B6DC05@ovro.caltech.edu>
@ 2012-08-07 7:43 ` Marc Kleine-Budde
2012-08-07 15:09 ` Andrew Beard
0 siblings, 1 reply; 2+ messages in thread
From: Marc Kleine-Budde @ 2012-08-07 7:43 UTC (permalink / raw)
To: Andrew Beard; +Cc: Ira Snyder, linux-can
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
Hello Andrew,
I've added linux-can on Cc.
On 08/03/2012 08:23 PM, Andrew Beard wrote:
> Hi Marc,
> Attached is a patch for what I believe is a bug in libsocketcan.
> Please let me know if you have any questions.
Yes, it's a bug, Alexander Stein fixed it already, but I didn't apply
his patch. Your patch, is the way better solution. You did not follow
quite the kernel coding style, and put some variable definition into the
loop. I fixed that an will commit it to the repo. Can I add your
Signed-off-by[1] to the patch?
Marc
[1]
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L298
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch for libsocketcan
2012-08-07 7:43 ` Patch for libsocketcan Marc Kleine-Budde
@ 2012-08-07 15:09 ` Andrew Beard
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Beard @ 2012-08-07 15:09 UTC (permalink / raw)
To: Marc Kleine-Budde; +Cc: Ira Snyder, linux-can
On Aug 7, 2012, at 12:43 AM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> Hello Andrew,
>
> I've added linux-can on Cc.
>
> On 08/03/2012 08:23 PM, Andrew Beard wrote:
>> Hi Marc,
>> Attached is a patch for what I believe is a bug in libsocketcan.
>> Please let me know if you have any questions.
>
> Yes, it's a bug, Alexander Stein fixed it already, but I didn't apply
> his patch. Your patch, is the way better solution. You did not follow
> quite the kernel coding style, and put some variable definition into the
> loop. I fixed that an will commit it to the repo. Can I add your
> Signed-off-by[1] to the patch?
Hi Marc,
That would be fine.
Thanks,
~Andy
>
> Marc
>
> [1]
> http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L298
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Industrial Linux Solutions | Phone: +49-231-2826-924 |
> Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-07 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <6D9074C1-4B77-4D4B-BCF5-F13625B6DC05@ovro.caltech.edu>
2012-08-07 7:43 ` Patch for libsocketcan Marc Kleine-Budde
2012-08-07 15:09 ` Andrew Beard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.