[PATCH v2 0/3] v2: s3c-fb panning and vsync support

[PATCH v2 0/3] v2: s3c-fb panning and vsync support

[Pawel Osciak]

Hello,

this is the second version of my previous patchset, corrected after your feedback (thank you).

[v2]:

In the panning patch:
* panning is done per-byte (the unit used in VIDW_BUF_START) and has been tested for different
bpps, including bpp < 8

* introduced the PRTCON register, which basically disables in-hardware updates from
shadow registers for VIDW_BUF_START/END (and a couple of others):
- shadow registers are updated on vsync (in hw)
- the update will not occur if PRTCON protection is enabled
This way we are safe when updating them at any time, even though they are separate.

In VSYNC patch:
* removed open() and release() functions as suggested (they were to disable interrupts at
release(), but this is already being taken care of in the isr)


The series contains:

[PATCH v2 1/3] [ARM] s3c-fb: Corrected defines for framesel1 register.
[PATCH v2 2/3] [ARM] s3c-fb: Added support for panning the display in both directions.
[PATCH v2 3/3] [ARM] s3c-fb: Added wait for VSYNC support.


Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center

[PATCH v2 0/3] v2: s3c-fb panning and vsync support

[Pawel Osciak]

Hello,

this is the second version of my previous patchset, corrected after your feedback (thank you).

[v2]:

In the panning patch:
* panning is done per-byte (the unit used in VIDW_BUF_START) and has been tested for different
bpps, including bpp < 8

* introduced the PRTCON register, which basically disables in-hardware updates from
shadow registers for VIDW_BUF_START/END (and a couple of others):
- shadow registers are updated on vsync (in hw)
- the update will not occur if PRTCON protection is enabled
This way we are safe when updating them@any time, even though they are separate.

In VSYNC patch:
* removed open() and release() functions as suggested (they were to disable interrupts at
release(), but this is already being taken care of in the isr)


The series contains:

[PATCH v2 1/3] [ARM] s3c-fb: Corrected defines for framesel1 register.
[PATCH v2 2/3] [ARM] s3c-fb: Added support for panning the display in both directions.
[PATCH v2 3/3] [ARM] s3c-fb: Added wait for VSYNC support.


Best regards
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center

RE: [PATCH v2 0/3] v2: s3c-fb panning and vsync support

[Pawel Osciak]

Hello,

>this is the second version of my previous patchset, corrected after your feedback (thank you).
[...]
>The series contains:
>
>[PATCH v2 1/3] [ARM] s3c-fb: Corrected defines for framesel1 register.
>[PATCH v2 2/3] [ARM] s3c-fb: Added support for panning the display in both directions.
>[PATCH v2 3/3] [ARM] s3c-fb: Added wait for VSYNC support.

may I ask for comments on this patchset (and possibly the later one)?
Is it suitable for merging? What could I do for it to be merged?

Thank you and best regards,
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center

[PATCH v2 0/3] v2: s3c-fb panning and vsync support

[Pawel Osciak]

Hello,

>this is the second version of my previous patchset, corrected after your feedback (thank you).
[...]
>The series contains:
>
>[PATCH v2 1/3] [ARM] s3c-fb: Corrected defines for framesel1 register.
>[PATCH v2 2/3] [ARM] s3c-fb: Added support for panning the display in both directions.
>[PATCH v2 3/3] [ARM] s3c-fb: Added wait for VSYNC support.

may I ask for comments on this patchset (and possibly the later one)?
Is it suitable for merging? What could I do for it to be merged?

Thank you and best regards,
--
Pawel Osciak
Linux Platform Group
Samsung Poland R&D Center